From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ananyev, Konstantin" Subject: Re: [PATCH v8 0/5] User-space Ethtool Date: Fri, 26 Jun 2015 19:15:01 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836A1EA9A@irsmsx105.ger.corp.intel.com> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1435328807-15788-1-git-send-email-liang-min.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Wang, Liang-min" To: "Wang, Liang-min" , "dev@dpdk.org" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1FFA3C9BA for ; Fri, 26 Jun 2015 21:15:03 +0200 (CEST) In-Reply-To: <1435328807-15788-1-git-send-email-liang-min.wang@intel.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Liang-Min Larry Wang > Sent: Friday, June 26, 2015 3:27 PM > To: dev@dpdk.org > Cc: Wang, Liang-min > Subject: [dpdk-dev] [PATCH v8 0/5] User-space Ethtool >=20 > This implementation is designed to provide a familar interface for applic= ations that rely on kernel-space driver to support ethtool_op > and net_device_op for device management. The initial implementation focus= es on ops that can be implemented through existing > netdev APIs. More ops will be supported in latter release. >=20 > v8 changes: > - Changed register tables to const. > v7 change: > - Remove rte_eth_dev_get_ringparam implementation > v6 change: > - Rebase to match new changes over librte_ether > v5 change: > - Change API name from 'leng' to 'length' > - Remove unused data structure rte_dev_vf_info > - Remove placeholder API rte_eth_dev_set_ringparam > - Clean up set_mac_addr implementation > v4 change: > - Add rte_eth_xxx apis and respective ops over igb and ixgbe > to support ethtool and net device alike ops > - Add an example to demonstrate the use of ethtool library > v3 change: > - Fix a build issue > v2 change: > - Implement rte_eth_dev_default_mac_addr_set through dev_ops::mac_addr_se= t so it would support NIC devices other than ixgbe > and igb >=20 > Andrew G. Harvey (1): > Changed register tables to const. >=20 > Liang-Min Larry Wang (4): > ethdev: add apis to support access device info > ixgbe: add ops to support ethtool ops > igb: add ops to support ethtool ops > examples: new example: l2fwd-ethtool >=20 > drivers/net/e1000/igb_ethdev.c | 186 ++++ > drivers/net/e1000/igb_regs.h | 217 +++++ > drivers/net/ixgbe/ixgbe_ethdev.c | 183 ++++ > drivers/net/ixgbe/ixgbe_regs.h | 357 ++++++++ > examples/l2fwd-ethtool/Makefile | 55 ++ > examples/l2fwd-ethtool/l2fwd-app/Makefile | 58 ++ > examples/l2fwd-ethtool/l2fwd-app/main.c | 1030 ++++++++++++++++= ++++++ > examples/l2fwd-ethtool/l2fwd-app/netdev_api.h | 781 ++++++++++++++++ > examples/l2fwd-ethtool/l2fwd-app/shared_fifo.h | 151 ++++ > examples/l2fwd-ethtool/lib/Makefile | 55 ++ > examples/l2fwd-ethtool/lib/rte_ethtool.c | 301 +++++++ > examples/l2fwd-ethtool/lib/rte_ethtool.h | 378 ++++++++ > examples/l2fwd-ethtool/nic-control/Makefile | 55 ++ > examples/l2fwd-ethtool/nic-control/nic_control.c | 412 +++++++++ > lib/librte_ether/Makefile | 1 + > lib/librte_ether/rte_eth_dev_info.h | 57 ++ > lib/librte_ether/rte_ethdev.c | 115 +++ > lib/librte_ether/rte_ethdev.h | 117 +++ > lib/librte_ether/rte_ether_version.map | 6 + > 19 files changed, 4515 insertions(+) > create mode 100644 drivers/net/e1000/igb_regs.h > create mode 100644 drivers/net/ixgbe/ixgbe_regs.h > create mode 100644 examples/l2fwd-ethtool/Makefile > create mode 100644 examples/l2fwd-ethtool/l2fwd-app/Makefile > create mode 100644 examples/l2fwd-ethtool/l2fwd-app/main.c > create mode 100644 examples/l2fwd-ethtool/l2fwd-app/netdev_api.h > create mode 100644 examples/l2fwd-ethtool/l2fwd-app/shared_fifo.h > create mode 100644 examples/l2fwd-ethtool/lib/Makefile > create mode 100644 examples/l2fwd-ethtool/lib/rte_ethtool.c > create mode 100644 examples/l2fwd-ethtool/lib/rte_ethtool.h > create mode 100644 examples/l2fwd-ethtool/nic-control/Makefile > create mode 100644 examples/l2fwd-ethtool/nic-control/nic_control.c > create mode 100644 lib/librte_ether/rte_eth_dev_info.h >=20 > -- Acked-by: Konstantin Ananyev Please fix checkpatch.pl issues. > 2.1.4