From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [RFC PATCHv3 0/7] add OSv support
Date: Thu, 09 Jul 2015 01:35:51 +0200
Message-ID: <2695914.AOYJdCUfZl@xps13>
References: <1428346691-14894-1-git-send-email-syuu@cloudius-systems.com>
 <CAPWdgggjvMZGUpY6_GPjCgqN00UiWkm50M8z3oLa7gU8x1BmbA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Takuya ASADA <syuu@cloudius-systems.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id D4A839E7
 for <dev@dpdk.org>; Thu,  9 Jul 2015 01:36:56 +0200 (CEST)
Received: by wgov12 with SMTP id v12so24234128wgo.1
 for <dev@dpdk.org>; Wed, 08 Jul 2015 16:36:56 -0700 (PDT)
In-Reply-To: <CAPWdgggjvMZGUpY6_GPjCgqN00UiWkm50M8z3oLa7gU8x1BmbA@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Takuya,

It has been difficult to receive comments on this series during 2.1 cycle.
I see 3 reasons:
- few people know OSv
- the series is mixing C++ support and OSv environment
- you are adding a third system to support while some work is in progress
  to reduce differences between Linux and BSD support.

I suggest to:
- fix doc with John's help
- split C++ and OSv patches
- help to merge Linux and BSD common code
- introduce a common config file for every environments
- re-send OSv support series at the beginning of 2.2 cycle without RFC keyword

Thanks for your work

2015-04-21 03:37, Takuya ASADA:
> Any comments/suggestions?
> 
> On Tue, Apr 7, 2015 at 3:58 AM, Takuya ASADA <syuu@cloudius-systems.com>
> wrote:
> 
> > This is 3rd version of OSv support patchset.
> >
> > Changelist:
> >  - sync with latest master
> >  - updated Capstan build script for OSv v0.19
> >  - rte_eal_version.map fix
> >  - CONFIG_RTE_BUILD_SHARED_LIB=y and CONFIG_RTE_BUILD_COMBINE_LIBS=y by
> > default
> >  - Check OSv NIC driver is loaded for each device, attach PMD only if OSv
> > driver is not loaded
> >  - Use --maxnic on cmdline to skip loading OSv NIC driver
> >  - Don't enable MSI-X on virtio, since it's not enable when OSv NIC driver
> > is not loaded
> >
> > Takuya ASADA (7):
> >   mk: support compiling C++ code
> >   eal: Add extern C on eal_hugepages.h
> >   eal: Add extern C on eal_thread.h
> >   eal: Add extern C on eal_private.h
> >   add OSv support
> >   app/test: support OSv
> >   doc: Add Getting Started Guide for OSv