All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Jan Olszak <j.olszak@samsung.com>
Cc: dhowells@redhat.com, Miklos Szeredi <miklos@szeredi.hu>,
	"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>
Subject: Re: Optional switching off cow in overlayfs
Date: Tue, 23 Jun 2015 10:27:39 +0100	[thread overview]
Message-ID: <29219.1435051659@warthog.procyon.org.uk> (raw)
In-Reply-To: <55882AA5.10908@samsung.com>

Jan Olszak <j.olszak@samsung.com> wrote:

> >>>    But what should happen on rename or unlink?
> >> Both would operate on the original inode.
> > And that would make this hugely complex.
> Are you sure?

Unlink would be the same as now - you just whiteout over the lower layer.

Rename, though, would be complex - unless you go for the trivial option and
just error out.

The problem is that the only connection between the upper layer and lower
layer is coincidence governed by filename.  If you move the upper layer
object, the lower layer object is no longer coincident and is effectively
lost.  You cannot move the lower layer object because the lower layer may be
shared between multiple overlays.

At the moment, rename deals

You could, I suppose, store a "fall through" inode in the upper layer that has
the NFS fh of the lower layer object attached in some fashion (eg. xattr), but
it's messy.

Hard linking would be even more complex - you'd have to hard link the "fall
through" inodes on the upper layer.

David

  parent reply	other threads:[~2015-06-23  9:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 13:25 Optional switching off cow in overlayfs Jan Olszak
2015-06-18 13:39 ` David Howells
2015-06-18 14:43   ` Jan Olszak
2015-06-22 11:32     ` Miklos Szeredi
2015-06-22 13:45       ` Jan Olszak
2015-06-22 13:53         ` Miklos Szeredi
2015-06-22 14:26           ` Jan Olszak
2015-06-22 14:37             ` Miklos Szeredi
2015-06-22 15:32               ` Jan Olszak
2015-06-23  9:27               ` David Howells [this message]
2015-06-23 10:36                 ` Jan Olszak
2015-06-23 13:23                 ` David Howells
2015-06-23 16:05                   ` Jan Olszak
2015-06-23 16:07                   ` Jan Olszak
2015-06-24 16:03                     ` Jan Olszak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29219.1435051659@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=j.olszak@samsung.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.