* [U-Boot] [PATCH] firmware: zynqmp: Clean up zynqmp_power_probe
@ 2019-10-10 9:33 Michal Simek
2019-10-10 10:22 ` Luca Ceresoli
2019-10-24 11:16 ` Michal Simek
0 siblings, 2 replies; 3+ messages in thread
From: Michal Simek @ 2019-10-10 9:33 UTC (permalink / raw
To: u-boot
Fix error debug messages to be more accurate and aligned with debug message
style in the whole file.
And do not initialize ret variable because it is initialized later on and
it is just additional step.
Fixes: 1327d1678bd2 ("firmware: zynqmp: Add zynqmp-power support")
Reported-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/firmware/firmware-zynqmp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c
index 4911734f6c63..dea58b558102 100644
--- a/drivers/firmware/firmware-zynqmp.c
+++ b/drivers/firmware/firmware-zynqmp.c
@@ -110,19 +110,19 @@ void zynqmp_pmufw_load_config_object(const void *cfg_obj, size_t size)
static int zynqmp_power_probe(struct udevice *dev)
{
- int ret = 0;
+ int ret;
debug("%s, (dev=%p)\n", __func__, dev);
ret = mbox_get_by_name(dev, "tx", &zynqmp_power.tx_chan);
if (ret) {
- debug("%s, cannot tx mailbox\n", __func__);
+ debug("%s: Cannot find tx mailbox\n", __func__);
return ret;
}
ret = mbox_get_by_name(dev, "rx", &zynqmp_power.rx_chan);
if (ret) {
- debug("%s, cannot rx mailbox\n", __func__);
+ debug("%s: Cannot find rx mailbox\n", __func__);
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] firmware: zynqmp: Clean up zynqmp_power_probe
2019-10-10 9:33 [U-Boot] [PATCH] firmware: zynqmp: Clean up zynqmp_power_probe Michal Simek
@ 2019-10-10 10:22 ` Luca Ceresoli
2019-10-24 11:16 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2019-10-10 10:22 UTC (permalink / raw
To: u-boot
Hi,
On 10/10/19 11:33, Michal Simek wrote:
> Fix error debug messages to be more accurate and aligned with debug message
> style in the whole file.
> And do not initialize ret variable because it is initialized later on and
> it is just additional step.
>
> Fixes: 1327d1678bd2 ("firmware: zynqmp: Add zynqmp-power support")
> Reported-by: Luca Ceresoli <luca@lucaceresoli.net>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
--
Luca
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] firmware: zynqmp: Clean up zynqmp_power_probe
2019-10-10 9:33 [U-Boot] [PATCH] firmware: zynqmp: Clean up zynqmp_power_probe Michal Simek
2019-10-10 10:22 ` Luca Ceresoli
@ 2019-10-24 11:16 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2019-10-24 11:16 UTC (permalink / raw
To: u-boot
čt 10. 10. 2019 v 11:33 odesílatel Michal Simek
<michal.simek@xilinx.com> napsal:
>
> Fix error debug messages to be more accurate and aligned with debug message
> style in the whole file.
> And do not initialize ret variable because it is initialized later on and
> it is just additional step.
>
> Fixes: 1327d1678bd2 ("firmware: zynqmp: Add zynqmp-power support")
> Reported-by: Luca Ceresoli <luca@lucaceresoli.net>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/firmware/firmware-zynqmp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c
> index 4911734f6c63..dea58b558102 100644
> --- a/drivers/firmware/firmware-zynqmp.c
> +++ b/drivers/firmware/firmware-zynqmp.c
> @@ -110,19 +110,19 @@ void zynqmp_pmufw_load_config_object(const void *cfg_obj, size_t size)
>
> static int zynqmp_power_probe(struct udevice *dev)
> {
> - int ret = 0;
> + int ret;
>
> debug("%s, (dev=%p)\n", __func__, dev);
>
> ret = mbox_get_by_name(dev, "tx", &zynqmp_power.tx_chan);
> if (ret) {
> - debug("%s, cannot tx mailbox\n", __func__);
> + debug("%s: Cannot find tx mailbox\n", __func__);
> return ret;
> }
>
> ret = mbox_get_by_name(dev, "rx", &zynqmp_power.rx_chan);
> if (ret) {
> - debug("%s, cannot rx mailbox\n", __func__);
> + debug("%s: Cannot find rx mailbox\n", __func__);
> return ret;
> }
>
> --
> 2.17.1
>
Applied.
M
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-24 11:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-10 9:33 [U-Boot] [PATCH] firmware: zynqmp: Clean up zynqmp_power_probe Michal Simek
2019-10-10 10:22 ` Luca Ceresoli
2019-10-24 11:16 ` Michal Simek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.