From: Markus Elfring <Markus.Elfring@web.de>
To: LuMingYin <lumingyindetect@126.com>,
linux-trace-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] tracing/probes: Fix memory leak in traceprobe_parse_probe_arg_body
Date: Sat, 27 Apr 2024 08:36:17 +0200 [thread overview]
Message-ID: <29b2bd7d-303c-4ac9-8638-38959f177316@web.de> (raw)
In-Reply-To: <20240427025720.1321211-1-lumingyindetect@126.com>
I suggest to append parentheses to the function name in the summary phrase.
> If traceprobe_parse_probe_arg_body() fails to allocate 'parg->fmt', it
> jumps to 'out' instead of 'fail' by mistake. In the result, in this
> case the 'tmp' buffer is not freed and leaks its memory.
>
> Fix it by jumping to 'fail' in that case.
I propose to improve such a change description another bit like the following.
If traceprobe_parse_probe_arg_body() failed to allocate the object “parg->fmt”,
it jumps to the label “out” instead of “fail” by mistake.
In the result, the buffer “tmp” is not freed in this case and leaks its memory.
Thus jump to the label “fail” in that error case.
Regards,
Markus
prev parent reply other threads:[~2024-04-27 6:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 2:57 [PATCH v2] tracing/probes: Fix memory leak in traceprobe_parse_probe_arg_body lumingyindetect
2024-04-27 6:36 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29b2bd7d-303c-4ac9-8638-38959f177316@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lumingyindetect@126.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.