All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/5] auto-t: add ctrl_interface to testOWE
@ 2019-11-13 22:30 James Prestwood
  2019-11-13 22:30 ` [PATCH 2/5] auto-t: add ctrl_interface to testFILS James Prestwood
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: James Prestwood @ 2019-11-13 22:30 UTC (permalink / raw
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

This is now required for any test using HostapdCLI
---
 autotests/testOWE/ssidGroup20.conf | 1 +
 autotests/testOWE/ssidOWE.conf     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/autotests/testOWE/ssidGroup20.conf b/autotests/testOWE/ssidGroup20.conf
index 72f84091..afd5c0a4 100644
--- a/autotests/testOWE/ssidGroup20.conf
+++ b/autotests/testOWE/ssidGroup20.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 ssid=ssidGroup20
diff --git a/autotests/testOWE/ssidOWE.conf b/autotests/testOWE/ssidOWE.conf
index b9c79d82..a0a4f26c 100644
--- a/autotests/testOWE/ssidOWE.conf
+++ b/autotests/testOWE/ssidOWE.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 ssid=ssidOWE
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/5] auto-t: add ctrl_interface to testFILS
  2019-11-13 22:30 [PATCH 1/5] auto-t: add ctrl_interface to testOWE James Prestwood
@ 2019-11-13 22:30 ` James Prestwood
  2019-11-13 22:30 ` [PATCH 3/5] auto-t: add ctrl_interface to testHT-VHT James Prestwood
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: James Prestwood @ 2019-11-13 22:30 UTC (permalink / raw
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

This is now required for any test using HostapdCLI
---
 autotests/testFILS/ssidFILS-256.conf | 1 +
 autotests/testFILS/ssidFILS-384.conf | 1 +
 2 files changed, 2 insertions(+)

diff --git a/autotests/testFILS/ssidFILS-256.conf b/autotests/testFILS/ssidFILS-256.conf
index bf86d3f4..b3f3139a 100644
--- a/autotests/testFILS/ssidFILS-256.conf
+++ b/autotests/testFILS/ssidFILS-256.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 ssid=ssidFILS-256
diff --git a/autotests/testFILS/ssidFILS-384.conf b/autotests/testFILS/ssidFILS-384.conf
index a090d537..9a3a3059 100644
--- a/autotests/testFILS/ssidFILS-384.conf
+++ b/autotests/testFILS/ssidFILS-384.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 ssid=ssidFILS-384
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/5] auto-t: add ctrl_interface to testHT-VHT
  2019-11-13 22:30 [PATCH 1/5] auto-t: add ctrl_interface to testOWE James Prestwood
  2019-11-13 22:30 ` [PATCH 2/5] auto-t: add ctrl_interface to testFILS James Prestwood
@ 2019-11-13 22:30 ` James Prestwood
  2019-11-13 22:30 ` [PATCH 4/5] auto-t: add ctrl_interface to testHotspot James Prestwood
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: James Prestwood @ 2019-11-13 22:30 UTC (permalink / raw
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

This is now required for any test using HostapdCLI
---
 autotests/testHT-VHT/ht.conf         | 1 +
 autotests/testHT-VHT/non-ht-vht.conf | 1 +
 autotests/testHT-VHT/vht.conf        | 1 +
 3 files changed, 3 insertions(+)

diff --git a/autotests/testHT-VHT/ht.conf b/autotests/testHT-VHT/ht.conf
index b5dbc0d5..9a84b063 100644
--- a/autotests/testHT-VHT/ht.conf
+++ b/autotests/testHT-VHT/ht.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=a
 channel=2
 ssid=testSSID
diff --git a/autotests/testHT-VHT/non-ht-vht.conf b/autotests/testHT-VHT/non-ht-vht.conf
index ae6e2dac..6df06a02 100644
--- a/autotests/testHT-VHT/non-ht-vht.conf
+++ b/autotests/testHT-VHT/non-ht-vht.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 ssid=testSSID
diff --git a/autotests/testHT-VHT/vht.conf b/autotests/testHT-VHT/vht.conf
index 23453a76..9a7ec0d7 100644
--- a/autotests/testHT-VHT/vht.conf
+++ b/autotests/testHT-VHT/vht.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 ssid=testSSID
 wpa=2
 wpa_pairwise=CCMP
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/5] auto-t: add ctrl_interface to testHotspot
  2019-11-13 22:30 [PATCH 1/5] auto-t: add ctrl_interface to testOWE James Prestwood
  2019-11-13 22:30 ` [PATCH 2/5] auto-t: add ctrl_interface to testFILS James Prestwood
  2019-11-13 22:30 ` [PATCH 3/5] auto-t: add ctrl_interface to testHT-VHT James Prestwood
@ 2019-11-13 22:30 ` James Prestwood
  2019-11-13 22:30 ` [PATCH 5/5] hotspot: fix double free between hostpot and knownnetworks James Prestwood
  2019-11-13 22:37 ` [PATCH 1/5] auto-t: add ctrl_interface to testOWE Denis Kenzior
  4 siblings, 0 replies; 6+ messages in thread
From: James Prestwood @ 2019-11-13 22:30 UTC (permalink / raw
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

This is now required for any test using HostapdCLI
---
 autotests/testHotspot/ssidHotspotUnconfigured.conf | 1 +
 autotests/testHotspot/ssidWPA2-1.conf              | 1 +
 autotests/testHotspot/ssidWPA2-2.conf              | 1 +
 autotests/testHotspot/ssidWPA2-3.conf              | 1 +
 4 files changed, 4 insertions(+)

diff --git a/autotests/testHotspot/ssidHotspotUnconfigured.conf b/autotests/testHotspot/ssidHotspotUnconfigured.conf
index 5eff0b10..287dab6c 100644
--- a/autotests/testHotspot/ssidHotspotUnconfigured.conf
+++ b/autotests/testHotspot/ssidHotspotUnconfigured.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 wpa=2
diff --git a/autotests/testHotspot/ssidWPA2-1.conf b/autotests/testHotspot/ssidWPA2-1.conf
index bc1b760c..0c9aede5 100644
--- a/autotests/testHotspot/ssidWPA2-1.conf
+++ b/autotests/testHotspot/ssidWPA2-1.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=2
 ssid=ssidWPA2-1
diff --git a/autotests/testHotspot/ssidWPA2-2.conf b/autotests/testHotspot/ssidWPA2-2.conf
index 59b05986..2058d4a3 100644
--- a/autotests/testHotspot/ssidWPA2-2.conf
+++ b/autotests/testHotspot/ssidWPA2-2.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=3
 ssid=ssidWPA2-2
diff --git a/autotests/testHotspot/ssidWPA2-3.conf b/autotests/testHotspot/ssidWPA2-3.conf
index c330eb8a..d536ebd1 100644
--- a/autotests/testHotspot/ssidWPA2-3.conf
+++ b/autotests/testHotspot/ssidWPA2-3.conf
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=4
 ssid=ssidWPA2-3
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 5/5] hotspot: fix double free between hostpot and knownnetworks
  2019-11-13 22:30 [PATCH 1/5] auto-t: add ctrl_interface to testOWE James Prestwood
                   ` (2 preceding siblings ...)
  2019-11-13 22:30 ` [PATCH 4/5] auto-t: add ctrl_interface to testHotspot James Prestwood
@ 2019-11-13 22:30 ` James Prestwood
  2019-11-13 22:37 ` [PATCH 1/5] auto-t: add ctrl_interface to testOWE Denis Kenzior
  4 siblings, 0 replies; 6+ messages in thread
From: James Prestwood @ 2019-11-13 22:30 UTC (permalink / raw
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

The module framework was changed to call the module exit functions in
the reverse order as the init functions. This uncovered/caused known
networks to try and free the network_info structures after hotspot had
already freed them. Since known networks clean up the network_info's
anyways, we don't actually need hotspot to do any cleanup.
---
 src/hotspot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/hotspot.c b/src/hotspot.c
index 68fc5a66..6a95757b 100644
--- a/src/hotspot.c
+++ b/src/hotspot.c
@@ -524,7 +524,7 @@ static void hotspot_exit(void)
 {
 	l_dir_watch_destroy(hs20_dir_watch);
 
-	l_queue_destroy(hs20_settings, hs20_config_free);
+	l_queue_destroy(hs20_settings, NULL);
 	hs20_settings = NULL;
 }
 
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/5] auto-t: add ctrl_interface to testOWE
  2019-11-13 22:30 [PATCH 1/5] auto-t: add ctrl_interface to testOWE James Prestwood
                   ` (3 preceding siblings ...)
  2019-11-13 22:30 ` [PATCH 5/5] hotspot: fix double free between hostpot and knownnetworks James Prestwood
@ 2019-11-13 22:37 ` Denis Kenzior
  4 siblings, 0 replies; 6+ messages in thread
From: Denis Kenzior @ 2019-11-13 22:37 UTC (permalink / raw
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi James,

On 11/13/19 4:30 PM, James Prestwood wrote:
> This is now required for any test using HostapdCLI
> ---
>   autotests/testOWE/ssidGroup20.conf | 1 +
>   autotests/testOWE/ssidOWE.conf     | 1 +
>   2 files changed, 2 insertions(+)
> 

all applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-11-13 22:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-13 22:30 [PATCH 1/5] auto-t: add ctrl_interface to testOWE James Prestwood
2019-11-13 22:30 ` [PATCH 2/5] auto-t: add ctrl_interface to testFILS James Prestwood
2019-11-13 22:30 ` [PATCH 3/5] auto-t: add ctrl_interface to testHT-VHT James Prestwood
2019-11-13 22:30 ` [PATCH 4/5] auto-t: add ctrl_interface to testHotspot James Prestwood
2019-11-13 22:30 ` [PATCH 5/5] hotspot: fix double free between hostpot and knownnetworks James Prestwood
2019-11-13 22:37 ` [PATCH 1/5] auto-t: add ctrl_interface to testOWE Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.