From: Andrew Cooper <andrew.cooper3@citrix.com>
To: dmkhn@proton.me, xen-devel@lists.xenproject.org
Cc: anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org,
michal.orzel@amd.com, roger.pau@citrix.com,
sstabellini@kernel.org, dmukhin@ford.com
Subject: Re: [PATCH] xen/console: pre-compute domain prefix for printouts
Date: Thu, 13 Feb 2025 23:28:41 +0000 [thread overview]
Message-ID: <30dbb0ca-33d8-40fa-9c98-9ea266ff44c2@citrix.com> (raw)
In-Reply-To: <20250213214350.1745843-1-dmukhin@ford.com>
On 13/02/2025 10:35 pm, dmkhn@proton.me wrote:
> Every guest_printk() call computes "(d%d) " prefix on every call.
> Move prefix generation to the domain creation time.
>
> Signed-off-by: Denis Mukhin <dmukhin@ford.com>
I'm on the fence here.
Part of that is speaking as someone who has had to shrink struct domain
several times to keep it fitting within 1 page.
But as to calculating it every time, does that matter? In production
environments, we get a handful of print lines per domain across their
lifetime. Is the saving really worth it?
~Andrew
next prev parent reply other threads:[~2025-02-13 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 22:35 [PATCH] xen/console: pre-compute domain prefix for printouts dmkhn
2025-02-13 23:28 ` Andrew Cooper [this message]
2025-02-14 7:42 ` Denis Mukhin
2025-02-14 7:58 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30dbb0ca-33d8-40fa-9c98-9ea266ff44c2@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=dmkhn@proton.me \
--cc=dmukhin@ford.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.