From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Marc Gonzalez <mgonzalez@freebox.fr>,
Bjorn Andersson <andersson@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Douglas Anderson <dianders@chromium.org>,
Pierre-Hugues Husson <phhusson@freebox.fr>,
Arnaud Vrac <avrac@freebox.fr>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v3] clk: qcom: mmcc-msm8998: fix venus clock issue
Date: Mon, 29 Apr 2024 16:52:38 +0200 [thread overview]
Message-ID: <312d3cbd-852e-4b93-8bef-c78827712f56@linaro.org> (raw)
In-Reply-To: <1bbd5175-31a3-4c4c-b2b6-6ee7c65bb17f@linaro.org>
On 4/29/24 16:39, Bryan O'Donoghue wrote:
> On 29/04/2024 14:45, Marc Gonzalez wrote:
>> On 27/04/2024 21:34, Bjorn Andersson wrote:
>>
>>> On Thu, 25 Apr 2024 17:07:07 +0200, Marc Gonzalez wrote:
>>>
>>>> Right now, msm8998 video decoder (venus) is non-functional:
>>>>
>>>> $ time mpv --hwdec=v4l2m2m-copy --vd-lavc-software-fallback=no --vo=null --no-audio --untimed --length=30 --quiet demo-480.webm
>>>> (+) Video --vid=1 (*) (vp9 854x480 29.970fps)
>>>> Audio --aid=1 --alang=eng (*) (opus 2ch 48000Hz)
>>>> [ffmpeg/video] vp9_v4l2m2m: output VIDIOC_REQBUFS failed: Connection timed out
>>>> [ffmpeg/video] vp9_v4l2m2m: no v4l2 output context's buffers
>>>> [ffmpeg/video] vp9_v4l2m2m: can't configure decoder
>>>> Could not open codec.
>>>> Software decoding fallback is disabled.
>>>> Exiting... (Quit)
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>> [1/1] clk: qcom: mmcc-msm8998: fix venus clock issue
>>> commit: e20ae5ae9f0c843aded4f06f3d1cab7384789e92
>>
>> Yes!
>>
>> Going on a tangent.
>>
>> During my tests, I saw an unrelated error in the boot log:
>>
>> [ 10.404521] clk: Disabling unused clocks
>> [ 10.412141] ------------[ cut here ]------------
>> [ 10.415538] vmem_ahb_clk status stuck at 'on'
We currently don't support VMEM (which is a small SRAM dedicated to venus)
upstream, but venus functions without it (albeit I'd expect it to be
slower or not fully capable without it)
>> [ 10.415570] WARNING: CPU: 0 PID: 1 at drivers/clk/qcom/clk-branch.c:87 clk_branch_toggle+0x160/0x178
>> [ 10.424420] Modules linked in:
>> [ 10.433586] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc1-00027-g483ea571c987 #70
>> [ 10.436478] Hardware name: Freebox Delta (DT)
>> [ 10.444356] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
>> [ 10.448884] pc : clk_branch_toggle+0x160/0x178
>> [ 10.455642] lr : clk_branch_toggle+0x160/0x178
>> [ 10.460154] sp : ffff80008005bc40
>> [ 10.464574] x29: ffff80008005bc40 x28: 0000000000000000 x27: ffff800082df9070
>> [ 10.467982] x26: ffff800082d100b0 x25: ffff800082c57cb0 x24: ffff800082b23958
>> [ 10.475100] x23: 0000000000000000 x22: 0000000000000000 x21: ffff8000833b6208
>> [ 10.482218] x20: ffff80008072bbec x19: 0000000000000000 x18: ffffffffff00d218
>> [ 10.489337] x17: ffff800083476aa8 x16: ffff800083476a38 x15: 0000000000000030
>> [ 10.496454] x14: 0000000000000000 x13: ffff0000f5348000 x12: 000000000000086d
>> [ 10.503572] x11: 00000000000002cf x10: ffff0000f7f4c368 x9 : ffff0000f5348000
>> [ 10.510692] x8 : 00000000fff7ffff x7 : ffff0000f7f48000 x6 : 00000000000002cf
>> [ 10.517809] x5 : 00000000005ffff4 x4 : 40000000fff802cf x3 : 0000000000000000
>> [ 10.524926] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff000080118000
>> [ 10.532046] Call trace:
>> [ 10.539137] clk_branch_toggle+0x160/0x178
>> [ 10.541402] clk_branch2_disable+0x1c/0x28
>> [ 10.545569] clk_disable_unused_subtree+0xfc/0x138
>> [ 10.549652] clk_disable_unused_subtree+0x2c/0x138
>> [ 10.554427] clk_disable_unused_subtree+0x2c/0x138
>> [ 10.559201] clk_disable_unused_subtree+0x2c/0x138
>> [ 10.563975] clk_disable_unused_subtree+0x2c/0x138
>> [ 10.568749] clk_disable_unused_subtree+0x2c/0x138
>> [ 10.573525] clk_disable_unused_subtree+0x2c/0x138
>> [ 10.578298] clk_disable_unused+0x50/0x138
>> [ 10.583070] do_one_initcall+0x6c/0x1b0
>> [ 10.587147] kernel_init_freeable+0x1d4/0x2cc
>> [ 10.590883] kernel_init+0x20/0x1d8
>> [ 10.595391] ret_from_fork+0x10/0x20
>> [ 10.598693] ---[ end trace 0000000000000000 ]---
>
> Taking sm8250 as an example the vidoecc ahb clk is a candidate to be always-on.
>
> drivers/clk/qcom/videocc-sm8250.c
> qcom_branch_set_clk_en(regmap, 0xe58); /* VIDEO_CC_AHB_CLK */
This is totally unrelated
Konrad
next prev parent reply other threads:[~2024-04-29 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 15:07 [PATCH v3] clk: qcom: mmcc-msm8998: fix venus clock issue Marc Gonzalez
2024-04-26 21:00 ` Jeffrey Hugo
2024-04-27 19:34 ` Bjorn Andersson
2024-04-29 13:45 ` Marc Gonzalez
2024-04-29 14:39 ` Bryan O'Donoghue
2024-04-29 14:52 ` Konrad Dybcio [this message]
2024-04-29 15:04 ` Bryan O'Donoghue
2024-04-30 10:00 ` Konrad Dybcio
2024-04-30 10:04 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=312d3cbd-852e-4b93-8bef-c78827712f56@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=avrac@freebox.fr \
--cc=bryan.odonoghue@linaro.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mgonzalez@freebox.fr \
--cc=mturquette@baylibre.com \
--cc=phhusson@freebox.fr \
--cc=quic_jhugo@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.