From: Arnd Bergmann <arnd@arndb.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
Network Development <netdev@vger.kernel.org>,
Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>,
Andy Lutomirski <luto@amacapital.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexander Larsson <alexl@redhat.com>,
Cosimo Cecchi <cosimo@endlessm.com>,
Dan Nicholson <nicholson@endlessm.com>,
libc-alpha <libc-alpha@sourceware.org>,
Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] x86: Wire up 32-bit direct socket calls
Date: Mon, 07 Sep 2015 14:53:12 +0200 [thread overview]
Message-ID: <3193269.4TGcgnGPrm@wuerfel> (raw)
In-Reply-To: <55E75913.5050605@zytor.com>
On Wednesday 02 September 2015 13:16:19 H. Peter Anvin wrote:
> On 09/02/2015 02:48 AM, Geert Uytterhoeven wrote:
> >
> > Should all other architectures follow suit?
> > Or should we follow the s390 approach:
> >
>
> It is up to the maintainer(s), largely dependent on how likely you are
> going to want to support this in your libc, but in general, socketcall
> is an abomination which there is no reason not to bypass.
>
> So follow suit unless you have a strong reason not to.
+1
In my y2038 syscall series, I'm adding a new recvmmsg64 call, and
we may decide to add new setsockopt/getsockopt variants as well.
This is probably not the last change to socketcall, and it would
be made much easier if all architectures had separate calls here.
It seems that there are very few architectures that don't already have
the separate calls:
$ git grep -l __NR_socketcall arch/*/include/uapi | xargs git grep -L recvmsg
arch/cris/include/uapi/asm/unistd.h
arch/frv/include/uapi/asm/unistd.h
arch/m32r/include/uapi/asm/unistd.h
arch/m68k/include/uapi/asm/unistd.h
arch/mn10300/include/uapi/asm/unistd.h
arch/s390/include/uapi/asm/unistd.h
These are of course all examples of architectures that originally followed
the i386 syscall scheme closely rather than trying to leave out obsolete
calls.
Arnd
next prev parent reply other threads:[~2015-09-07 12:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 22:24 [PATCH] x86: Wire up 32-bit direct socket calls Andy Lutomirski
2015-07-21 9:41 ` [tip:x86/asm] x86/entry/syscalls: " tip-bot for Andy Lutomirski
2015-09-02 9:48 ` [PATCH] x86: " Geert Uytterhoeven
2015-09-02 20:16 ` H. Peter Anvin
2015-09-03 10:06 ` David Laight
2015-09-03 10:06 ` David Laight
2015-09-07 12:53 ` Arnd Bergmann [this message]
2015-09-11 8:24 ` Heiko Carstens
2015-09-11 8:46 ` Arnd Bergmann
2015-09-11 9:54 ` Geert Uytterhoeven
2015-09-11 10:14 ` Arnd Bergmann
2015-09-11 16:32 ` Andy Lutomirski
2015-09-14 13:35 ` Ingo Molnar
2015-09-15 20:55 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3193269.4TGcgnGPrm@wuerfel \
--to=arnd@arndb.de \
--cc=alexl@redhat.com \
--cc=cosimo@endlessm.com \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicholson@endlessm.com \
--cc=raji@linux.vnet.ibm.com \
--cc=tuliom@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.