From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38475C19F2A for ; Thu, 11 Aug 2022 09:40:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234909AbiHKJks (ORCPT ); Thu, 11 Aug 2022 05:40:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232585AbiHKJkk (ORCPT ); Thu, 11 Aug 2022 05:40:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64D5174E3F for ; Thu, 11 Aug 2022 02:40:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AEFA66119D for ; Thu, 11 Aug 2022 09:40:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48850C433D6; Thu, 11 Aug 2022 09:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660210838; bh=q/v3dg67akdikMYOPlR6gnL028wD7LycKf4a1kmvX/8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=E7ayhDL52bXNsVrHoUoyQ+wAZTeoQifLoV2Q4j53SPWNLt+B4oGEld0OCpWBv3m4M MRdCcNQWMkMOgnqbkXIzXYESAxfuPjpP+i2xyIJcAYz1D+AnKjugGeK6JaVExqybUk cSsdrpQsrNWpdG1iGGCltAJ5ZnhZKrKb0CNPv+4r2suTy+mSRhOcRi/RK4SMR++KdR FO8pQAEGor1lVJorzA00qlrJwehxOXAQZiIb0dNzstoMxS/0wRLpzYd4MwvAqZ1SQY +HR5qDsEBw9/k1atUUZwnGqjRyET5xfAfkHQg799YyQUybMgCLVqgUIb5EEmdYkMVu aBdCEWsDlCDPw== Message-ID: <33d41fbd-a2ed-d2ef-4395-e18aac7c0d28@kernel.org> Date: Thu, 11 Aug 2022 11:40:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH v6] mm/page_owner.c: add llseek for page_owner Content-Language: en-US To: Kassey Li , kernel test robot , akpm@linux-foundation.org Cc: kbuild-all@lists.01.org, minchan@kernel.org, vbabka@suse.cz, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20220810013218.27416-1-quic_yingangl@quicinc.com> <202208101628.o6qUzx50-lkp@intel.com> <54f974fb-f334-78cf-d5f5-198810cc77b4@quicinc.com> From: "Vlastimil Babka (SUSE)" In-Reply-To: <54f974fb-f334-78cf-d5f5-198810cc77b4@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/11/22 05:02, Kassey Li wrote: > hi, Vlastimil: > > > On 8/10/2022 5:02 PM, kernel test robot wrote: >> Hi Kassey, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on v5.19] >> [also build test ERROR on next-20220810] >> [cannot apply to akpm-mm/mm-everything linus/master] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url:    >> https://github.com/intel-lab-lkp/linux/commits/Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220810-093417 >> base:    3d7cb6b04c3f3115719235cc6866b10326de34cd >> config: parisc-buildonly-randconfig-r004-20220810 >> (https://download.01.org/0day-ci/archive/20220810/202208101628.o6qUzx50-lkp@intel.com/config) >> compiler: hppa-linux-gcc (GCC) 12.1.0 >> reproduce (this is a W=1 build): >>          wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> -O ~/bin/make.cross >>          chmod +x ~/bin/make.cross >>          # >> https://github.com/intel-lab-lkp/linux/commit/d2decd69a8d5756c1706092c805a4c8af14df471 >>          git remote add linux-review https://github.com/intel-lab-lkp/linux >>          git fetch --no-tags linux-review >> Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220810-093417 >>          git checkout d2decd69a8d5756c1706092c805a4c8af14df471 >>          # save the config file >>          mkdir build_dir && cp config build_dir/.config >>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross >> W=1 O=build_dir ARCH=parisc SHELL=/bin/bash >> >> If you fix the issue, kindly add following tag where applicable >> Reported-by: kernel test robot >> >> All errors (new ones prefixed by >>): >> >>     In file included from mm/page_owner.c:16: >>>> mm/../fs/proc/internal.h:51:9: error: unknown type name 'proc_write_t' >>        51 |         proc_write_t write; >>           |         ^~~~~~~~~~~~ > > # CONFIG_PROC_FS is not set in some arch, so we can not directly include the > header file. > +#include "../fs/proc/internal.h" > > how about add an extern  ? or do you have other suggest  ? Hi, I replied to v5 after the bot reports: Sorry, my suggestion (to reuse mem_lseek() from proc) was wrong as the kernel test bot just showed us. mem_lseek() may be unavailable without CONFIG_PROC_FS. The easiest way is to add a page_owner specific lseek function back as in the early version, but make it correct for SEEK_CUR. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5111402625634369283==" MIME-Version: 1.0 From: Vlastimil Babka (SUSE) To: kbuild-all@lists.01.org Subject: Re: [PATCH v6] mm/page_owner.c: add llseek for page_owner Date: Thu, 11 Aug 2022 11:40:33 +0200 Message-ID: <33d41fbd-a2ed-d2ef-4395-e18aac7c0d28@kernel.org> In-Reply-To: <54f974fb-f334-78cf-d5f5-198810cc77b4@quicinc.com> List-Id: --===============5111402625634369283== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 8/11/22 05:02, Kassey Li wrote: > hi, Vlastimil: > = > = > On 8/10/2022 5:02 PM, kernel test robot wrote: >> Hi Kassey, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on v5.19] >> [also build test ERROR on next-20220810] >> [cannot apply to akpm-mm/mm-everything linus/master] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url:=C2=A0=C2=A0=C2=A0 >> https://github.com/intel-lab-lkp/linux/commits/Kassey-Li/mm-page_owner-c= -add-llseek-for-page_owner/20220810-093417 >> base:=C2=A0=C2=A0=C2=A0 3d7cb6b04c3f3115719235cc6866b10326de34cd >> config: parisc-buildonly-randconfig-r004-20220810 >> (https://download.01.org/0day-ci/archive/20220810/202208101628.o6qUzx50-= lkp(a)intel.com/config) >> compiler: hppa-linux-gcc (GCC) 12.1.0 >> reproduce (this is a W=3D1 build): >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> -O ~/bin/make.cross >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 chmod +x ~/bin/make.cro= ss >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >> https://github.com/intel-lab-lkp/linux/commit/d2decd69a8d5756c1706092c80= 5a4c8af14df471 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git remote add linux-re= view https://github.com/intel-lab-lkp/linux >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git fetch --no-tags lin= ux-review >> Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220810-093417 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git checkout d2decd69a8= d5756c1706092c805a4c8af14df471 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # save the config file >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mkdir build_dir && cp c= onfig build_dir/.config >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 COMPILER_INSTALL_PATH= =3D$HOME/0day COMPILER=3Dgcc-12.1.0 make.cross >> W=3D1 O=3Dbuild_dir ARCH=3Dparisc SHELL=3D/bin/bash >> >> If you fix the issue, kindly add following tag where applicable >> Reported-by: kernel test robot >> >> All errors (new ones prefixed by >>): >> >> =C2=A0=C2=A0=C2=A0 In file included from mm/page_owner.c:16: >>>> mm/../fs/proc/internal.h:51:9: error: unknown type name 'proc_write_t' >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 51 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 proc_write_t write; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~~ > = > # CONFIG_PROC_FS is not set in some arch, so we can not directly include = the > header file. > +#include "../fs/proc/internal.h" > = > how about add an extern=C2=A0 ? or do you have other suggest=C2=A0 ? Hi, I replied to v5 after the bot reports: Sorry, my suggestion (to reuse mem_lseek() from proc) was wrong as the kernel test bot just showed us. mem_lseek() may be unavailable without CONFIG_PROC_FS. The easiest way is to add a page_owner specific lseek function back as in the early version, but make it correct for SEEK_CUR. Thanks. --===============5111402625634369283==--