From: Dan Carpenter <dan.carpenter@linaro.org>
To: Lars Kellogg-Stedman <lars@oddbit.com>
Cc: Duoming Zhou <duoming@zju.edu.cn>, linux-hams@vger.kernel.org
Subject: Re: [PATCH RFC] ax25: Fix (more) netdev refcount issues
Date: Sun, 28 Apr 2024 14:01:54 +0300 [thread overview]
Message-ID: <34c0f87f-793e-4815-8f50-9cf632dafe21@moroto.mountain> (raw)
In-Reply-To: <c2xhy6qnfvog4efddy32yrzd2ohjqmfixrqfuujvamsubkjbv6@vpidhqtxfcag>
On Sat, Apr 27, 2024 at 01:15:38PM -0400, Lars Kellogg-Stedman wrote:
> On Sat, Apr 27, 2024 at 11:48:48AM GMT, Dan Carpenter wrote:
> > The commit message needs a Fixes tag.
> >
> > Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
>
> This wasn't meant explicitly as a fix for that commit. Is the Fixes: tag
> still appropriate?
>
We would want to have a Fixes tag to say how the bug was introduced.
That's the commit which introduced the underflow I think.
> > Let me add Duoming Zhou to the CC list. That commit is two years old
> > now. This sort of bug should have been caught by basic testing, right?
>
> You'd think, right? The errors were trivial to reproduce (and can be
> tested by anyone; you don't need a radio to exercise the ax.25 stack).
>
> > Could you confirm that that's actually the commit which breaks it?
>
> I'll see what I can do. There are already several patches on top of
> d01ffb9eee4a (I count 19), so figuring that out might be tricky.
Instead of reverting just the commit directly before that commit.
git checkout 4e0f718daf97d47cf7dec122da1be970f145c809
regards,
dan carpenter
next prev parent reply other threads:[~2024-04-28 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 21:29 [PATCH RFC] ax25: Fix (more) netdev refcount issues Lars Kellogg-Stedman
2024-04-27 8:48 ` Dan Carpenter
2024-04-27 17:15 ` Lars Kellogg-Stedman
2024-04-28 11:01 ` Dan Carpenter [this message]
2024-04-29 18:06 ` Lars Kellogg-Stedman
2024-04-30 10:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c0f87f-793e-4815-8f50-9cf632dafe21@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=duoming@zju.edu.cn \
--cc=lars@oddbit.com \
--cc=linux-hams@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.