From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Cc: "Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH v4] doc: guidelines for library statistics
Date: Thu, 18 Jun 2015 17:12:21 +0200 [thread overview]
Message-ID: <3520895.7kc6tpDi1L@xps13> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC358AF171@smartserver.smartshare.dk>
We need a conclusion here.
It seems the policy proposed by Cristian is the best consensus.
If nobody nack in this thread with a counter-proposal,
it will be adopted on Monday.
2015-06-18 16:38, Morten Brørup:
> The suggested solution with only one single flag per library prevents
> implementing statistics with varying granularity for different purposes.
> E.g. a library could have one set of statistics counters for ordinary
> SNMP purposes, and another set of statistics counters for
> debugging/optimization purposes.
It would be difficult to sort a statistic in a category or another.
By the way, it's often better to add its own stats for debugging/optim.
> Multiple flags per library should be possible. A hierarchy of flags per
> library is probably not required.
> And since the compile time flag
> CONFIG_RTE_<LIBRARY_NAME>[_<STATS_COLLECTION_NAME>]_STATS_COLLECT already
> tells the application if the statistics are present or not, the application
> should simply use this flag to determine if statistics are accessible or not.
Yes
next prev parent reply other threads:[~2015-06-18 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 14:38 [PATCH v4] doc: guidelines for library statistics Morten Brørup
2015-06-18 15:12 ` Thomas Monjalon [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-16 13:35 Cristian Dumitrescu
2015-06-16 13:40 ` Mcnamara, John
2015-06-23 13:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3520895.7kc6tpDi1L@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.