From: Martin Costabel <costabel@wanadoo.fr>
To: Paul.Mackerras@cs.anu.edu.au
Cc: linuxppc-dev@lists.linuxppc.org, cort@ppc.kernel.org
Subject: Re: Bug in vger 2.2.10 and 2.3.4 (Re: Problems with vger 2.3.3/4)
Date: Thu, 03 Jun 1999 08:26:59 +0200 [thread overview]
Message-ID: <37562033.2355E4DA@wanadoo.fr> (raw)
In-Reply-To: 199906030250.MAA04127@tango.anu.edu.au
Paul Mackerras wrote:
>
> Martin Costabel <costabel@wanadoo.fr> wrote:
>
> > A while ago I reported about boot problems with the vger 2.3.x kernel
> > after May 22. Now I found that this same bug has crept into the "stable"
> > tree, starting with 2.2.10 on May 30. After some digging, I found the
> > culprit. It is the file arch/ppc/mm/init.c, patched (wrongly) as
> > follows:
> [snip]
> > - return (void *) (v + (p & ~PAGE_MASK));
> > + return (void *) (v + (addr & ~PAGE_MASK));
>
> In fact that patch is correct but you also need this patch (which I'm
> about to check into vger):
>
> --- linux/arch/ppc/mm/init.c Sat May 29 20:24:09 1999
> +++ pmac/arch/ppc/mm/init.c Thu Jun 3 10:13:00 1999
> @@ -371,7 +371,7 @@
> * same virt address (and this is contiguous).
> * -- Cort
> */
> - if ( (v = p_mapped_by_bats(addr)) /*&& p_mapped_by_bats(addr+(size-1))*/ )
> + if ( (v = p_mapped_by_bats(p)) /*&& p_mapped_by_bats(p+size-1)*/ )
> goto out;
> #endif /* CONFIG_8xx */
In the meantime I applied the second patch proposed by Ryuichi Oikawa, and it
works for me. I am writing this running under 2.3.4. This patch is
diff -u -r1.166 init.c
--- arch/ppc/mm/init.c 1999/05/22 18:18:30 1.166
+++ arch/ppc/mm/init.c 1999/06/02 22:51:47
@@ -371,8 +371,10 @@
* same virt address (and this is contiguous).
* -- Cort
*/
- if ( (v = p_mapped_by_bats(addr)) /*&& p_mapped_by_bats(addr+(size-1))*/ )
+ if ( (v = p_mapped_by_bats(addr)) /*&& p_mapped_by_bats(addr+(size-1))*/ ){
+ addr = 0; /* v already contains page offset */
goto out;
+ }
#endif /* CONFIG_8xx */
if (mem_init_done) {
Note that I don't understand what is going on here. I am just your
typical dumb user :-)
--
Martin
[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to Cc linuxppc-dev if your ]]
[[ reply is of general interest. Please check http://lists.linuxppc.org/ ]]
[[ and http://www.linuxppc.org/ for useful information before posting. ]]
next prev parent reply other threads:[~1999-06-03 6:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-05-27 18:25 Problems with vger 2.3.3/4 Martin Costabel
1999-06-02 12:19 ` Bug in vger 2.2.10 and 2.3.4 (Re: Problems with vger 2.3.3/4) Martin Costabel
1999-06-03 1:24 ` Ryuichi Oikawa
1999-06-03 2:50 ` Paul Mackerras
1999-06-03 6:26 ` Martin Costabel [this message]
1999-06-03 22:24 ` Martin Costabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37562033.2355E4DA@wanadoo.fr \
--to=costabel@wanadoo.fr \
--cc=Paul.Mackerras@cs.anu.edu.au \
--cc=cort@ppc.kernel.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.