From: Lou Langholtz <ldl@chpc.utah.edu>
To: Benjamin Herrenschmidt <bh40@calva.net>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: [Fwd: Bug: 2.2.12 still hangs PPC after some PPP activity]
Date: Wed, 29 Sep 1999 12:08:23 -0600 [thread overview]
Message-ID: <37F25597.63CED114@chpc.utah.edu> (raw)
In-Reply-To: 19990929190222.023648@mailhost.mipsys.com
Benjamin Herrenschmidt wrote:
> On Wed, Sep 29, 1999, Lou Langholtz <ldl@chpc.utah.edu> wrote:
>
> >This is pretty much the kernel I'm running now. I haven't had the "FB.
> >overflow" message yet nor system-freeze but I've experienced the TCP slowdown
> already.
> >Evidence that we've got other problems as well (IMO). It's only been 20 hours
> >or so with new kernel so not enough time for me to feel confident though about
>
> >these results.
>
> I've added another fix to the kernel on my test page
> (http://calvaweb.calvacom.fr/bh40/test.html). It may fix the hang on
> close. I don't think it will fix anything related to a slowdown however.
It's interesting to note that you chose to move save_flags(flags) in
rs_write() to just before the cli()'s. What was your reasoning? I'm asking so
I can get a better understanding of all the implications of this. Most code that
I've perused so far now does what you've basically done --- keeps the
save_flags() right before the cli()'s. When I chose to just to remove that last
restore_flags() I was basing my descision not to move the originall
save_flags() on the rs_write() code in drivers/char/serial.c. In the serial.c
file they call save_flags() outside of the while loop like the original
rs_write() in macserial.c. This would save time by not being constantly
re-invoked within the loop of course but then this only works if the flags saved
stay valid. That's the part I'm having the most trouble with --- what kind of
calls could invalidate the flags that have been saved.
As to the hang-on-close problem, I've never experienced that before nor heard of
it. Is it something that you've seen or heard of? Your change makes sense anyway.
I'm just being curious in case this might be effecting me in ways I didn't even
realize.
Cheers! :-)
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~1999-09-29 18:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <37F1AD4B.585E99AB@chpc.utah.edu>
1999-09-29 7:11 ` [Fwd: Bug: 2.2.12 still hangs PPC after some PPP activity] Geert Uytterhoeven
1999-09-29 7:16 ` Takashi Oe
1999-09-29 7:40 ` Geert Uytterhoeven
1999-09-29 9:13 ` Benjamin Herrenschmidt
1999-09-30 0:46 ` Takashi Oe
1999-09-30 8:50 ` Benjamin Herrenschmidt
1999-09-30 16:21 ` Takashi Oe
1999-09-30 16:35 ` Benjamin Herrenschmidt
1999-10-06 5:33 ` update on macserial/DMA Takashi Oe
1999-10-06 8:35 ` Benjamin Herrenschmidt
1999-10-06 13:47 ` Takashi Oe
1999-10-06 16:25 ` Benjamin Herrenschmidt
1999-10-06 16:50 ` Benjamin Herrenschmidt
1999-10-08 7:13 ` Lou Langholtz
1999-10-09 17:57 ` Lou Langholtz
[not found] ` <Pine.LNX.3.96LJ1.1b7.991005234830.1210A-100000@ofey.inetne br.com>
1999-10-07 9:48 ` Franz Sirl
1999-10-07 15:37 ` phandel
1999-10-12 7:20 ` [Fwd: Bug: 2.2.12 still hangs PPC after some PPP activity] Lou Langholtz
1999-09-29 16:44 ` Lou Langholtz
1999-09-29 17:02 ` Benjamin Herrenschmidt
1999-09-29 18:08 ` Lou Langholtz [this message]
1999-09-29 18:46 ` Lou Langholtz
1999-09-29 20:00 ` Lou Langholtz
1999-09-30 1:14 ` Takashi Oe
1999-09-30 5:33 ` Geert Uytterhoeven
1999-10-01 13:26 ` Franz Sirl
1999-10-01 13:46 ` Alvin Brattli
[not found] ` <Pine.OSF.3.96.991001153658.16772E-100000@mitra.phys.uit.no >
1999-10-01 14:08 ` Franz Sirl
1999-10-01 16:14 ` Lou Langholtz
[not found] <37F1C0A3.B9F25580@chpc.utah.edu>
1999-09-29 7:39 ` Geert Uytterhoeven
1999-09-10 16:51 Lou Langholtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37F25597.63CED114@chpc.utah.edu \
--to=ldl@chpc.utah.edu \
--cc=bh40@calva.net \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.