From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38483376EC; Sat, 27 Apr 2024 07:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714203652; cv=none; b=UY1otfYt7LzaThluwcz4PqDrjfBzo61C7gJOuXywvhysJTpledZs9sAClSmpGbrhWsVaDYCRzEAtXTdjuME8dCcDRfEm/qFUQdGYxefw2bjVfD7emapmOtWMAuF3jXo1Vh2z/rLwUjLjEWcjSxcwFcRw3oXQR2lrYtRkq1/TDEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714203652; c=relaxed/simple; bh=CzgUKxV1DiRGrX9zQXzZL6Gotui8EXJUqYQ3eQT9fT4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EldON3TuhubwZAoNWjdObGunaICbj7oTMsx5nhciB0CMEiZ76f/cBRB9AJTeoRbsLyAv6WPgwpS4WlNdUhZ8IP6in0Aflo7GIy7d0cFxduAzBPcQ9JYnLlP5wI90lnkBr/+olVU+D5IPfDqqastftUc2DBKBdaTuhXzRdhnLui4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=gEqEbcAY; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="gEqEbcAY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1714203646; bh=CzgUKxV1DiRGrX9zQXzZL6Gotui8EXJUqYQ3eQT9fT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gEqEbcAYbNH1Cl76LGX0IqteTFz6QZM2G7WkdPY5ve6JFJe7QvQdYePk2UkJVcvTR 6u5FIHxh7+/FsU6vrbi0R0NpqVH+T4CvlFrv7BQ8Kzndu1PmGsnulYTnxUn5nJrEUi e3WiuV0em4CHQ+eAmWIJfWacyiMhggB7HEWeZqN8= Date: Sat, 27 Apr 2024 09:40:43 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Jakub Kicinski , Luis Chamberlain , Joel Granados Cc: Kees Cook , Eric Dumazet , Dave Chinner , linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-hardening@vger.kernel.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Message-ID: <38a87a0f-02c7-4072-9342-8f6697ea1a17@t-8ch.de> References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> <20240424201234.3cc2b509@kernel.org> <9e657181-866a-4626-82d0-e0030051b003@t-8ch.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9e657181-866a-4626-82d0-e0030051b003@t-8ch.de> On 2024-04-25 09:10:27+0000, Thomas Weißschuh wrote: > On 2024-04-24 20:12:34+0000, Jakub Kicinski wrote: > > On Tue, 23 Apr 2024 09:54:35 +0200 Thomas Weißschuh wrote: > > > The series was split from my larger series sysctl-const series [0]. > > > It only focusses on the proc_handlers but is an important step to be > > > able to move all static definitions of ctl_table into .rodata. > > > > Split this per subsystem, please. > > Unfortunately this would introduce an enormous amount of code churn. > > The function prototypes for each callback have to stay consistent. > So a another callback member ("proc_handler_new") is needed and users > would be migrated to it gradually. > > But then *all* definitions of "struct ctl_table" throughout the tree need to > be touched. > In contrast, the proposed series only needs to change the handler > implementations, not their usage sites. > > There are many, many more usage sites than handler implementations. > > Especially, as the majority of sysctl tables use the standard handlers > (proc_dostring, proc_dobool, ...) and are not affected by the proposed > aproach at all. > > And then we would have introduced a new handler name "proc_handler_new" > and maybe have to do the whole thing again to rename it back to > the original and well-known "proc_handler". This aproach could be optimized by only migrating the usages of the custom handler implementations to "proc_handler_new". After this we could move over the core handlers and "proc_handler" in one small patch that does not need to touch the usages sites. Afterwards all non-core usages would be migrated back from "proc_handler_new" to "proc_handler" and the _new variant could be dropped again. It would still be more than twice the churn of my current patch. And these patches would be more complex than the current "just add a bunch of consts, nothing else". Personally I still prefer the original aproach. Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF1C7C4345F for ; Sat, 27 Apr 2024 07:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OwKrlff0yckudzMFAYEOpOfez5xnI5pk3las/IfxFy8=; b=V6Qp1eJjP/d6Ro yXvoHuufcf7+RZyY2Y82oycg6PMZgm7fGrciQEpese87VFWTUPmYlESogp8jXdcQMQoJ32iAhaTg3 cR/fb6GXhWtQLaFOX0BwoJdfBxtV08AD4SsGtyD8UqncH/4rgjorOLdF6iLCM8eNd80P3LufCpnnN aAiXz/KBSbxZ+rB7nYi41BVEVTlOF/Ixl4Yc1toTvJDQInKzza+FAvSzbRM0bYws27tyxp0+y3BXM Et4Wdne2TZk3nbuWoqA0psuRvMtyUGbkCMUlLChF59g//f9JPFA2ax7IsYPcdGrBCQwLJvpTvAnfH swPCI39WVSB3xeeO0kYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0cg7-0000000F4qD-0SjZ; Sat, 27 Apr 2024 07:40:59 +0000 Received: from todd.t-8ch.de ([159.69.126.157]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0cg1-0000000F4oB-3mEB; Sat, 27 Apr 2024 07:40:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1714203646; bh=CzgUKxV1DiRGrX9zQXzZL6Gotui8EXJUqYQ3eQT9fT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gEqEbcAYbNH1Cl76LGX0IqteTFz6QZM2G7WkdPY5ve6JFJe7QvQdYePk2UkJVcvTR 6u5FIHxh7+/FsU6vrbi0R0NpqVH+T4CvlFrv7BQ8Kzndu1PmGsnulYTnxUn5nJrEUi e3WiuV0em4CHQ+eAmWIJfWacyiMhggB7HEWeZqN8= Date: Sat, 27 Apr 2024 09:40:43 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Jakub Kicinski , Luis Chamberlain , Joel Granados Cc: Kees Cook , Eric Dumazet , Dave Chinner , linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-hardening@vger.kernel.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Message-ID: <38a87a0f-02c7-4072-9342-8f6697ea1a17@t-8ch.de> References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> <20240424201234.3cc2b509@kernel.org> <9e657181-866a-4626-82d0-e0030051b003@t-8ch.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9e657181-866a-4626-82d0-e0030051b003@t-8ch.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240427_004054_221187_4F26E3F9 X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wNC0yNSAwOToxMDoyNyswMDAwLCBUaG9tYXMgV2Vpw59zY2h1aCB3cm90ZToKPiBP biAyMDI0LTA0LTI0IDIwOjEyOjM0KzAwMDAsIEpha3ViIEtpY2luc2tpIHdyb3RlOgo+ID4gT24g VHVlLCAyMyBBcHIgMjAyNCAwOTo1NDozNSArMDIwMCBUaG9tYXMgV2Vpw59zY2h1aCB3cm90ZToK PiA+ID4gVGhlIHNlcmllcyB3YXMgc3BsaXQgZnJvbSBteSBsYXJnZXIgc2VyaWVzIHN5c2N0bC1j b25zdCBzZXJpZXMgWzBdLgo+ID4gPiBJdCBvbmx5IGZvY3Vzc2VzIG9uIHRoZSBwcm9jX2hhbmRs ZXJzIGJ1dCBpcyBhbiBpbXBvcnRhbnQgc3RlcCB0byBiZQo+ID4gPiBhYmxlIHRvIG1vdmUgYWxs IHN0YXRpYyBkZWZpbml0aW9ucyBvZiBjdGxfdGFibGUgaW50byAucm9kYXRhLgo+ID4gCj4gPiBT cGxpdCB0aGlzIHBlciBzdWJzeXN0ZW0sIHBsZWFzZS4KPiAKPiBVbmZvcnR1bmF0ZWx5IHRoaXMg d291bGQgaW50cm9kdWNlIGFuIGVub3Jtb3VzIGFtb3VudCBvZiBjb2RlIGNodXJuLgo+IAo+IFRo ZSBmdW5jdGlvbiBwcm90b3R5cGVzIGZvciBlYWNoIGNhbGxiYWNrIGhhdmUgdG8gc3RheSBjb25z aXN0ZW50Lgo+IFNvIGEgYW5vdGhlciBjYWxsYmFjayBtZW1iZXIgKCJwcm9jX2hhbmRsZXJfbmV3 IikgaXMgbmVlZGVkIGFuZCB1c2Vycwo+IHdvdWxkIGJlIG1pZ3JhdGVkIHRvIGl0IGdyYWR1YWxs eS4KPiAKPiBCdXQgdGhlbiAqYWxsKiBkZWZpbml0aW9ucyBvZiAic3RydWN0IGN0bF90YWJsZSIg dGhyb3VnaG91dCB0aGUgdHJlZSBuZWVkIHRvCj4gYmUgdG91Y2hlZC4KPiBJbiBjb250cmFzdCwg dGhlIHByb3Bvc2VkIHNlcmllcyBvbmx5IG5lZWRzIHRvIGNoYW5nZSB0aGUgaGFuZGxlcgo+IGlt cGxlbWVudGF0aW9ucywgbm90IHRoZWlyIHVzYWdlIHNpdGVzLgo+IAo+IFRoZXJlIGFyZSBtYW55 LCBtYW55IG1vcmUgdXNhZ2Ugc2l0ZXMgdGhhbiBoYW5kbGVyIGltcGxlbWVudGF0aW9ucy4KPiAK PiBFc3BlY2lhbGx5LCBhcyB0aGUgbWFqb3JpdHkgb2Ygc3lzY3RsIHRhYmxlcyB1c2UgdGhlIHN0 YW5kYXJkIGhhbmRsZXJzCj4gKHByb2NfZG9zdHJpbmcsIHByb2NfZG9ib29sLCAuLi4pIGFuZCBh cmUgbm90IGFmZmVjdGVkIGJ5IHRoZSBwcm9wb3NlZAo+IGFwcm9hY2ggYXQgYWxsLgo+IAo+IEFu ZCB0aGVuIHdlIHdvdWxkIGhhdmUgaW50cm9kdWNlZCBhIG5ldyBoYW5kbGVyIG5hbWUgInByb2Nf aGFuZGxlcl9uZXciCj4gYW5kIG1heWJlIGhhdmUgdG8gZG8gdGhlIHdob2xlIHRoaW5nIGFnYWlu IHRvIHJlbmFtZSBpdCBiYWNrIHRvCj4gdGhlIG9yaWdpbmFsIGFuZCB3ZWxsLWtub3duICJwcm9j X2hhbmRsZXIiLgoKVGhpcyBhcHJvYWNoIGNvdWxkIGJlIG9wdGltaXplZCBieSBvbmx5IG1pZ3Jh dGluZyB0aGUgdXNhZ2VzIG9mIHRoZQpjdXN0b20gaGFuZGxlciBpbXBsZW1lbnRhdGlvbnMgdG8g InByb2NfaGFuZGxlcl9uZXciLgpBZnRlciB0aGlzIHdlIGNvdWxkIG1vdmUgb3ZlciB0aGUgY29y ZSBoYW5kbGVycyBhbmQgInByb2NfaGFuZGxlciIgaW4Kb25lIHNtYWxsIHBhdGNoIHRoYXQgZG9l cyBub3QgbmVlZCB0byB0b3VjaCB0aGUgdXNhZ2VzIHNpdGVzLgoKQWZ0ZXJ3YXJkcyBhbGwgbm9u LWNvcmUgdXNhZ2VzIHdvdWxkIGJlIG1pZ3JhdGVkIGJhY2sgZnJvbQoicHJvY19oYW5kbGVyX25l dyIgdG8gInByb2NfaGFuZGxlciIgYW5kIHRoZSBfbmV3IHZhcmlhbnQgY291bGQgYmUKZHJvcHBl ZCBhZ2Fpbi4KCkl0IHdvdWxkIHN0aWxsIGJlIG1vcmUgdGhhbiB0d2ljZSB0aGUgY2h1cm4gb2Yg bXkgY3VycmVudCBwYXRjaC4KQW5kIHRoZXNlIHBhdGNoZXMgd291bGQgYmUgbW9yZSBjb21wbGV4 IHRoYW4gdGhlIGN1cnJlbnQKImp1c3QgYWRkIGEgYnVuY2ggb2YgY29uc3RzLCBub3RoaW5nIGVs c2UiLgoKUGVyc29uYWxseSBJIHN0aWxsIHByZWZlciB0aGUgb3JpZ2luYWwgYXByb2FjaC4KCgpU aG9tYXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 279D0C4345F for ; Sat, 27 Apr 2024 07:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dZdHFFVdj3pGc9hCGxbSqAnUFPpYz5lrC7ClsZXF0ts=; b=0Cfy4lAIl1NzHf 1A+m7JFF+eceOV4cyXnbwKo27zFiOKTV4p2FdcyxjFW+2SXi20Bz3wBMV5QhCmiO9hN105vy6+rSq WlZF4cpYroGvUH+hWqbKt2GoRXL184NHo7R44v0rbZO71frr38XqmYOo4TeddcrZJJW2nYnKs/6Bb DU3M6/STTzMNBwhhW592eCswigUI8pOSxgauXjoklIH6tWjD+DWamkQ5ZGN0mrZOnuV7/OsIki6wI utEpqg8c/g2IZz5osxPNaiNnfUuex+zHZj9q03TPK58TT+ArlhmeLIzRkqJkKX1HYzIdjoeIR6Apl jgd3oXFKoJ8dB3VbuThw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0cg5-0000000F4pd-3bMy; Sat, 27 Apr 2024 07:40:57 +0000 Received: from todd.t-8ch.de ([159.69.126.157]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0cg1-0000000F4oB-3mEB; Sat, 27 Apr 2024 07:40:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1714203646; bh=CzgUKxV1DiRGrX9zQXzZL6Gotui8EXJUqYQ3eQT9fT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gEqEbcAYbNH1Cl76LGX0IqteTFz6QZM2G7WkdPY5ve6JFJe7QvQdYePk2UkJVcvTR 6u5FIHxh7+/FsU6vrbi0R0NpqVH+T4CvlFrv7BQ8Kzndu1PmGsnulYTnxUn5nJrEUi e3WiuV0em4CHQ+eAmWIJfWacyiMhggB7HEWeZqN8= Date: Sat, 27 Apr 2024 09:40:43 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Jakub Kicinski , Luis Chamberlain , Joel Granados Cc: Kees Cook , Eric Dumazet , Dave Chinner , linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-hardening@vger.kernel.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Message-ID: <38a87a0f-02c7-4072-9342-8f6697ea1a17@t-8ch.de> References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> <20240424201234.3cc2b509@kernel.org> <9e657181-866a-4626-82d0-e0030051b003@t-8ch.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9e657181-866a-4626-82d0-e0030051b003@t-8ch.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240427_004054_221187_4F26E3F9 X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wNC0yNSAwOToxMDoyNyswMDAwLCBUaG9tYXMgV2Vpw59zY2h1aCB3cm90ZToKPiBP biAyMDI0LTA0LTI0IDIwOjEyOjM0KzAwMDAsIEpha3ViIEtpY2luc2tpIHdyb3RlOgo+ID4gT24g VHVlLCAyMyBBcHIgMjAyNCAwOTo1NDozNSArMDIwMCBUaG9tYXMgV2Vpw59zY2h1aCB3cm90ZToK PiA+ID4gVGhlIHNlcmllcyB3YXMgc3BsaXQgZnJvbSBteSBsYXJnZXIgc2VyaWVzIHN5c2N0bC1j b25zdCBzZXJpZXMgWzBdLgo+ID4gPiBJdCBvbmx5IGZvY3Vzc2VzIG9uIHRoZSBwcm9jX2hhbmRs ZXJzIGJ1dCBpcyBhbiBpbXBvcnRhbnQgc3RlcCB0byBiZQo+ID4gPiBhYmxlIHRvIG1vdmUgYWxs IHN0YXRpYyBkZWZpbml0aW9ucyBvZiBjdGxfdGFibGUgaW50byAucm9kYXRhLgo+ID4gCj4gPiBT cGxpdCB0aGlzIHBlciBzdWJzeXN0ZW0sIHBsZWFzZS4KPiAKPiBVbmZvcnR1bmF0ZWx5IHRoaXMg d291bGQgaW50cm9kdWNlIGFuIGVub3Jtb3VzIGFtb3VudCBvZiBjb2RlIGNodXJuLgo+IAo+IFRo ZSBmdW5jdGlvbiBwcm90b3R5cGVzIGZvciBlYWNoIGNhbGxiYWNrIGhhdmUgdG8gc3RheSBjb25z aXN0ZW50Lgo+IFNvIGEgYW5vdGhlciBjYWxsYmFjayBtZW1iZXIgKCJwcm9jX2hhbmRsZXJfbmV3 IikgaXMgbmVlZGVkIGFuZCB1c2Vycwo+IHdvdWxkIGJlIG1pZ3JhdGVkIHRvIGl0IGdyYWR1YWxs eS4KPiAKPiBCdXQgdGhlbiAqYWxsKiBkZWZpbml0aW9ucyBvZiAic3RydWN0IGN0bF90YWJsZSIg dGhyb3VnaG91dCB0aGUgdHJlZSBuZWVkIHRvCj4gYmUgdG91Y2hlZC4KPiBJbiBjb250cmFzdCwg dGhlIHByb3Bvc2VkIHNlcmllcyBvbmx5IG5lZWRzIHRvIGNoYW5nZSB0aGUgaGFuZGxlcgo+IGlt cGxlbWVudGF0aW9ucywgbm90IHRoZWlyIHVzYWdlIHNpdGVzLgo+IAo+IFRoZXJlIGFyZSBtYW55 LCBtYW55IG1vcmUgdXNhZ2Ugc2l0ZXMgdGhhbiBoYW5kbGVyIGltcGxlbWVudGF0aW9ucy4KPiAK PiBFc3BlY2lhbGx5LCBhcyB0aGUgbWFqb3JpdHkgb2Ygc3lzY3RsIHRhYmxlcyB1c2UgdGhlIHN0 YW5kYXJkIGhhbmRsZXJzCj4gKHByb2NfZG9zdHJpbmcsIHByb2NfZG9ib29sLCAuLi4pIGFuZCBh cmUgbm90IGFmZmVjdGVkIGJ5IHRoZSBwcm9wb3NlZAo+IGFwcm9hY2ggYXQgYWxsLgo+IAo+IEFu ZCB0aGVuIHdlIHdvdWxkIGhhdmUgaW50cm9kdWNlZCBhIG5ldyBoYW5kbGVyIG5hbWUgInByb2Nf aGFuZGxlcl9uZXciCj4gYW5kIG1heWJlIGhhdmUgdG8gZG8gdGhlIHdob2xlIHRoaW5nIGFnYWlu IHRvIHJlbmFtZSBpdCBiYWNrIHRvCj4gdGhlIG9yaWdpbmFsIGFuZCB3ZWxsLWtub3duICJwcm9j X2hhbmRsZXIiLgoKVGhpcyBhcHJvYWNoIGNvdWxkIGJlIG9wdGltaXplZCBieSBvbmx5IG1pZ3Jh dGluZyB0aGUgdXNhZ2VzIG9mIHRoZQpjdXN0b20gaGFuZGxlciBpbXBsZW1lbnRhdGlvbnMgdG8g InByb2NfaGFuZGxlcl9uZXciLgpBZnRlciB0aGlzIHdlIGNvdWxkIG1vdmUgb3ZlciB0aGUgY29y ZSBoYW5kbGVycyBhbmQgInByb2NfaGFuZGxlciIgaW4Kb25lIHNtYWxsIHBhdGNoIHRoYXQgZG9l cyBub3QgbmVlZCB0byB0b3VjaCB0aGUgdXNhZ2VzIHNpdGVzLgoKQWZ0ZXJ3YXJkcyBhbGwgbm9u LWNvcmUgdXNhZ2VzIHdvdWxkIGJlIG1pZ3JhdGVkIGJhY2sgZnJvbQoicHJvY19oYW5kbGVyX25l dyIgdG8gInByb2NfaGFuZGxlciIgYW5kIHRoZSBfbmV3IHZhcmlhbnQgY291bGQgYmUKZHJvcHBl ZCBhZ2Fpbi4KCkl0IHdvdWxkIHN0aWxsIGJlIG1vcmUgdGhhbiB0d2ljZSB0aGUgY2h1cm4gb2Yg bXkgY3VycmVudCBwYXRjaC4KQW5kIHRoZXNlIHBhdGNoZXMgd291bGQgYmUgbW9yZSBjb21wbGV4 IHRoYW4gdGhlIGN1cnJlbnQKImp1c3QgYWRkIGEgYnVuY2ggb2YgY29uc3RzLCBub3RoaW5nIGVs c2UiLgoKUGVyc29uYWxseSBJIHN0aWxsIHByZWZlciB0aGUgb3JpZ2luYWwgYXByb2FjaC4KCgpU aG9tYXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtl eGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33DEDC4345F for ; Sat, 27 Apr 2024 07:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kWR9lDTbOijOLT6YImA1x+GFWzDChEVBd/YNYR2VKWI=; b=Qk6fcscV39dwtL gsm52TOQ6yQz6eEa0NzXMHk8RCPgyY8ph0x9/PXR42Ysq8AbwlRvxYEyF91JMQZA35cLAPyCZrEst +dFlTFzqQ86w74vNeNjL7IDr4YpkR4lZdw23AnIM+A50DZTWA6w682RZnlFRSxxW6Cda84FwHOx11 TId8uxOY8sa4tPEYf3c98jnEYkVRTmF+lXdsz6idXl62oLx3sDQNnr/JUp7CZiyjV0vzlPv06NvIn nl3SeysoekbJAZmoDz2bvqXVNTmesvInezZUmkQ0c11xG0qpF/H7lDrWN6Y4FobbawpcMqITPW3zX lZOL29xf1LghWrralwvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0cg6-0000000F4pm-1dLB; Sat, 27 Apr 2024 07:40:58 +0000 Received: from todd.t-8ch.de ([159.69.126.157]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0cg1-0000000F4oB-3mEB; Sat, 27 Apr 2024 07:40:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1714203646; bh=CzgUKxV1DiRGrX9zQXzZL6Gotui8EXJUqYQ3eQT9fT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gEqEbcAYbNH1Cl76LGX0IqteTFz6QZM2G7WkdPY5ve6JFJe7QvQdYePk2UkJVcvTR 6u5FIHxh7+/FsU6vrbi0R0NpqVH+T4CvlFrv7BQ8Kzndu1PmGsnulYTnxUn5nJrEUi e3WiuV0em4CHQ+eAmWIJfWacyiMhggB7HEWeZqN8= Date: Sat, 27 Apr 2024 09:40:43 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Jakub Kicinski , Luis Chamberlain , Joel Granados Cc: Kees Cook , Eric Dumazet , Dave Chinner , linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-hardening@vger.kernel.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Message-ID: <38a87a0f-02c7-4072-9342-8f6697ea1a17@t-8ch.de> References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> <20240424201234.3cc2b509@kernel.org> <9e657181-866a-4626-82d0-e0030051b003@t-8ch.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9e657181-866a-4626-82d0-e0030051b003@t-8ch.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240427_004054_221187_4F26E3F9 X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wNC0yNSAwOToxMDoyNyswMDAwLCBUaG9tYXMgV2Vpw59zY2h1aCB3cm90ZToKPiBP biAyMDI0LTA0LTI0IDIwOjEyOjM0KzAwMDAsIEpha3ViIEtpY2luc2tpIHdyb3RlOgo+ID4gT24g VHVlLCAyMyBBcHIgMjAyNCAwOTo1NDozNSArMDIwMCBUaG9tYXMgV2Vpw59zY2h1aCB3cm90ZToK PiA+ID4gVGhlIHNlcmllcyB3YXMgc3BsaXQgZnJvbSBteSBsYXJnZXIgc2VyaWVzIHN5c2N0bC1j b25zdCBzZXJpZXMgWzBdLgo+ID4gPiBJdCBvbmx5IGZvY3Vzc2VzIG9uIHRoZSBwcm9jX2hhbmRs ZXJzIGJ1dCBpcyBhbiBpbXBvcnRhbnQgc3RlcCB0byBiZQo+ID4gPiBhYmxlIHRvIG1vdmUgYWxs IHN0YXRpYyBkZWZpbml0aW9ucyBvZiBjdGxfdGFibGUgaW50byAucm9kYXRhLgo+ID4gCj4gPiBT cGxpdCB0aGlzIHBlciBzdWJzeXN0ZW0sIHBsZWFzZS4KPiAKPiBVbmZvcnR1bmF0ZWx5IHRoaXMg d291bGQgaW50cm9kdWNlIGFuIGVub3Jtb3VzIGFtb3VudCBvZiBjb2RlIGNodXJuLgo+IAo+IFRo ZSBmdW5jdGlvbiBwcm90b3R5cGVzIGZvciBlYWNoIGNhbGxiYWNrIGhhdmUgdG8gc3RheSBjb25z aXN0ZW50Lgo+IFNvIGEgYW5vdGhlciBjYWxsYmFjayBtZW1iZXIgKCJwcm9jX2hhbmRsZXJfbmV3 IikgaXMgbmVlZGVkIGFuZCB1c2Vycwo+IHdvdWxkIGJlIG1pZ3JhdGVkIHRvIGl0IGdyYWR1YWxs eS4KPiAKPiBCdXQgdGhlbiAqYWxsKiBkZWZpbml0aW9ucyBvZiAic3RydWN0IGN0bF90YWJsZSIg dGhyb3VnaG91dCB0aGUgdHJlZSBuZWVkIHRvCj4gYmUgdG91Y2hlZC4KPiBJbiBjb250cmFzdCwg dGhlIHByb3Bvc2VkIHNlcmllcyBvbmx5IG5lZWRzIHRvIGNoYW5nZSB0aGUgaGFuZGxlcgo+IGlt cGxlbWVudGF0aW9ucywgbm90IHRoZWlyIHVzYWdlIHNpdGVzLgo+IAo+IFRoZXJlIGFyZSBtYW55 LCBtYW55IG1vcmUgdXNhZ2Ugc2l0ZXMgdGhhbiBoYW5kbGVyIGltcGxlbWVudGF0aW9ucy4KPiAK PiBFc3BlY2lhbGx5LCBhcyB0aGUgbWFqb3JpdHkgb2Ygc3lzY3RsIHRhYmxlcyB1c2UgdGhlIHN0 YW5kYXJkIGhhbmRsZXJzCj4gKHByb2NfZG9zdHJpbmcsIHByb2NfZG9ib29sLCAuLi4pIGFuZCBh cmUgbm90IGFmZmVjdGVkIGJ5IHRoZSBwcm9wb3NlZAo+IGFwcm9hY2ggYXQgYWxsLgo+IAo+IEFu ZCB0aGVuIHdlIHdvdWxkIGhhdmUgaW50cm9kdWNlZCBhIG5ldyBoYW5kbGVyIG5hbWUgInByb2Nf aGFuZGxlcl9uZXciCj4gYW5kIG1heWJlIGhhdmUgdG8gZG8gdGhlIHdob2xlIHRoaW5nIGFnYWlu IHRvIHJlbmFtZSBpdCBiYWNrIHRvCj4gdGhlIG9yaWdpbmFsIGFuZCB3ZWxsLWtub3duICJwcm9j X2hhbmRsZXIiLgoKVGhpcyBhcHJvYWNoIGNvdWxkIGJlIG9wdGltaXplZCBieSBvbmx5IG1pZ3Jh dGluZyB0aGUgdXNhZ2VzIG9mIHRoZQpjdXN0b20gaGFuZGxlciBpbXBsZW1lbnRhdGlvbnMgdG8g InByb2NfaGFuZGxlcl9uZXciLgpBZnRlciB0aGlzIHdlIGNvdWxkIG1vdmUgb3ZlciB0aGUgY29y ZSBoYW5kbGVycyBhbmQgInByb2NfaGFuZGxlciIgaW4Kb25lIHNtYWxsIHBhdGNoIHRoYXQgZG9l cyBub3QgbmVlZCB0byB0b3VjaCB0aGUgdXNhZ2VzIHNpdGVzLgoKQWZ0ZXJ3YXJkcyBhbGwgbm9u LWNvcmUgdXNhZ2VzIHdvdWxkIGJlIG1pZ3JhdGVkIGJhY2sgZnJvbQoicHJvY19oYW5kbGVyX25l dyIgdG8gInByb2NfaGFuZGxlciIgYW5kIHRoZSBfbmV3IHZhcmlhbnQgY291bGQgYmUKZHJvcHBl ZCBhZ2Fpbi4KCkl0IHdvdWxkIHN0aWxsIGJlIG1vcmUgdGhhbiB0d2ljZSB0aGUgY2h1cm4gb2Yg bXkgY3VycmVudCBwYXRjaC4KQW5kIHRoZXNlIHBhdGNoZXMgd291bGQgYmUgbW9yZSBjb21wbGV4 IHRoYW4gdGhlIGN1cnJlbnQKImp1c3QgYWRkIGEgYnVuY2ggb2YgY29uc3RzLCBub3RoaW5nIGVs c2UiLgoKUGVyc29uYWxseSBJIHN0aWxsIHByZWZlciB0aGUgb3JpZ2luYWwgYXByb2FjaC4KCgpU aG9tYXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F321C4345F for ; Sat, 27 Apr 2024 07:41:48 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=weissschuh.net header.i=@weissschuh.net header.a=rsa-sha256 header.s=mail header.b=gEqEbcAY; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VRM3t5gzKz3cP3 for ; Sat, 27 Apr 2024 17:41:46 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=weissschuh.net header.i=@weissschuh.net header.a=rsa-sha256 header.s=mail header.b=gEqEbcAY; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=weissschuh.net (client-ip=159.69.126.157; helo=todd.t-8ch.de; envelope-from=linux@weissschuh.net; receiver=lists.ozlabs.org) Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VRM2z3zgmz3bjK for ; Sat, 27 Apr 2024 17:40:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1714203646; bh=CzgUKxV1DiRGrX9zQXzZL6Gotui8EXJUqYQ3eQT9fT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gEqEbcAYbNH1Cl76LGX0IqteTFz6QZM2G7WkdPY5ve6JFJe7QvQdYePk2UkJVcvTR 6u5FIHxh7+/FsU6vrbi0R0NpqVH+T4CvlFrv7BQ8Kzndu1PmGsnulYTnxUn5nJrEUi e3WiuV0em4CHQ+eAmWIJfWacyiMhggB7HEWeZqN8= Date: Sat, 27 Apr 2024 09:40:43 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Jakub Kicinski , Luis Chamberlain , Joel Granados Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Message-ID: <38a87a0f-02c7-4072-9342-8f6697ea1a17@t-8ch.de> References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> <20240424201234.3cc2b509@kernel.org> <9e657181-866a-4626-82d0-e0030051b003@t-8ch.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9e657181-866a-4626-82d0-e0030051b003@t-8ch.de> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Chinner , linux-mm@kvack.org, Eric Dumazet , linux-hardening@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, linux-sctp@vger.kernel.org, lvs-devel@vger.kernel.org, coreteam@netfilter.org, linux-trace-kernel@vger.kernel.org, Kees Cook , bridge@lists.linux.dev, apparmor@lists.ubuntu.com, linux-xfs@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2024-04-25 09:10:27+0000, Thomas Weißschuh wrote: > On 2024-04-24 20:12:34+0000, Jakub Kicinski wrote: > > On Tue, 23 Apr 2024 09:54:35 +0200 Thomas Weißschuh wrote: > > > The series was split from my larger series sysctl-const series [0]. > > > It only focusses on the proc_handlers but is an important step to be > > > able to move all static definitions of ctl_table into .rodata. > > > > Split this per subsystem, please. > > Unfortunately this would introduce an enormous amount of code churn. > > The function prototypes for each callback have to stay consistent. > So a another callback member ("proc_handler_new") is needed and users > would be migrated to it gradually. > > But then *all* definitions of "struct ctl_table" throughout the tree need to > be touched. > In contrast, the proposed series only needs to change the handler > implementations, not their usage sites. > > There are many, many more usage sites than handler implementations. > > Especially, as the majority of sysctl tables use the standard handlers > (proc_dostring, proc_dobool, ...) and are not affected by the proposed > aproach at all. > > And then we would have introduced a new handler name "proc_handler_new" > and maybe have to do the whole thing again to rename it back to > the original and well-known "proc_handler". This aproach could be optimized by only migrating the usages of the custom handler implementations to "proc_handler_new". After this we could move over the core handlers and "proc_handler" in one small patch that does not need to touch the usages sites. Afterwards all non-core usages would be migrated back from "proc_handler_new" to "proc_handler" and the _new variant could be dropped again. It would still be more than twice the churn of my current patch. And these patches would be more complex than the current "just add a bunch of consts, nothing else". Personally I still prefer the original aproach. Thomas