From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4m0K-0005kz-Hj for qemu-devel@nongnu.org; Tue, 16 Jun 2015 04:13:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4m0I-0004yl-P7 for qemu-devel@nongnu.org; Tue, 16 Jun 2015 04:13:56 -0400 Received: from [59.151.112.132] (port=63635 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4m0E-0004uh-VJ for qemu-devel@nongnu.org; Tue, 16 Jun 2015 04:13:54 -0400 From: Chen Fan Date: Tue, 16 Jun 2015 16:10:57 +0800 Message-ID: <3bca7b4d0ce7202b35d932621def0cca2674baef.1434356309.git.chen.fan.fnst@cn.fujitsu.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [RFC v10 13/19] pci: add bus reset_notifiers callbacks for host bus reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: izumi.taku@jp.fujitsu.com, alex.williamson@redhat.com Particularly, For vfio devices, Once need to recovery devices by bus reset such as AER, we always need to reset the host bus to recovery the devices under the bus, so we need to add pci bus callbacks to specify to do host bus reset. Signed-off-by: Chen Fan --- hw/pci/pci.c | 16 ++++++++++++++++ hw/pci/pci_bridge.c | 6 ++++++ include/hw/pci/pci.h | 4 ++++ include/hw/pci/pci_bus.h | 2 ++ 4 files changed, 28 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 3423c3a..3bd954e 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -74,11 +74,27 @@ static const VMStateDescription vmstate_pcibus = { } }; +void pci_bus_add_reset_notifier(PCIBus *bus, Notifier *notify) +{ + notifier_list_add(&bus->reset_notifiers, notify); +} + +void pci_bus_remove_reset_notifier(Notifier *notify) +{ + notifier_remove(notify); +} + +void pci_bus_run_reset_notifier(PCIBus *bus, void *opaque) +{ + notifier_list_notify(&bus->reset_notifiers, opaque); +} + static void pci_bus_realize(BusState *qbus, Error **errp) { PCIBus *bus = PCI_BUS(qbus); vmstate_register(NULL, -1, &vmstate_pcibus, bus); + notifier_list_init(&bus->reset_notifiers); } static void pci_bus_unrealize(BusState *qbus, Error **errp) diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c index 40c97b1..a8e3f57 100644 --- a/hw/pci/pci_bridge.c +++ b/hw/pci/pci_bridge.c @@ -267,6 +267,12 @@ void pci_bridge_write_config(PCIDevice *d, newctl = pci_get_word(d->config + PCI_BRIDGE_CONTROL); if (~oldctl & newctl & PCI_BRIDGE_CTL_BUS_RESET) { + /* + * Notify all vfio-pci devices under the bus + * to do physical bus reset. + */ + pci_for_each_bus(&s->sec_bus, + pci_bus_run_reset_notifier, d); /* Trigger hot reset on 0->1 transition. */ qbus_reset_all(&s->sec_bus.qbus); } diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 6c2af0d..d353c9d 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -7,6 +7,7 @@ #include "exec/memory.h" #include "sysemu/dma.h" #include "qapi/error.h" +#include "qemu/notify.h" /* PCI includes legacy ISA access. */ #include "hw/isa/isa.h" @@ -377,6 +378,9 @@ void pci_bus_fire_intx_routing_notifier(PCIBus *bus); void pci_device_set_intx_routing_notifier(PCIDevice *dev, PCIINTxRoutingNotifier notifier); void pci_device_reset(PCIDevice *dev); +void pci_bus_add_reset_notifier(PCIBus *bus, Notifier *notify); +void pci_bus_remove_reset_notifier(Notifier *notify); +void pci_bus_run_reset_notifier(PCIBus *bus, void *opaque); PCIDevice *pci_nic_init_nofail(NICInfo *nd, PCIBus *rootbus, const char *default_model, diff --git a/include/hw/pci/pci_bus.h b/include/hw/pci/pci_bus.h index fabaeee..3b551d7 100644 --- a/include/hw/pci/pci_bus.h +++ b/include/hw/pci/pci_bus.h @@ -29,6 +29,8 @@ struct PCIBus { Keep a count of the number of devices with raised IRQs. */ int nirq; int *irq_count; + + NotifierList reset_notifiers; }; typedef struct PCIBridgeWindows PCIBridgeWindows; -- 1.9.3