* [PATCH 0/3] buildsys: Fix building with SASL on Windows
@ 2020-03-07 17:22 Philippe Mathieu-Daudé
2020-03-07 17:22 ` [PATCH 1/3] configure: Check for <sys/uio.h> header before external libraries Philippe Mathieu-Daudé
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-07 17:22 UTC (permalink / raw
To: qemu-devel
Cc: Fam Zheng, Daniel P . Berrangé, Alex Bennée,
Алексей Павлов,
Метлицкий Юрий Викторович,
Biswapriyo Nath, Paolo Bonzini, Philippe Mathieu-Daudé
Fix a bug reported by Youry few months ago:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg625606.html
The Fedora docker image already uses the libsasl since commit
8ea5962f286. Add the similar package to the Debian (host) image.
Philippe Mathieu-Daudé (3):
configure: Check for <sys/uio.h> header before external libraries
configure: Fix building with SASL on Windows
tests/docker: Install SASL library to extend code coverage on amd64
configure | 60 +++++++++++---------
tests/docker/dockerfiles/debian-amd64.docker | 1 +
2 files changed, 34 insertions(+), 27 deletions(-)
--
2.21.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] configure: Check for <sys/uio.h> header before external libraries
2020-03-07 17:22 [PATCH 0/3] buildsys: Fix building with SASL on Windows Philippe Mathieu-Daudé
@ 2020-03-07 17:22 ` Philippe Mathieu-Daudé
2020-03-07 17:22 ` [PATCH 2/3] configure: Fix building with SASL on Windows Philippe Mathieu-Daudé
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-07 17:22 UTC (permalink / raw
To: qemu-devel
Cc: Fam Zheng, Daniel P . Berrangé, Alex Bennée,
Алексей Павлов,
Метлицкий Юрий Викторович,
Biswapriyo Nath, Paolo Bonzini, Philippe Mathieu-Daudé
In the next commit we will add a definition to the SASL CFLAGS,
depending whether the scatter/gather I/O include is present.
Move the <sys/uio.h> header check before the external libraries
checks.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
configure | 52 ++++++++++++++++++++++++++--------------------------
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/configure b/configure
index cbf864bff1..0c2dd1eb08 100755
--- a/configure
+++ b/configure
@@ -2340,6 +2340,32 @@ if test "$vhost_net" = ""; then
test "$vhost_kernel" = "yes" && vhost_net=yes
fi
+##########################################
+# iovec probe
+cat > $TMPC <<EOF
+#include <sys/types.h>
+#include <sys/uio.h>
+#include <unistd.h>
+int main(void) { return sizeof(struct iovec); }
+EOF
+iovec=no
+if compile_prog "" "" ; then
+ iovec=yes
+fi
+
+##########################################
+# preadv probe
+cat > $TMPC <<EOF
+#include <sys/types.h>
+#include <sys/uio.h>
+#include <unistd.h>
+int main(void) { return preadv(0, 0, 0, 0); }
+EOF
+preadv=no
+if compile_prog "" "" ; then
+ preadv=yes
+fi
+
##########################################
# MinGW / Mingw-w64 localtime_r/gmtime_r check
@@ -4145,32 +4171,6 @@ EOF
fi
fi
-##########################################
-# iovec probe
-cat > $TMPC <<EOF
-#include <sys/types.h>
-#include <sys/uio.h>
-#include <unistd.h>
-int main(void) { return sizeof(struct iovec); }
-EOF
-iovec=no
-if compile_prog "" "" ; then
- iovec=yes
-fi
-
-##########################################
-# preadv probe
-cat > $TMPC <<EOF
-#include <sys/types.h>
-#include <sys/uio.h>
-#include <unistd.h>
-int main(void) { return preadv(0, 0, 0, 0); }
-EOF
-preadv=no
-if compile_prog "" "" ; then
- preadv=yes
-fi
-
##########################################
# fdt probe
# fdt support is mandatory for at least some target architectures,
--
2.21.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] configure: Fix building with SASL on Windows
2020-03-07 17:22 [PATCH 0/3] buildsys: Fix building with SASL on Windows Philippe Mathieu-Daudé
2020-03-07 17:22 ` [PATCH 1/3] configure: Check for <sys/uio.h> header before external libraries Philippe Mathieu-Daudé
@ 2020-03-07 17:22 ` Philippe Mathieu-Daudé
2020-03-09 9:57 ` Daniel P. Berrangé
2020-03-07 17:22 ` [PATCH 3/3] tests/docker: Install SASL library to extend code coverage on amd64 Philippe Mathieu-Daudé
2020-03-07 17:51 ` [PATCH 0/3] buildsys: Fix building with SASL on Windows no-reply
3 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-07 17:22 UTC (permalink / raw
To: qemu-devel
Cc: Fam Zheng, Alexey Pavlov, Daniel P . Berrangé,
Alex Bennée,
Алексей Павлов,
Метлицкий Юрий Викторович,
Biswapriyo Nath, Paolo Bonzini, Philippe Mathieu-Daudé,
Youry Metlitsky
The Simple Authentication and Security Layer (SASL) library
re-defines the struct iovec on Win32 [*]. QEMU also re-defines
it in "qemu/osdep.h". The two definitions then clash on a MinGW
build.
We can avoid the SASL definition by defining STRUCT_IOVEC_DEFINED.
Add the definition to vnc_sasl_cflags if we are uing MinGW.
[*] https://github.com/cyrusimap/cyrus-sasl/blob/cyrus-sasl-2.1.27/include/sasl.h#L187
Cc: Alexey Pavlov <alexpux@gmail.com>
Cc: Biswapriyo Nath <nathbappai@gmail.com>
Cc: Youry Metlitsky <winaes@yandex.ru>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
configure | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 0c2dd1eb08..0bc87ce42a 100755
--- a/configure
+++ b/configure
@@ -3375,7 +3375,13 @@ if test "$vnc" = "yes" && test "$vnc_sasl" != "no" ; then
int main(void) { sasl_server_init(NULL, "qemu"); return 0; }
EOF
# Assuming Cyrus-SASL installed in /usr prefix
- vnc_sasl_cflags=""
+ if test "$mingw32" = "yes" && test "$iovec" != "yes"; then
+ # QEMU defines struct iovec in "qemu/osdep.h",
+ # we don't want libsasl to redefine it in <sasl/sasl.h>.
+ vnc_sasl_cflags="-DSTRUCT_IOVEC_DEFINED"
+ else
+ vnc_sasl_cflags=""
+ fi
vnc_sasl_libs="-lsasl2"
if compile_prog "$vnc_sasl_cflags" "$vnc_sasl_libs" ; then
vnc_sasl=yes
--
2.21.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] tests/docker: Install SASL library to extend code coverage on amd64
2020-03-07 17:22 [PATCH 0/3] buildsys: Fix building with SASL on Windows Philippe Mathieu-Daudé
2020-03-07 17:22 ` [PATCH 1/3] configure: Check for <sys/uio.h> header before external libraries Philippe Mathieu-Daudé
2020-03-07 17:22 ` [PATCH 2/3] configure: Fix building with SASL on Windows Philippe Mathieu-Daudé
@ 2020-03-07 17:22 ` Philippe Mathieu-Daudé
2020-03-09 9:52 ` Daniel P. Berrangé
2020-03-07 17:51 ` [PATCH 0/3] buildsys: Fix building with SASL on Windows no-reply
3 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-07 17:22 UTC (permalink / raw
To: qemu-devel
Cc: Fam Zheng, Daniel P . Berrangé, Alex Bennée,
Алексей Павлов,
Метлицкий Юрий Викторович,
Biswapriyo Nath, Paolo Bonzini, Philippe Mathieu-Daudé
Install the SASL library to build the VNC SASL auth protocol code.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/docker/dockerfiles/debian-amd64.docker | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker
index 3b860af106..0456fc7a0c 100644
--- a/tests/docker/dockerfiles/debian-amd64.docker
+++ b/tests/docker/dockerfiles/debian-amd64.docker
@@ -17,6 +17,7 @@ RUN apt update && \
libbz2-dev \
liblzo2-dev \
librdmacm-dev \
+ libsasl2-dev \
libsnappy-dev \
libvte-dev
--
2.21.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] buildsys: Fix building with SASL on Windows
2020-03-07 17:22 [PATCH 0/3] buildsys: Fix building with SASL on Windows Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2020-03-07 17:22 ` [PATCH 3/3] tests/docker: Install SASL library to extend code coverage on amd64 Philippe Mathieu-Daudé
@ 2020-03-07 17:51 ` no-reply
3 siblings, 0 replies; 8+ messages in thread
From: no-reply @ 2020-03-07 17:51 UTC (permalink / raw
To: philmd
Cc: fam, berrange, philmd, alexey.pawlow, qemu-devel, winaes,
nathbappai, pbonzini, alex.bennee
Patchew URL: https://patchew.org/QEMU/20200307172222.14764-1-philmd@redhat.com/
Hi,
This series failed the docker-clang@ubuntu build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-ubuntu V=1 NETWORK=1
time make docker-test-clang@ubuntu SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===
LINK qemu-img
LINK qemu-io
LINK qemu-edid
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK fsdev/virtfs-proxy-helper
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK scsi/qemu-pr-helper
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK qemu-bridge-helper
LINK virtiofsd
GEN cris-softmmu/hmp-commands.h
---
CC mips-softmmu/hw/virtio/virtio-input-pci.o
CC mips64-softmmu/hw/virtio/virtio-blk-pci.o
CC arm-softmmu/hw/virtio/vhost-user-input-pci.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC alpha-softmmu/qapi/qapi-visit-machine-target.o
CC hppa-softmmu/qapi/qapi-types-machine-target.o
CC mips-softmmu/hw/virtio/virtio-rng-pci.o
---
CC ppc-softmmu/hw/display/virtio-gpu-base.o
CC arm-softmmu/hw/arm/fsl-imx6ul.o
CC or1k-softmmu/qapi/qapi-commands-misc-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC ppc64-softmmu/tcg/tcg-op.o
CC ppc-softmmu/hw/display/virtio-gpu.o
CC aarch64-softmmu/hw/arm/smmuv3.o
CC mipsel-softmmu/hw/misc/mips_itu.o
CC nios2-softmmu/qapi/qapi-types-machine-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC moxie-softmmu/target/moxie/translate.o
CC aarch64-softmmu/hw/arm/fsl-imx6ul.o
CC or1k-softmmu/qapi/qapi-commands.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC nios2-softmmu/qapi/qapi-types-misc-target.o
CC ppc64-softmmu/tcg/tcg-op-vec.o
CC ppc-softmmu/hw/display/virtio-gpu-3d.o
---
CC mipsel-softmmu/hw/vfio/spapr.o
CC ppc64-softmmu/qtest.o
CC arm-softmmu/qapi/qapi-events-machine-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC aarch64-softmmu/qapi/qapi-commands-misc-target.o
CC mipsel-softmmu/hw/vfio/pci.o
CC nios2-softmmu/target/nios2/translate.o
---
CC nios2-softmmu/trace/control-target.o
CC aarch64-softmmu/target/arm/cpu.o
CC aarch64-softmmu/target/arm/gdbstub.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC mipsel-softmmu/hw/virtio/vhost-user.o
CC ppc64-softmmu/accel/tcg/cputlb.o
CC nios2-softmmu/softmmu/main.o
---
CC aarch64-softmmu/target/arm/machine.o
CC aarch64-softmmu/target/arm/arch_dump.o
CC ppc-softmmu/hw/vfio/calxeda-xgmac.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC arm-softmmu/target/arm/monitor.o
CC mipsel-softmmu/hw/virtio/vhost-user-fs-pci.o
CC ppc64-softmmu/accel/tcg/translate-all.o
---
CC ppc64-softmmu/hw/vfio/pci.o
CC ppc-softmmu/monitor/misc.o
CC sparc-softmmu/hw/net/rocker/qmp-norocker.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC s390x-softmmu/dump/dump.o
CC sparc64-softmmu/hw/block/virtio-blk.o
CC sparc-softmmu/hw/sparc/sun4m_iommu.o
---
CC sparc64-softmmu/hw/virtio/vhost-user-fs-pci.o
CC riscv32-softmmu/hw/virtio/vhost-user-blk-pci.o
CC sh4eb-softmmu/hw/virtio/vhost-user-fs.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC sh4-softmmu/hw/virtio/virtio-crypto.o
CC riscv64-softmmu/hw/virtio/vhost-vsock.o
CC riscv64-softmmu/hw/virtio/vhost-vsock-pci.o
---
CC sh4eb-softmmu/qapi/qapi-types-misc-target.o
CC sparc64-softmmu/softmmu/vl.o
CC sh4-softmmu/monitor/misc.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC unicore32-softmmu/tcg/optimize.o
GEN x86_64-softmmu/hmp-commands.h
CC sparc64-softmmu/target/sparc/machine.o
---
CC riscv64-softmmu/qapi/qapi-init-commands.o
CC sh4eb-softmmu/trace/control-target.o
CC x86_64-softmmu/gdbstub.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK sparc64-softmmu/qemu-system-sparc64
CC s390x-softmmu/hw/s390x/virtio-ccw-input.o
CC sh4-softmmu/target/sh4/gdbstub.o
---
CC unicore32-softmmu/qapi/qapi-types.o
CC x86_64-softmmu/accel/kvm/kvm-all.o
CC riscv64-softmmu/trace/control-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC unicore32-softmmu/qapi/qapi-visit-machine-target.o
CC unicore32-softmmu/qapi/qapi-visit-misc-target.o
CC unicore32-softmmu/qapi/qapi-visit.o
CC s390x-softmmu/hw/s390x/s390-pci-bus.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK riscv32-softmmu/qemu-system-riscv32
CC riscv64-softmmu/softmmu/main.o
CC ppc64-softmmu/hw/ppc/ppce500_spin.o
---
GEN xtensa-softmmu/config-devices.h
GEN xtensa-softmmu/config-target.h
CC ppc64-softmmu/qapi/qapi-types-misc-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC xtensa-softmmu/exec.o
CC xtensa-softmmu/exec-vary.o
CC unicore32-softmmu/qapi/qapi-init-commands.o
---
CC unicore32-softmmu/trace/control-target.o
CC xtensaeb-softmmu/tcg/tcg-op-vec.o
CC xtensaeb-softmmu/tcg/tcg-op-gvec.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC ppc64-softmmu/qapi/qapi-commands-misc-target.o
CC unicore32-softmmu/softmmu/main.o
CC ppc64-softmmu/qapi/qapi-commands.o
---
CC xtensa-softmmu/balloon.o
CC s390x-softmmu/softmmu/vl.o
CC x86_64-softmmu/hw/char/virtio-serial-bus.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC aarch64-linux-user/tcg/tcg-common.o
CC aarch64_be-linux-user/tcg/tcg.o
CC xtensaeb-softmmu/balloon.o
---
CC x86_64-softmmu/hw/virtio/vhost-backend.o
CC xtensaeb-softmmu/hw/virtio/vhost-user.o
CC aarch64-linux-user/linux-user/signal.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC xtensa-softmmu/hw/virtio/vhost-user-input-pci.o
CC xtensa-softmmu/hw/virtio/vhost-user-scsi-pci.o
CC xtensa-softmmu/hw/virtio/vhost-scsi-pci.o
---
CC xtensaeb-softmmu/hw/virtio/virtio-crypto.o
CC aarch64_be-linux-user/linux-user/linuxload.o
CC aarch64_be-linux-user/linux-user/uaccess.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC arm-linux-user/linux-user/linuxload.o
CC arm-linux-user/linux-user/uaccess.o
CC xtensa-softmmu/hw/virtio/virtio-balloon-pci.o
---
GEN arm-linux-user/target/arm/decode-vfp.inc.c
CC xtensa-softmmu/target/xtensa/core-sample_controller.o
CC xtensa-softmmu/target/xtensa/core-test_kc705_be.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC xtensaeb-softmmu/qapi/qapi-visit-machine-target.o
CC xtensaeb-softmmu/qapi/qapi-visit-misc-target.o
CC aarch64_be-linux-user/target/arm/m_helper.o
---
CC xtensaeb-softmmu/target/xtensa/cpu.o
CC cris-linux-user/accel/stubs/hax-stub.o
CC cris-linux-user/accel/stubs/hvf-stub.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC xtensaeb-softmmu/target/xtensa/dbg_helper.o
CC x86_64-softmmu/hw/i386/../xenpv/xen_machine_pv.o
CC xtensaeb-softmmu/target/xtensa/exc_helper.o
---
CC i386-linux-user/accel/tcg/user-exec-stub.o
CC m68k-linux-user/accel/tcg/user-exec.o
CC hppa-linux-user/accel/tcg/translate-all.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC hppa-linux-user/accel/tcg/translator.o
CC i386-linux-user/linux-user/main.o
CC hppa-linux-user/accel/tcg/user-exec.o
---
GEN ppc64abi32-linux-user/config-target.h
CC nios2-linux-user/tcg/tcg-op.o
CC mips-linux-user/target/mips/op_helper.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC mipsn32-linux-user/tcg/tcg-common.o
CC nios2-linux-user/tcg/tcg-op-vec.o
CC ppc64abi32-linux-user/exec.o
---
LINK tests/test-aio
LINK tests/test-aio-multithread
LINK fp-test
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-throttle
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-thread-pool
LINK tests/test-hbitmap
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-bdrv-drain
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-bdrv-graph-mod
LINK tests/test-blockjob
LINK tests/test-blockjob-txn
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-block-backend
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-block-iothread
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-image-locking
LINK tests/test-x86-cpuid
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-xbzrle
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-vmstate
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-cutils
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-shift128
LINK tests/test-mul64
LINK tests/test-int128
---
LINK tests/test-crypto-hash
LINK tests/test-crypto-hmac
LINK tests/test-crypto-cipher
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-crypto-secret
LINK tests/test-crypto-tlscredsx509
LINK tests/test-crypto-tlssession
---
FLOAT TEST le_quiet
FLOAT TEST lt_quiet
FLOAT TEST add
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
FLOAT TEST sub
FLOAT TEST mul
FLOAT TEST mulAdd
---
dbus-daemon[7898]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry
**
ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
Aborted (core dumped)
cleaning up pid 7898
make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-i386] Error 1
make: *** Waiting for unfinished jobs....
Looking for expected file 'tests/data/acpi/pc/FACP.dimmpxm'
---
dbus-daemon[9219]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry
**
ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
Aborted (core dumped)
cleaning up pid 9219
make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-x86_64] Error 1
TEST check-qtest-arm: tests/qtest/test-hmp
TEST check-qtest-arm: tests/qtest/qos-test
TEST check-qtest-aarch64: tests/qtest/test-hmp
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=805fa14280a449208769b3b4727e3263', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-20x3yz26/src/docker-src.2020-03-07-12.31.34.16750:/var/tmp/qemu:z,ro', 'qemu:ubuntu', '/var/tmp/qemu/run', 'test-clang']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=805fa14280a449208769b3b4727e3263
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-20x3yz26/src'
make: *** [docker-run-test-clang@ubuntu] Error 2
real 19m31.609s
user 0m9.817s
The full log is available at
http://patchew.org/logs/20200307172222.14764-1-philmd@redhat.com/testing.docker-clang@ubuntu/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] tests/docker: Install SASL library to extend code coverage on amd64
2020-03-07 17:22 ` [PATCH 3/3] tests/docker: Install SASL library to extend code coverage on amd64 Philippe Mathieu-Daudé
@ 2020-03-09 9:52 ` Daniel P. Berrangé
0 siblings, 0 replies; 8+ messages in thread
From: Daniel P. Berrangé @ 2020-03-09 9:52 UTC (permalink / raw
To: Philippe Mathieu-Daudé
Cc: Fam Zheng,
Алексей Павлов,
qemu-devel,
Метлицкий Юрий Викторович,
Biswapriyo Nath, Paolo Bonzini, Alex Bennée
On Sat, Mar 07, 2020 at 06:22:22PM +0100, Philippe Mathieu-Daudé wrote:
> Install the SASL library to build the VNC SASL auth protocol code.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/docker/dockerfiles/debian-amd64.docker | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] configure: Fix building with SASL on Windows
2020-03-07 17:22 ` [PATCH 2/3] configure: Fix building with SASL on Windows Philippe Mathieu-Daudé
@ 2020-03-09 9:57 ` Daniel P. Berrangé
2020-03-09 10:47 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 8+ messages in thread
From: Daniel P. Berrangé @ 2020-03-09 9:57 UTC (permalink / raw
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Alexey Pavlov,
Алексей Павлов,
qemu-devel,
Метлицкий Юрий Викторович,
Biswapriyo Nath, Paolo Bonzini, Alex Bennée, Youry Metlitsky
On Sat, Mar 07, 2020 at 06:22:21PM +0100, Philippe Mathieu-Daudé wrote:
> The Simple Authentication and Security Layer (SASL) library
> re-defines the struct iovec on Win32 [*]. QEMU also re-defines
> it in "qemu/osdep.h". The two definitions then clash on a MinGW
> build.
> We can avoid the SASL definition by defining STRUCT_IOVEC_DEFINED.
> Add the definition to vnc_sasl_cflags if we are uing MinGW.
>
> [*] https://github.com/cyrusimap/cyrus-sasl/blob/cyrus-sasl-2.1.27/include/sasl.h#L187
>
> Cc: Alexey Pavlov <alexpux@gmail.com>
> Cc: Biswapriyo Nath <nathbappai@gmail.com>
> Cc: Youry Metlitsky <winaes@yandex.ru>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> configure | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 0c2dd1eb08..0bc87ce42a 100755
> --- a/configure
> +++ b/configure
> @@ -3375,7 +3375,13 @@ if test "$vnc" = "yes" && test "$vnc_sasl" != "no" ; then
> int main(void) { sasl_server_init(NULL, "qemu"); return 0; }
> EOF
> # Assuming Cyrus-SASL installed in /usr prefix
> - vnc_sasl_cflags=""
> + if test "$mingw32" = "yes" && test "$iovec" != "yes"; then
I don't get why we need the "iovec != yes" check there ?
On mingw sys/uio.h doesn't exist, so "$iovec" will always
be "no", and so this conditional is equivalent to
if test "$mingw32" = "yes; then
If for some strange reason, a future Windows adds sys/uio.h
header containing struct iovec, then QEMU won't define its
own local copy if struct iovec, and so "$iovec" will be "yes".
In this situation we don't want SASL to define its struct iovec
either.
IOW we need -DSTRUCT_IOVEC_DEFINED no matter what $iovec value
is AFAICT.
This would mean the previous patch is redundant too.
> + # QEMU defines struct iovec in "qemu/osdep.h",
> + # we don't want libsasl to redefine it in <sasl/sasl.h>.
> + vnc_sasl_cflags="-DSTRUCT_IOVEC_DEFINED"
> + else
> + vnc_sasl_cflags=""
> + fi
> vnc_sasl_libs="-lsasl2"
> if compile_prog "$vnc_sasl_cflags" "$vnc_sasl_libs" ; then
> vnc_sasl=yes
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] configure: Fix building with SASL on Windows
2020-03-09 9:57 ` Daniel P. Berrangé
@ 2020-03-09 10:47 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-09 10:47 UTC (permalink / raw
To: Daniel P. Berrangé
Cc: Fam Zheng, Alexey Pavlov,
Алексей Павлов,
qemu-devel,
Метлицкий Юрий Викторович,
Biswapriyo Nath, Paolo Bonzini, Alex Bennée, Youry Metlitsky
On 3/9/20 10:57 AM, Daniel P. Berrangé wrote:
> On Sat, Mar 07, 2020 at 06:22:21PM +0100, Philippe Mathieu-Daudé wrote:
>> The Simple Authentication and Security Layer (SASL) library
>> re-defines the struct iovec on Win32 [*]. QEMU also re-defines
>> it in "qemu/osdep.h". The two definitions then clash on a MinGW
>> build.
>> We can avoid the SASL definition by defining STRUCT_IOVEC_DEFINED.
>> Add the definition to vnc_sasl_cflags if we are uing MinGW.
>>
>> [*] https://github.com/cyrusimap/cyrus-sasl/blob/cyrus-sasl-2.1.27/include/sasl.h#L187
>>
>> Cc: Alexey Pavlov <alexpux@gmail.com>
>> Cc: Biswapriyo Nath <nathbappai@gmail.com>
>> Cc: Youry Metlitsky <winaes@yandex.ru>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> configure | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 0c2dd1eb08..0bc87ce42a 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3375,7 +3375,13 @@ if test "$vnc" = "yes" && test "$vnc_sasl" != "no" ; then
>> int main(void) { sasl_server_init(NULL, "qemu"); return 0; }
>> EOF
>> # Assuming Cyrus-SASL installed in /usr prefix
>> - vnc_sasl_cflags=""
>> + if test "$mingw32" = "yes" && test "$iovec" != "yes"; then
>
> I don't get why we need the "iovec != yes" check there ?
>
> On mingw sys/uio.h doesn't exist, so "$iovec" will always
> be "no", and so this conditional is equivalent to
>
> if test "$mingw32" = "yes; then
Indeed.
>
> If for some strange reason, a future Windows adds sys/uio.h
> header containing struct iovec, then QEMU won't define its
> own local copy if struct iovec, and so "$iovec" will be "yes".
>
> In this situation we don't want SASL to define its struct iovec
> either.
>
> IOW we need -DSTRUCT_IOVEC_DEFINED no matter what $iovec value
> is AFAICT.
Way simpler!
>
> This would mean the previous patch is redundant too.
Yes, thanks for reviewing :)
>
>> + # QEMU defines struct iovec in "qemu/osdep.h",
>> + # we don't want libsasl to redefine it in <sasl/sasl.h>.
>> + vnc_sasl_cflags="-DSTRUCT_IOVEC_DEFINED"
>> + else
>> + vnc_sasl_cflags=""
>> + fi
>> vnc_sasl_libs="-lsasl2"
>> if compile_prog "$vnc_sasl_cflags" "$vnc_sasl_libs" ; then
>> vnc_sasl=yes
>
> Regards,
> Daniel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-03-09 10:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-07 17:22 [PATCH 0/3] buildsys: Fix building with SASL on Windows Philippe Mathieu-Daudé
2020-03-07 17:22 ` [PATCH 1/3] configure: Check for <sys/uio.h> header before external libraries Philippe Mathieu-Daudé
2020-03-07 17:22 ` [PATCH 2/3] configure: Fix building with SASL on Windows Philippe Mathieu-Daudé
2020-03-09 9:57 ` Daniel P. Berrangé
2020-03-09 10:47 ` Philippe Mathieu-Daudé
2020-03-07 17:22 ` [PATCH 3/3] tests/docker: Install SASL library to extend code coverage on amd64 Philippe Mathieu-Daudé
2020-03-09 9:52 ` Daniel P. Berrangé
2020-03-07 17:51 ` [PATCH 0/3] buildsys: Fix building with SASL on Windows no-reply
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.