From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Denzeel Oliva <wachiturroxd150@gmail.com>,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
alim.akhtar@samsung.com, semen.protsenko@linaro.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v1 3/3] arm64: dts: exynos990: define all PERIC USI nodes
Date: Thu, 13 Feb 2025 07:38:35 +0000 [thread overview]
Message-ID: <40370a0e-775b-42e3-bb6c-8cacaa0482cf@linaro.org> (raw)
In-Reply-To: <20250212234034.284-4-wachiturroxd150@gmail.com>
On 2/12/25 11:40 PM, Denzeel Oliva wrote:
> Universal Serial Interface (USI) supports three types of serial interface
> such as Universal Asynchronous Receiver and Transmitter (UART), Serial
> Peripheral Interface (SPI), and Inter-Integrated Circuit (I2C).
> Each protocols can be working independently and configured as one of
> those using external configuration inputs.
>
> Exynos990 SoC defines 18 USI nodes in PERIC0/1 blocks.
> Nodes have different depths from 64-256 bytes.
for the reviewer's peace of mind you shall specify whether you tested at
least an i2c, uart and spi node.
>
> Signed-off-by: Denzeel Oliva <wachiturroxd150@gmail.com>
> ---
> arch/arm64/boot/dts/exynos/exynos990.dtsi | 1693 +++++++++++++++++++++
> 1 file changed, 1693 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos990.dtsi b/arch/arm64/boot/dts/exynos/exynos990.dtsi
> index aa056fdae..22ec92a45 100644
> --- a/arch/arm64/boot/dts/exynos/exynos990.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos990.dtsi
> @@ -7,6 +7,7 @@
>
> #include <dt-bindings/clock/samsung,exynos990.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/soc/samsung,exynos-usi.h>
>
> / {
> compatible = "samsung,exynos990";
> @@ -248,6 +249,808 @@ sysreg_peric0: syscon@10420000 {
> clocks = <&cmu_peric0 CLK_GOUT_PERIC0_SYSREG_PCLK>;
> };
>
> + usi_uart: usi@105400c0 {
> + compatible = "samsung,exynos990-usi", "samsung,exynos850-usi";
> + reg = <0x105400c0 0x20>;
> + samsung,sysreg = <&sysreg_peric0 0x1000>;
> + samsung,mode = <USI_V2_UART>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_TOP0_PCLK_4>,
> + <&cmu_peric0 CLK_GOUT_PERIC0_TOP0_IPCLK_4>;
> + clock-names = "pclk", "ipclk";
> + status = "disabled";
> +
> + serial_0: serial@10540000 {
> + compatible = "samsung,exynos990-uart",
> + "samsung,exynos8895-uart";
> + reg = <0x10540000 0xc0>;
> + interrupts = <GIC_SPI 391 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_bus>;
> + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_TOP0_PCLK_4>,
> + <&cmu_peric0 CLK_GOUT_PERIC0_TOP0_IPCLK_4>;
> + clock-names = "uart", "clk_uart_baud0";
> + samsung,uart-fifosize = <256>;
> + status = "disabled";
node properties shall be specified in a specific order. Follow similar
nodes that are already accepted, gs101 is one.
> + };
> + };
> +
> + usi0: usi@105500c0 {
cut
> +
> + hsi2c_0: i2c@10550000 {
cut
> +
> + spi_0: spi@10550000 {
cut
> + serial_2: serial@10550000 {
why not serial_0 since you're in USI0.
> + };
> +
> + usi_i2c_0: usi@105600c0 {
> + compatible = "samsung,exynos990-usi", "samsung,exynos850-usi";
> + reg = <0x105600c0 0x20>;
> + samsung,sysreg = <&sysreg_peric0 0x1008>;
> + samsung,mode = <USI_V2_I2C>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_TOP0_PCLK_6>,
> + <&cmu_peric0 CLK_GOUT_PERIC0_TOP0_IPCLK_6>;
> + clock-names = "pclk", "ipclk";
> + status = "disabled";
> +
> + hsi2c_1: i2c@10560000 {
> + compatible = "samsung,exynos990-hsi2c",
> + "samsung,exynosautov9-hsi2c";
> + reg = <0x10560000 0xc0>;
> + interrupts = <GIC_SPI 398 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&hsi2c1_bus>;
> + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_TOP0_IPCLK_6>,
> + <&cmu_peric0 CLK_GOUT_PERIC0_TOP0_PCLK_6>;
> + clock-names = "hsi2c", "hsi2c_pclk";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
shouldn't you define serial and SPI too?
> + };
> +
cut
> + spi_8: spi@108e0000 {
> + compatible = "samsung,exynos990-spi";
> + reg = <0x108e0000 0x30>;
> + interrupts = <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi8_bus>;
> + clocks = <&cmu_peric1 CLK_GOUT_PERIC1_TOP0_PCLK_14>,
> + <&cmu_peric1 CLK_GOUT_PERIC1_TOP0_IPCLK_14>;
> + clock-names = "spi", "spi_busclk0";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + fifo-depth = <256>;
that's a first. Does downstream define any SPI node with 256 bytes
FIFOs? Would you please point me to the downstream sources?
Cheers,
ta
next prev parent reply other threads:[~2025-02-13 7:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 23:40 [PATCH v1 0/3] arm64: dts: exynos990: define all PERIC0/1 USI nodes Denzeel Oliva
2025-02-12 23:40 ` [PATCH v1 1/3] dt-bindings: samsung: usi: add exynos990-usi compatible Denzeel Oliva
2025-02-12 23:40 ` [PATCH v1 2/3] dt-bindings: serial: samsung: add Exynos990 compatible Denzeel Oliva
2025-02-13 7:20 ` Tudor Ambarus
2025-02-14 5:16 ` Denzeel Oliva
2025-02-14 6:42 ` Tudor Ambarus
2025-02-12 23:40 ` [PATCH v1 3/3] arm64: dts: exynos990: define all PERIC USI nodes Denzeel Oliva
2025-02-13 7:38 ` Tudor Ambarus [this message]
2025-02-14 6:17 ` Denzeel Oliva
2025-02-14 6:49 ` Tudor Ambarus
2025-02-14 15:39 ` Sam Protsenko
2025-02-14 8:20 ` [PATCH v1 0/3] arm64: dts: exynos990: define all PERIC0/1 " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40370a0e-775b-42e3-bb6c-8cacaa0482cf@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=wachiturroxd150@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.