* [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:*
@ 2014-12-03 6:45 Wen-chien Jesse Sung
2014-12-03 6:45 ` [PATCH 2/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom devices 13d3:* Wen-chien Jesse Sung
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Wen-chien Jesse Sung @ 2014-12-03 6:45 UTC (permalink / raw
To: linux-bluetooth
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
Most modules of this BCM20702A0 variant are known to require external
firmware to work properly.
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
drivers/bluetooth/btusb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Bluetooth-Add-BTUSB_BCM_PATCHRAM-flag-for-Broadcom-d.patch --]
[-- Type: text/x-patch; name="0001-Bluetooth-Add-BTUSB_BCM_PATCHRAM-flag-for-Broadcom-d.patch", Size: 572 bytes --]
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 292c38e..5c9eeda 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -108,7 +108,8 @@ static const struct usb_device_id btusb_table[] = {
{ USB_DEVICE(0x413c, 0x8197) },
/* Foxconn - Hon Hai */
- { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01) },
+ { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
+ .driver_info = BTUSB_BCM_PATCHRAM },
/* Broadcom devices with vendor specific id */
{ USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01),
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom devices 13d3:*
2014-12-03 6:45 [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:* Wen-chien Jesse Sung
@ 2014-12-03 6:45 ` Wen-chien Jesse Sung
2014-12-03 10:04 ` Marcel Holtmann
2014-12-03 6:45 ` [PATCH 3/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom 413c:8197 Wen-chien Jesse Sung
` (4 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Wen-chien Jesse Sung @ 2014-12-03 6:45 UTC (permalink / raw
To: linux-bluetooth
[-- Attachment #1: Type: text/plain, Size: 436 bytes --]
It is known that at least 13d3:3388, 13d3:3389, and 13d3:3404 require
external firmwares to work properly. Since the firmware loading
procedure is skipped if there's no firmware file provided, it is safe to
set BTUSB_BCM_PATCHRAM for 13d3:* instead of adding each module one by
one.
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
drivers/bluetooth/btusb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-Bluetooth-Add-BTUSB_BCM_PATCHRAM-to-Broadcom-devices.patch --]
[-- Type: text/x-patch; name="0002-Bluetooth-Add-BTUSB_BCM_PATCHRAM-to-Broadcom-devices.patch", Size: 587 bytes --]
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 5c9eeda..5b8e029 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -122,7 +122,8 @@ static const struct usb_device_id btusb_table[] = {
{ USB_VENDOR_AND_INTERFACE_INFO(0x050d, 0xff, 0x01, 0x01) },
/* IMC Networks - Broadcom based */
- { USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xff, 0x01, 0x01) },
+ { USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xff, 0x01, 0x01),
+ .driver_info = BTUSB_BCM_PATCHRAM },
/* Intel Bluetooth USB Bootloader (RAM module) */
{ USB_DEVICE(0x8087, 0x0a5a),
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom 413c:8197
2014-12-03 6:45 [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:* Wen-chien Jesse Sung
2014-12-03 6:45 ` [PATCH 2/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom devices 13d3:* Wen-chien Jesse Sung
@ 2014-12-03 6:45 ` Wen-chien Jesse Sung
2014-12-03 10:04 ` Marcel Holtmann
2014-12-03 6:45 ` [PATCH 4/6] Bluetooth: Add support for Broadcom 413c:8143 Wen-chien Jesse Sung
` (3 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Wen-chien Jesse Sung @ 2014-12-03 6:45 UTC (permalink / raw
To: linux-bluetooth
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
This device needs an external firmware to make HSP and HFP work.
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
drivers/bluetooth/btusb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0003-Bluetooth-Add-BTUSB_BCM_PATCHRAM-to-Broadcom-413c-81.patch --]
[-- Type: text/x-patch; name="0003-Bluetooth-Add-BTUSB_BCM_PATCHRAM-to-Broadcom-413c-81.patch", Size: 531 bytes --]
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 5b8e029..c92f59f 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -105,7 +105,8 @@ static const struct usb_device_id btusb_table[] = {
{ USB_DEVICE(0x04ca, 0x2003) },
{ USB_DEVICE(0x0b05, 0x17b5) },
{ USB_DEVICE(0x0b05, 0x17cb) },
- { USB_DEVICE(0x413c, 0x8197) },
+ { USB_DEVICE(0x413c, 0x8197),
+ .driver_info = BTUSB_BCM_PATCHRAM },
/* Foxconn - Hon Hai */
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/6] Bluetooth: Add support for Broadcom 413c:8143
2014-12-03 6:45 [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:* Wen-chien Jesse Sung
2014-12-03 6:45 ` [PATCH 2/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom devices 13d3:* Wen-chien Jesse Sung
2014-12-03 6:45 ` [PATCH 3/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom 413c:8197 Wen-chien Jesse Sung
@ 2014-12-03 6:45 ` Wen-chien Jesse Sung
2014-12-03 10:04 ` Marcel Holtmann
2014-12-03 6:45 ` [PATCH 5/6] Bluetooth: Add support for 04ca:2007 Wen-chien Jesse Sung
` (2 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Wen-chien Jesse Sung @ 2014-12-03 6:45 UTC (permalink / raw
To: linux-bluetooth; +Cc: Gavin Guo
[-- Attachment #1: Type: text/plain, Size: 44 bytes --]
This is a multi-part message in MIME format.
[-- Attachment #2: Type: text/plain, Size: 852 bytes --]
The device require external patchram firmware to work and need to
add corresponding id in the btusb.c.
T: Bus=03 Lev=01 Prnt=01 Port=08 Cnt=03 Dev#= 2 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=413c ProdID=8143 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM20702A0
S: SerialNumber=20689D1FAF94
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
Signed-off-by: Gavin Guo <gavin.guo@canonical.com>
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
drivers/bluetooth/btusb.c | 2 ++
1 file changed, 2 insertions(+)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0004-Bluetooth-Add-support-for-Broadcom-413c-8143.patch --]
[-- Type: text/x-patch; name="0004-Bluetooth-Add-support-for-Broadcom-413c-8143.patch", Size: 502 bytes --]
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index c92f59f..d2923a8 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -107,6 +107,8 @@ static const struct usb_device_id btusb_table[] = {
{ USB_DEVICE(0x0b05, 0x17cb) },
{ USB_DEVICE(0x413c, 0x8197),
.driver_info = BTUSB_BCM_PATCHRAM },
+ { USB_DEVICE(0x413c, 0x8143),
+ .driver_info = BTUSB_BCM_PATCHRAM },
/* Foxconn - Hon Hai */
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/6] Bluetooth: Add support for 04ca:2007
2014-12-03 6:45 [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:* Wen-chien Jesse Sung
` (2 preceding siblings ...)
2014-12-03 6:45 ` [PATCH 4/6] Bluetooth: Add support for Broadcom 413c:8143 Wen-chien Jesse Sung
@ 2014-12-03 6:45 ` Wen-chien Jesse Sung
2014-12-03 6:45 ` [PATCH 6/6] Bluetooth: Add support for 105b:e065 Wen-chien Jesse Sung
2014-12-03 10:04 ` [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:* Marcel Holtmann
5 siblings, 0 replies; 11+ messages in thread
From: Wen-chien Jesse Sung @ 2014-12-03 6:45 UTC (permalink / raw
To: linux-bluetooth; +Cc: Adam Lee, Bruce Ma
[-- Attachment #1: Type: text/plain, Size: 44 bytes --]
This is a multi-part message in MIME format.
[-- Attachment #2: Type: text/plain, Size: 903 bytes --]
BugLink: https://launchpad.net/bugs/1153448
These devices require external patchram firmware to work.
T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=04ca ProdID=2007 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM43142A0
S: SerialNumber=20689DD16A22
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
Signed-off-by: Adam Lee <adam.lee@canonical.com>
Signed-off-by: Bruce Ma <bruce.ma@canonical.com>
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
drivers/bluetooth/btusb.c | 4 ++++
1 file changed, 4 insertions(+)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0005-Bluetooth-Add-support-for-04ca-2007.patch --]
[-- Type: text/x-patch; name="0005-Bluetooth-Add-support-for-04ca-2007.patch", Size: 540 bytes --]
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index d2923a8..740c854 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -110,6 +110,10 @@ static const struct usb_device_id btusb_table[] = {
{ USB_DEVICE(0x413c, 0x8143),
.driver_info = BTUSB_BCM_PATCHRAM },
+ /* Broadcom BCM43142A0 */
+ { USB_DEVICE(0x04ca, 0x2007),
+ .driver_info = BTUSB_BCM_PATCHRAM },
+
/* Foxconn - Hon Hai */
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
.driver_info = BTUSB_BCM_PATCHRAM },
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 6/6] Bluetooth: Add support for 105b:e065
2014-12-03 6:45 [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:* Wen-chien Jesse Sung
` (3 preceding siblings ...)
2014-12-03 6:45 ` [PATCH 5/6] Bluetooth: Add support for 04ca:2007 Wen-chien Jesse Sung
@ 2014-12-03 6:45 ` Wen-chien Jesse Sung
2014-12-03 10:04 ` Marcel Holtmann
2014-12-03 10:04 ` [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:* Marcel Holtmann
5 siblings, 1 reply; 11+ messages in thread
From: Wen-chien Jesse Sung @ 2014-12-03 6:45 UTC (permalink / raw
To: linux-bluetooth; +Cc: Adam Lee
[-- Attachment #1: Type: text/plain, Size: 44 bytes --]
This is a multi-part message in MIME format.
[-- Attachment #2: Type: text/plain, Size: 852 bytes --]
BugLink: https://launchpad.net/bugs/1161261
These devices require external patchram firmware to work.
T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=01 Dev#= 9 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=105b ProdID=e065 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM43142A0
S: SerialNumber=0090A295B4C6
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
Signed-off-by: Adam Lee <adam.lee@canonical.com>
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
drivers/bluetooth/btusb.c | 2 ++
1 file changed, 2 insertions(+)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0006-Bluetooth-Add-support-for-105b-e065.patch --]
[-- Type: text/x-patch; name="0006-Bluetooth-Add-support-for-105b-e065.patch", Size: 496 bytes --]
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 740c854..04d7958 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -113,6 +113,8 @@ static const struct usb_device_id btusb_table[] = {
/* Broadcom BCM43142A0 */
{ USB_DEVICE(0x04ca, 0x2007),
.driver_info = BTUSB_BCM_PATCHRAM },
+ { USB_DEVICE(0x105b, 0xe065),
+ .driver_info = BTUSB_BCM_PATCHRAM },
/* Foxconn - Hon Hai */
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:*
2014-12-03 6:45 [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:* Wen-chien Jesse Sung
` (4 preceding siblings ...)
2014-12-03 6:45 ` [PATCH 6/6] Bluetooth: Add support for 105b:e065 Wen-chien Jesse Sung
@ 2014-12-03 10:04 ` Marcel Holtmann
5 siblings, 0 replies; 11+ messages in thread
From: Marcel Holtmann @ 2014-12-03 10:04 UTC (permalink / raw
To: Wen-chien Jesse Sung; +Cc: linux-bluetooth
Hi Wen-chien,
> Most modules of this BCM20702A0 variant are known to require external
> firmware to work properly.
>
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
> ---
> drivers/bluetooth/btusb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 292c38e..5c9eeda 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -108,7 +108,8 @@ static const struct usb_device_id btusb_table[] = {
> { USB_DEVICE(0x413c, 0x8197) },
>
> /* Foxconn - Hon Hai */
> - { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01) },
> + { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
> + .driver_info = BTUSB_BCM_PATCHRAM },
>
> /* Broadcom devices with vendor specific id */
> { USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01),
lets add information in the commit message on how to retrieve a firmware to use. I also prefer to have the content from /sys/kernel/debug/usb/devices added as well.
Regards
Marcel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom devices 13d3:*
2014-12-03 6:45 ` [PATCH 2/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom devices 13d3:* Wen-chien Jesse Sung
@ 2014-12-03 10:04 ` Marcel Holtmann
0 siblings, 0 replies; 11+ messages in thread
From: Marcel Holtmann @ 2014-12-03 10:04 UTC (permalink / raw
To: Wen-chien Jesse Sung; +Cc: linux-bluetooth
Hi Wen-chien,
> It is known that at least 13d3:3388, 13d3:3389, and 13d3:3404 require
> external firmwares to work properly. Since the firmware loading
> procedure is skipped if there's no firmware file provided, it is safe to
> set BTUSB_BCM_PATCHRAM for 13d3:* instead of adding each module one by
> one.
>
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
> ---
> drivers/bluetooth/btusb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 5c9eeda..5b8e029 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -122,7 +122,8 @@ static const struct usb_device_id btusb_table[] = {
> { USB_VENDOR_AND_INTERFACE_INFO(0x050d, 0xff, 0x01, 0x01) },
>
> /* IMC Networks - Broadcom based */
> - { USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xff, 0x01, 0x01) },
> + { USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xff, 0x01, 0x01),
> + .driver_info = BTUSB_BCM_PATCHRAM },
>
> /* Intel Bluetooth USB Bootloader (RAM module) */
> { USB_DEVICE(0x8087, 0x0a5a),
I would prefer adding text in the commit message to explain where the firmware is coming from.
Regards
Marcel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom 413c:8197
2014-12-03 6:45 ` [PATCH 3/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom 413c:8197 Wen-chien Jesse Sung
@ 2014-12-03 10:04 ` Marcel Holtmann
0 siblings, 0 replies; 11+ messages in thread
From: Marcel Holtmann @ 2014-12-03 10:04 UTC (permalink / raw
To: Wen-chien Jesse Sung; +Cc: linux-bluetooth
Hi Wen-chien,
> This device needs an external firmware to make HSP and HFP work.
>
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
> ---
> drivers/bluetooth/btusb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 5b8e029..c92f59f 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -105,7 +105,8 @@ static const struct usb_device_id btusb_table[] = {
> { USB_DEVICE(0x04ca, 0x2003) },
> { USB_DEVICE(0x0b05, 0x17b5) },
> { USB_DEVICE(0x0b05, 0x17cb) },
> - { USB_DEVICE(0x413c, 0x8197) },
> + { USB_DEVICE(0x413c, 0x8197),
> + .driver_info = BTUSB_BCM_PATCHRAM },
>
> /* Foxconn - Hon Hai */
> { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
so here as well picking USB_VENDOR_AND_INTERFACE_INFO is a good idea. However we might need use the blacklist entries to mark these devices fail if there is no firmware.
Regards
Marcel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/6] Bluetooth: Add support for Broadcom 413c:8143
2014-12-03 6:45 ` [PATCH 4/6] Bluetooth: Add support for Broadcom 413c:8143 Wen-chien Jesse Sung
@ 2014-12-03 10:04 ` Marcel Holtmann
0 siblings, 0 replies; 11+ messages in thread
From: Marcel Holtmann @ 2014-12-03 10:04 UTC (permalink / raw
To: Wen-chien Jesse Sung; +Cc: linux-bluetooth, Gavin Guo
Hi Wen-chien,
> The device require external patchram firmware to work and need to
> add corresponding id in the btusb.c.
>
> T: Bus=03 Lev=01 Prnt=01 Port=08 Cnt=03 Dev#= 2 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=413c ProdID=8143 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM20702A0
> S: SerialNumber=20689D1FAF94
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> Signed-off-by: Gavin Guo <gavin.guo@canonical.com>
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
> ---
> drivers/bluetooth/btusb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index c92f59f..d2923a8 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -107,6 +107,8 @@ static const struct usb_device_id btusb_table[] = {
> { USB_DEVICE(0x0b05, 0x17cb) },
> { USB_DEVICE(0x413c, 0x8197),
> .driver_info = BTUSB_BCM_PATCHRAM },
> + { USB_DEVICE(0x413c, 0x8143),
> + .driver_info = BTUSB_BCM_PATCHRAM },
>
> /* Foxconn - Hon Hai */
> { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
same here as well, lets use USB_VENDOR_INTERFACE_INFO and explain where the firmware comes from.
Regards
Marcel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 6/6] Bluetooth: Add support for 105b:e065
2014-12-03 6:45 ` [PATCH 6/6] Bluetooth: Add support for 105b:e065 Wen-chien Jesse Sung
@ 2014-12-03 10:04 ` Marcel Holtmann
0 siblings, 0 replies; 11+ messages in thread
From: Marcel Holtmann @ 2014-12-03 10:04 UTC (permalink / raw
To: Wen-chien Jesse Sung; +Cc: linux-bluetooth, Adam Lee
Hi Wen-chien,
> BugLink: https://launchpad.net/bugs/1161261
>
> These devices require external patchram firmware to work.
>
> T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=01 Dev#= 9 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=105b ProdID=e065 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM43142A0
> S: SerialNumber=0090A295B4C6
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> Signed-off-by: Adam Lee <adam.lee@canonical.com>
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
> ---
> drivers/bluetooth/btusb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 740c854..04d7958 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -113,6 +113,8 @@ static const struct usb_device_id btusb_table[] = {
> /* Broadcom BCM43142A0 */
> { USB_DEVICE(0x04ca, 0x2007),
> .driver_info = BTUSB_BCM_PATCHRAM },
> + { USB_DEVICE(0x105b, 0xe065),
> + .driver_info = BTUSB_BCM_PATCHRAM },
>
> /* Foxconn - Hon Hai */
> { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
same here, lets use USB_VENDOR_AND_INTERFACE_INFO and have an explanation on how to get the firmware.
Regards
Marcel
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-12-03 10:04 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 6:45 [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:* Wen-chien Jesse Sung
2014-12-03 6:45 ` [PATCH 2/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom devices 13d3:* Wen-chien Jesse Sung
2014-12-03 10:04 ` Marcel Holtmann
2014-12-03 6:45 ` [PATCH 3/6] Bluetooth: Add BTUSB_BCM_PATCHRAM to Broadcom 413c:8197 Wen-chien Jesse Sung
2014-12-03 10:04 ` Marcel Holtmann
2014-12-03 6:45 ` [PATCH 4/6] Bluetooth: Add support for Broadcom 413c:8143 Wen-chien Jesse Sung
2014-12-03 10:04 ` Marcel Holtmann
2014-12-03 6:45 ` [PATCH 5/6] Bluetooth: Add support for 04ca:2007 Wen-chien Jesse Sung
2014-12-03 6:45 ` [PATCH 6/6] Bluetooth: Add support for 105b:e065 Wen-chien Jesse Sung
2014-12-03 10:04 ` Marcel Holtmann
2014-12-03 10:04 ` [PATCH 1/6] Bluetooth: Add BTUSB_BCM_PATCHRAM flag for Broadcom devices 0489:* Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.