From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>
Cc: "Rao, Vinay" <Vinay.Rao@dell.com>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"Belanger, Martin" <Martin.Belanger@dell.com>,
"Hayes, Stuart" <Stuart.Hayes@dell.com>,
"Tarikere, Madhu" <Madhu.Tarikere@dell.com>,
Martin Belanger <nitram_67@hotmail.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH 1/1] nvme-fabrics: Generate uevent on namespace AENs
Date: Thu, 24 Jun 2021 11:17:33 +0200 [thread overview]
Message-ID: <45d90119-0193-0110-0b66-803ffc84bc69@suse.de> (raw)
In-Reply-To: <20210503065235.GB32627@lst.de>
On 5/3/21 8:52 AM, Christoph Hellwig wrote:
> On Fri, Apr 30, 2021 at 09:21:04AM -0700, Keith Busch wrote:
>> On Fri, Apr 30, 2021 at 05:14:55AM +0000, Rao, Vinay wrote:
>>> + Madhu
>>>
>>> Hi Chaitanya,
>>>
>>> Some of the AEN's like ANA state change and Name Space attribute change events are of interest outside the NVME driver.
>>>
>>> It would be good to consider these events to be propagated up to user space. I am not yet convinced on how propagating this above to user space is problematic.
>>
>> The namespace attribute change event pairs with the Changed Namespace
>> List log, and reading that log will change the result for a subsequent
>> reader. User space racing with the kernel on a log access when there are
>> read side effects creates non-deterministic behavior, and that is
>> problematic.
>
> The only way I could think of making this work is by:
>
> forcing the RAE bit on for all log pages that the kernel cares about,
> and only delivering the uevent on controllers that actually do support
> the RAE bit (IIRC it got added in 1.3, but I'd have to check).
>
... and you are correct, it went into the base spec into 1.3.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-06-24 9:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 20:18 [PATCH 1/1] nvme-fabrics: Generate uevent on namespace AENs Martin Belanger
2021-04-29 1:18 ` Chaitanya Kulkarni
2021-04-29 1:24 ` Chaitanya Kulkarni
2021-04-29 6:30 ` Christoph Hellwig
2021-04-29 16:58 ` Belanger, Martin
2021-04-29 18:22 ` Chaitanya Kulkarni
2021-04-30 5:14 ` Rao, Vinay
2021-04-30 16:21 ` Keith Busch
2021-05-03 6:52 ` Christoph Hellwig
2021-05-03 7:20 ` Rao, Vinay
2021-05-03 23:20 ` Chaitanya Kulkarni
2021-05-03 23:21 ` Chaitanya Kulkarni
2021-05-04 8:32 ` Rao, Vinay
2021-05-11 8:53 ` Rao, Vinay
2021-06-16 10:38 ` Rao, Vinay
2021-06-24 9:10 ` Hannes Reinecke
2021-06-24 9:17 ` Hannes Reinecke [this message]
2021-06-24 10:49 ` Hannes Reinecke
2021-06-30 14:00 ` Rao, Vinay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45d90119-0193-0110-0b66-803ffc84bc69@suse.de \
--to=hare@suse.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Madhu.Tarikere@dell.com \
--cc=Martin.Belanger@dell.com \
--cc=Stuart.Hayes@dell.com \
--cc=Vinay.Rao@dell.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nitram_67@hotmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.