From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
Subject: Re: [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue
Date: Wed, 9 Dec 2015 08:35:12 +0000
Message-ID: <4837007523CC9A4B9414D20C13DE6E641363D33A@IRSMSX102.ger.corp.intel.com>
References: <1449584208-24987-1-git-send-email-piotrx.t.azarewicz@intel.com>
 <B27915DBBA3421428155699D51E4CFE2023FEA7F@IRSMSX103.ger.corp.intel.com>
 <B27915DBBA3421428155699D51E4CFE2023FEDE3@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: "Mcnamara, John" <john.mcnamara@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id A93D7568B
 for <dev@dpdk.org>; Wed,  9 Dec 2015 09:35:31 +0100 (CET)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023FEDE3@IRSMSX103.ger.corp.intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Mcnamara, John
> Sent: Tuesday, December 8, 2015 6:00 PM
> To: Mcnamara, John <john.mcnamara@intel.com>; Azarewicz, PiotrX T
> <piotrx.t.azarewicz@intel.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy
> issue
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
> > Sent: Tuesday, December 8, 2015 2:47 PM
> > To: Azarewicz, PiotrX T; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy
> > issue
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Piotr Azarewicz
> > > Sent: Tuesday, December 8, 2015 2:17 PM
> > > To: dev@dpdk.org
> > > Subject: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy
> > > issue
> > >
> > > The cmds and thread_cmds both are the arrays of cmdline_parse_ctx_t.
> > > So the goal is to copy elements size of cmdline_parse_ctx_t not
> > > cmdline_parse_ctx_t*.
> > >
> > > Coverity issue: 120412
> > > Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread
> > > binding
> > > dynamically")
> > >
> > > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> >
> > Acked-by: John McNamara <john.mcnamara@intel.com>
>=20
> Hi Piotr,
>=20
> This issue occurs copy and pasted in two other locations as well:
>=20
>     examples/ip_pipeline/pipeline/pipeline_common_fe.c
>     1295:           n_cmds * sizeof(cmdline_parse_ctx_t *));
>=20
>     examples/ip_pipeline/thread_fe.c
>     340:            n_cmds * sizeof(cmdline_parse_ctx_t *));
>=20
>     examples/ip_pipeline/init.c
>     1475:           n_cmds * sizeof(cmdline_parse_ctx_t *));
>=20
> Perhaps you could fix those in the same patch.
>=20
> Thanks,
>=20
> John
>=20
>=20

Yes, you are right, thanks. I will send v2.

Piotr