* [Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation after FEC modified
@ 2021-04-13 14:19 Mateusz Palczewski
2021-04-14 21:36 ` Nguyen, Anthony L
2021-05-03 20:51 ` Switzer, David
0 siblings, 2 replies; 3+ messages in thread
From: Mateusz Palczewski @ 2021-04-13 14:19 UTC (permalink / raw
To: intel-wired-lan
From: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
When FEC mode was changed the link didn't know it because
the link was not reset and new parameters were not negotiated.
Set a flag 'I40E_AQ_PHY_ENABLE_ATOMIC_LINK' in 'abilities'
to restart the link and make it run with the new settings.
Fixes: 1d96340196f1 ("i40e: Add support FEC configuration for Fortville
25G")
Signed-off-by: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
---
v2: Fixed fixes tag
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index fe5befa..1ccf0dc 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -1409,7 +1409,8 @@ static int i40e_set_fec_cfg(struct net_device *netdev, u8 fec_cfg)
memset(&config, 0, sizeof(config));
config.phy_type = abilities.phy_type;
- config.abilities = abilities.abilities;
+ config.abilities = abilities.abilities |
+ I40E_AQ_PHY_ENABLE_ATOMIC_LINK;
config.phy_type_ext = abilities.phy_type_ext;
config.link_speed = abilities.link_speed;
config.eee_capability = abilities.eee_capability;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation after FEC modified
2021-04-13 14:19 [Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation after FEC modified Mateusz Palczewski
@ 2021-04-14 21:36 ` Nguyen, Anthony L
2021-05-03 20:51 ` Switzer, David
1 sibling, 0 replies; 3+ messages in thread
From: Nguyen, Anthony L @ 2021-04-14 21:36 UTC (permalink / raw
To: intel-wired-lan
On Tue, 2021-04-13 at 14:19 +0000, Mateusz Palczewski wrote:
> From: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
>
> When FEC mode was changed the link didn't know it because
> the link was not reset and new parameters were not negotiated.
> Set a flag 'I40E_AQ_PHY_ENABLE_ATOMIC_LINK' in 'abilities'
> to restart the link and make it run with the new settings.
>
> Fixes: 1d96340196f1 ("i40e: Add support FEC configuration for
> Fortville
> 25G")
I've fixed this up but please note that the tag should not be wrapped.
"Do not split the tag across multiple lines, tags are exempt from the
wrap at 75 columns rule in order to simplify parsing scripts."
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> Signed-off-by: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation after FEC modified
2021-04-13 14:19 [Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation after FEC modified Mateusz Palczewski
2021-04-14 21:36 ` Nguyen, Anthony L
@ 2021-05-03 20:51 ` Switzer, David
1 sibling, 0 replies; 3+ messages in thread
From: Switzer, David @ 2021-05-03 20:51 UTC (permalink / raw
To: intel-wired-lan
>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Mateusz Palczewski
>Sent: Tuesday, April 13, 2021 7:20 AM
To: intel-wired-lan@lists.osuosl.org
>Cc: Gawin, JaroslawX <jaroslawx.gawin@intel.com>; Palczewski, Mateusz
><mateusz.palczewski@intel.com>
>Subject: [Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation
>after FEC modified
>
>From: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
>
>When FEC mode was changed the link didn't know it because the link was not
>reset and new parameters were not negotiated.
>Set a flag 'I40E_AQ_PHY_ENABLE_ATOMIC_LINK' in 'abilities'
>to restart the link and make it run with the new settings.
>
>Fixes: 1d96340196f1 ("i40e: Add support FEC configuration for Fortville
>25G")
>Signed-off-by: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
>Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
>---
> v2: Fixed fixes tag
>---
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Tested-by: Dave Switzer <david.switzer@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-03 20:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-13 14:19 [Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation after FEC modified Mateusz Palczewski
2021-04-14 21:36 ` Nguyen, Anthony L
2021-05-03 20:51 ` Switzer, David
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.