From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Raslan Darawsheh <rasland@nvidia.com>, dev@dpdk.org
Cc: ferruh.yigit@intel.com, orika@nvidia.com,
ivan.malov@oktetlabs.ru, ying.a.wang@intel.com,
olivier.matz@6wind.com, viacheslavo@nvidia.com,
shirik@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v5 1/1] ethdev: add new ext hdr for gtp psc
Date: Tue, 8 Jun 2021 15:18:51 +0300 [thread overview]
Message-ID: <4b981945-6d75-5973-ff9f-fc304c78af4d@oktetlabs.ru> (raw)
In-Reply-To: <06b20c7f-60cf-dbbc-acfb-18f2629476a8@oktetlabs.ru>
On 6/8/21 3:17 PM, Andrew Rybchenko wrote:
> On 4/29/21 11:10 AM, Raslan Darawsheh wrote:
>> Define new rte header for gtp PDU session container
>> based on RFC 38415-g30
>>
>> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
>> ---
>> lib/net/rte_gtp.h | 78 +++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 78 insertions(+)
>>
>> diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h
>> index 6a6f9b238d..5a850a26e4 100644
>> --- a/lib/net/rte_gtp.h
>> +++ b/lib/net/rte_gtp.h
>> @@ -61,6 +61,84 @@ struct rte_gtp_hdr_ext_word {
>> uint8_t next_ext; /**< Next Extension Header Type. */
>> } __rte_packed;
>>
>> +/**
>> + * Optional extension for GTP with next_ext set to 0x85
>> + * defined based on RFC 38415-g30.
>> + */
>> +__extension__
>> +struct rte_gtp_psc_generic_hdr {
>> + uint8_t ext_hdr_len; /**< PDU ext hdr len in multiples of 4 bytes */
>> +#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
>> + uint8_t type:4; /**< PDU type */
>> + uint8_t qmp:1; /**< Qos Monitoring Packet */
>> + uint8_t pad:3; /**< type specfic pad bits */
>> + uint8_t spare:2; /**< type specific spare bits */
>> + uint8_t qfi:6; /**< Qos Flow Identifier */
>> +#else
>> + uint8_t qfi:6; /**< Qos Flow Identifier */
>> + uint8_t spare:2; /**< type specific spare bits */
>> + uint8_t pad:3; /**< type specfic pad bits */
>> + uint8_t qmp:1; /**< Qos Monitoring Packet */
>> + uint8_t type:4; /**< PDU type */
>> +#endif
>> + uint8_t data[0]; /**< variable length data feilds */
>> +} __rte_packed;
>> +
>> +/**
>> + * Optional extension for GTP with next_ext set to 0x85
>> + * type0 defined based on RFC 38415-g30
>> + */
>> +__extension__
>> +struct rte_gtp_psc_type0_hdr {
>> + uint8_t ext_hdr_len; /**< PDU ext hdr len in multiples of 4 bytes */
>> +#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
>> + uint8_t type:4; /**< PDU type */
>> + uint8_t qmp:1; /**< Qos Monitoring Packet */
>> + uint8_t snp:1; /**< Sequence number presence */
>> + uint8_t spare_dl1:2; /**< spare down link bits */
>> + uint8_t ppp:1; /**< Paging policy presence */
>> + uint8_t rqi:1; /**< Reflective Qos Indicator */
>> + uint8_t qfi:6; /**< Qos Flow Identifier */
>> +#else
>> + uint8_t qfi:6; /**< Qos Flow Identifier */
>> + uint8_t rqi:1; /**< Reflective Qos Indicator */
>> + uint8_t ppp:1; /**< Paging policy presence */
>> + uint8_t spare_dl1:2; /**< spare down link bits */
>> + uint8_t snp:1; /**< Sequence number presence */
>> + uint8_t type:4; /**< PDU type */
>> +#endif
>> + uint8_t data[0]; /**< variable length data feilds */
>> +} __rte_packed;
>> +
>> +/**
>> + * Optional extension for GTP with next_ext set to 0x85
>> + * type1 defined based on RFC 38415-g30
>> + */
>> +__extension__
>> +struct rte_gtp_psc_type1_hdr {
>> + uint8_t ext_hdr_len; /**< PDU ext hdr len in multiples of 4 bytes */
>> +#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
>> + uint8_t type:4; /**< PDU type */
>> + uint8_t qmp:1; /**< Qos Monitoring Packet */
>> + uint8_t dl_delay_ind:1; /**< dl delay result presence */
>> + uint8_t ul_delay_ind:1; /**< ul delay result presence */
>> + uint8_t snp:1; /**< Sequence number presence ul */
>> + uint8_t n_delay_ind:1; /**< N3/N9 delay result presence */
>> + uint8_t spare_ul2:1; /**< spare up link bits */
>> + uint8_t qfi:6; /**< Qos Flow Identifier */
>> +#else
>> + uint8_t qfi:6; /**< Qos Flow Identifier */
>> + uint8_t spare_ul2:1; /**< spare up link bits */
>> + uint8_t n_delay_ind:1; /**< N3/N9 delay result presence */
>> + uint8_t snp:1; /**< Sequence number presence ul */
>> + uint8_t ul_delay_ind:1; /**< ul delay result presence */
>> + uint8_t dl_delay_ind:1; /**< dl delay result presence */
>> + uint8_t qmp:1; /**< Qos Monitoring Packet */
>> + uint8_t type:4; /**< PDU type */
>> +#endif
>> + uint8_t data[0]; /**< variable length data feilds */
>> +} __rte_packed;
>> +
>> /** GTP header length */
>> #define RTE_ETHER_GTP_HLEN \
>> (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr))
>>
>
> This way the structure is very hard to read.
> May I ask to indent field comments as it is done in
> other rte_net structures (e.g. rte_ipv4_hdr, rte_udp_hdr,
> rte_geneve_hdr). Personally I don't care if it will be
> indent by TABs or spaces, however, it looks like TABs are
> used in more places.
>
Also there are spelling bugs [1].
[1] http://mails.dpdk.org/archives/test-report/2021-April/191649.html
next prev parent reply other threads:[~2021-06-08 12:18 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 12:11 [dpdk-dev] [PATCH] ethdev: update qfi definition Raslan Darawsheh
2021-03-26 13:12 ` Ferruh Yigit
2021-03-29 8:53 ` Ori Kam
2021-03-29 9:06 ` Raslan Darawsheh
2021-03-29 11:14 ` Ferruh Yigit
2021-03-30 7:50 ` [dpdk-dev] [PATCH v2 0/2] fix gtp psc qfi support Raslan Darawsheh
2021-03-30 7:50 ` [dpdk-dev] [PATCH v2 1/2] ethdev: add new ext hdr for gtp psc Raslan Darawsheh
2021-03-30 8:00 ` [dpdk-dev] [PATCH v3 0/2] fix gtp psc qfi support Raslan Darawsheh
2021-03-30 8:00 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add new ext hdr for gtp psc Raslan Darawsheh
2021-04-01 16:51 ` Ferruh Yigit
2021-04-04 7:17 ` Raslan Darawsheh
2021-03-30 8:00 ` [dpdk-dev] [PATCH v3 2/2] ethdev: update qfi definition Raslan Darawsheh
2021-04-01 16:54 ` Ferruh Yigit
2021-04-04 7:18 ` Raslan Darawsheh
2021-04-04 7:45 ` [dpdk-dev] [PATCH v4 0/2] fix gtp psc qfi support Raslan Darawsheh
2021-04-04 7:45 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add new ext hdr for gtp psc Raslan Darawsheh
2021-04-08 12:29 ` Olivier Matz
2021-04-08 12:37 ` Raslan Darawsheh
2021-04-08 14:10 ` Ferruh Yigit
2021-04-08 14:10 ` Olivier Matz
2021-04-13 7:45 ` Raslan Darawsheh
2021-04-29 16:29 ` Tyler Retzlaff
2021-06-08 12:13 ` Andrew Rybchenko
2021-04-04 7:45 ` [dpdk-dev] [PATCH v4 2/2] ethdev: update qfi definition Raslan Darawsheh
2021-04-06 16:09 ` Ferruh Yigit
2021-04-13 8:14 ` Raslan Darawsheh
2021-04-13 9:24 ` Ori Kam
2021-04-14 12:16 ` Ferruh Yigit
2021-04-15 6:33 ` Raslan Darawsheh
2021-04-29 8:10 ` [dpdk-dev] [PATCH v5 0/1] add new hdr for gtp qfi Raslan Darawsheh
2021-04-29 8:10 ` [dpdk-dev] [PATCH v5 1/1] ethdev: add new ext hdr for gtp psc Raslan Darawsheh
2021-05-11 11:46 ` Ferruh Yigit
2021-06-08 12:17 ` Andrew Rybchenko
2021-06-08 12:18 ` Andrew Rybchenko [this message]
2021-06-08 14:07 ` Raslan Darawsheh
2021-03-30 7:50 ` [dpdk-dev] [PATCH v2 2/2] ethdev: update qfi definition Raslan Darawsheh
2021-04-14 12:40 ` [dpdk-dev] [PATCH] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b981945-6d75-5973-ff9f-fc304c78af4d@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=shirik@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=ying.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.