From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEBADC4320A for ; Wed, 4 Aug 2021 05:03:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9494460F35 for ; Wed, 4 Aug 2021 05:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235100AbhHDFDU (ORCPT ); Wed, 4 Aug 2021 01:03:20 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:12443 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbhHDFDS (ORCPT ); Wed, 4 Aug 2021 01:03:18 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Gfffm4sVzzcfZ0; Wed, 4 Aug 2021 12:59:28 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 4 Aug 2021 13:03:02 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 4 Aug 2021 13:03:01 +0800 Subject: Re: [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed() To: Palmer Dabbelt CC: , , , Greg KH , , , , , , References: From: Kefeng Wang Message-ID: <4c0ec8b2-6b9c-d8da-dd84-29937c968636@huawei.com> Date: Wed, 4 Aug 2021 13:03:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/4 8:20, Palmer Dabbelt wrote: > On Fri, 30 Jul 2021 00:04:05 PDT (-0700), wangkefeng.wang@huawei.com > wrote: >> >> On 2021/7/30 14:49, Liang Wang wrote: >>> The physical address may exceed 32 bits on ARM(when ARM_LPAE enabled), >>> use PFN_PHYS() in devmem_is_allowed(), or the physical address may >>> overflow and be truncated. >>> >>> This bug was initially introduced from v2.6.37, and the function was >>> moved >>> to lib when v5.10. >>> >>> Fixes: 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by >>> disabling access to RAM via /dev/mem") >>> Fixes: 527701eda5f1 ("lib: Add a generic version of >>> devmem_is_allowed()") >>> Cc: stable@vger.kernel.org # v2.6.37 >>> Signed-off-by: Liang Wang >> Reviewed-by: Kefeng Wang >>> --- >>> v2: update subject and changelog >>>   lib/devmem_is_allowed.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) ... > Acked-by: Palmer Dabbelt > > I only see the reply so I'm assuming this is going in through some > other tree, but LMK if you want it via the RISC-V tree as IIRC we're > using it too. Hi Palmer,  there is a v3 with changelog updated, https://lore.kernel.org/lkml/20210731025057.78825-1-wangliang101@huawei.com/ > > Thanks! > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AACC4338F for ; Wed, 4 Aug 2021 05:04:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD46D60725 for ; Wed, 4 Aug 2021 05:04:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CD46D60725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yBOGn4OindvYqnjcgLwukWKl21I9mOleH4pM/FJUl2E=; b=GlZjEU/78Xcien/DXA29APCmVI jhj+W/SHe1EasOJASJlAF0Wt2cKYIakI0lvYmG+jg4mDHQPUh9PPboC6W4ivIu/dCdZeEmVAPaciC EwR1wj2VdZFrXL51DgYLcmpBt047kcQe2tK88cQw0rNqDfmBKwVmTQ7KxLknVWaR7sdLn0J/z0StG IxIpUcxOfaiujjZ9fDgG1GpI5y7RqCvZHOvjH9T0e/bvRmQ5REkCxjZxKT13sEgIFRWCLJL5VnC4r bh5KnzR58VK1FM7tqk1J0qYjMCi7siD50nfqz0au4owrr75JB05raCEBYUWxRXx7JL0WYnRYp1bkz jGNsbMqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mB93e-004qXH-Mo; Wed, 04 Aug 2021 05:03:10 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mB93Z-004qVu-N5 for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 05:03:07 +0000 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Gfffm4sVzzcfZ0; Wed, 4 Aug 2021 12:59:28 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 4 Aug 2021 13:03:02 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 4 Aug 2021 13:03:01 +0800 Subject: Re: [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed() To: Palmer Dabbelt CC: , , , Greg KH , , , , , , References: From: Kefeng Wang Message-ID: <4c0ec8b2-6b9c-d8da-dd84-29937c968636@huawei.com> Date: Wed, 4 Aug 2021 13:03:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210803_220306_057389_7EE0F16D X-CRM114-Status: GOOD ( 14.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjEvOC80IDg6MjAsIFBhbG1lciBEYWJiZWx0IHdyb3RlOgo+IE9uIEZyaSwgMzAgSnVs IDIwMjEgMDA6MDQ6MDUgUERUICgtMDcwMCksIHdhbmdrZWZlbmcud2FuZ0BodWF3ZWkuY29tIAo+ IHdyb3RlOgo+Pgo+PiBPbiAyMDIxLzcvMzAgMTQ6NDksIExpYW5nIFdhbmcgd3JvdGU6Cj4+PiBU aGUgcGh5c2ljYWwgYWRkcmVzcyBtYXkgZXhjZWVkIDMyIGJpdHMgb24gQVJNKHdoZW4gQVJNX0xQ QUUgZW5hYmxlZCksCj4+PiB1c2UgUEZOX1BIWVMoKSBpbiBkZXZtZW1faXNfYWxsb3dlZCgpLCBv ciB0aGUgcGh5c2ljYWwgYWRkcmVzcyBtYXkKPj4+IG92ZXJmbG93IGFuZCBiZSB0cnVuY2F0ZWQu Cj4+Pgo+Pj4gVGhpcyBidWcgd2FzIGluaXRpYWxseSBpbnRyb2R1Y2VkIGZyb20gdjIuNi4zNywg YW5kIHRoZSBmdW5jdGlvbiB3YXMgCj4+PiBtb3ZlZAo+Pj4gdG8gbGliIHdoZW4gdjUuMTAuCj4+ Pgo+Pj4gRml4ZXM6IDA4N2FhZmZjZGY5YyAoIkFSTTogaW1wbGVtZW50IENPTkZJR19TVFJJQ1Rf REVWTUVNIGJ5IAo+Pj4gZGlzYWJsaW5nIGFjY2VzcyB0byBSQU0gdmlhIC9kZXYvbWVtIikKPj4+ IEZpeGVzOiA1Mjc3MDFlZGE1ZjEgKCJsaWI6IEFkZCBhIGdlbmVyaWMgdmVyc2lvbiBvZiAKPj4+ IGRldm1lbV9pc19hbGxvd2VkKCkiKQo+Pj4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcgIyB2 Mi42LjM3Cj4+PiBTaWduZWQtb2ZmLWJ5OiBMaWFuZyBXYW5nIDx3YW5nbGlhbmcxMDFAaHVhd2Vp LmNvbT4KPj4gUmV2aWV3ZWQtYnk6IEtlZmVuZyBXYW5nIDx3YW5na2VmZW5nLndhbmdAaHVhd2Vp LmNvbT4KPj4+IC0tLQo+Pj4gdjI6IHVwZGF0ZSBzdWJqZWN0IGFuZCBjaGFuZ2Vsb2cKPj4+IMKg IGxpYi9kZXZtZW1faXNfYWxsb3dlZC5jIHwgMiArLQo+Pj4gwqAgMSBmaWxlIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCi4uLgo+IEFja2VkLWJ5OiBQYWxtZXIgRGFiYmVs dCA8cGFsbWVyZGFiYmVsdEBnb29nbGUuY29tPgo+Cj4gSSBvbmx5IHNlZSB0aGUgcmVwbHkgc28g SSdtIGFzc3VtaW5nIHRoaXMgaXMgZ29pbmcgaW4gdGhyb3VnaCBzb21lIAo+IG90aGVyIHRyZWUs IGJ1dCBMTUsgaWYgeW91IHdhbnQgaXQgdmlhIHRoZSBSSVNDLVYgdHJlZSBhcyBJSVJDIHdlJ3Jl IAo+IHVzaW5nIGl0IHRvby4KCkhpIFBhbG1lcizCoCB0aGVyZSBpcyBhIHYzIHdpdGggY2hhbmdl bG9nIHVwZGF0ZWQsCgpodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMjEwNzMxMDI1MDU3 Ljc4ODI1LTEtd2FuZ2xpYW5nMTAxQGh1YXdlaS5jb20vCgoKPgo+IFRoYW5rcyEKPiAuCj4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK