* [PATCH] cpufreq: amd-pstate: fix code format problems
@ 2024-04-27 13:52 Perry Yuan
2024-04-27 14:30 ` Mario Limonciello
0 siblings, 1 reply; 2+ messages in thread
From: Perry Yuan @ 2024-04-27 13:52 UTC (permalink / raw
To: rafael.j.wysocki, Mario.Limonciello, viresh.kumar, gautham.shenoy,
Borislav.Petkov, Ray.Huang, Alexander.Deucher
Cc: Xinmei.Huang, oleksandr, Xiaojian.Du, Li.Meng, linux-pm,
linux-kernel
get some code format problems fixed in the amd-pstate driver.
Changes Made:
- Fixed incorrect comment format in the functions.
- Removed unnecessary blank line.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404271148.HK9yHBlB-lkp@intel.com/
Signed-off-by: Perry Yuan <perry.yuan@amd.com>
---
drivers/cpufreq/amd-pstate.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 83a29b257794..85656342a101 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -792,7 +792,7 @@ static void amd_pstate_update_limits(unsigned int cpu)
mutex_unlock(&amd_pstate_driver_lock);
}
-/**
+/*
* Get pstate transition delay time from ACPI tables that firmware set
* instead of using hardcode value directly.
*/
@@ -807,7 +807,7 @@ static u32 amd_pstate_get_transition_delay_us(unsigned int cpu)
return transition_delay_ns / NSEC_PER_USEC;
}
-/**
+/*
* Get pstate transition latency value from ACPI tables that firmware
* set instead of using hardcode value directly.
*/
@@ -822,7 +822,7 @@ static u32 amd_pstate_get_transition_latency(unsigned int cpu)
return transition_latency;
}
-/**
+/*
* amd_pstate_init_freq: Initialize the max_freq, min_freq,
* nominal_freq and lowest_nonlinear_freq for
* the @cpudata object.
@@ -843,7 +843,6 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata)
u32 boost_ratio, lowest_nonlinear_ratio;
struct cppc_perf_caps cppc_perf;
-
ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf);
if (ret)
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: amd-pstate: fix code format problems
2024-04-27 13:52 [PATCH] cpufreq: amd-pstate: fix code format problems Perry Yuan
@ 2024-04-27 14:30 ` Mario Limonciello
0 siblings, 0 replies; 2+ messages in thread
From: Mario Limonciello @ 2024-04-27 14:30 UTC (permalink / raw
To: Perry Yuan, rafael.j.wysocki, viresh.kumar, gautham.shenoy,
Borislav.Petkov, Ray.Huang, Alexander.Deucher
Cc: Xinmei.Huang, oleksandr, Xiaojian.Du, Li.Meng, linux-pm,
linux-kernel
On 4/27/2024 08:52, Perry Yuan wrote:
> get some code format problems fixed in the amd-pstate driver.
>
> Changes Made:
>
> - Fixed incorrect comment format in the functions.
>
> - Removed unnecessary blank line.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404271148.HK9yHBlB-lkp@intel.com/
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> drivers/cpufreq/amd-pstate.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 83a29b257794..85656342a101 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -792,7 +792,7 @@ static void amd_pstate_update_limits(unsigned int cpu)
> mutex_unlock(&amd_pstate_driver_lock);
> }
>
> -/**
> +/*
> * Get pstate transition delay time from ACPI tables that firmware set
> * instead of using hardcode value directly.
> */
> @@ -807,7 +807,7 @@ static u32 amd_pstate_get_transition_delay_us(unsigned int cpu)
> return transition_delay_ns / NSEC_PER_USEC;
> }
>
> -/**
> +/*
> * Get pstate transition latency value from ACPI tables that firmware
> * set instead of using hardcode value directly.
> */
> @@ -822,7 +822,7 @@ static u32 amd_pstate_get_transition_latency(unsigned int cpu)
> return transition_latency;
> }
>
> -/**
> +/*
> * amd_pstate_init_freq: Initialize the max_freq, min_freq,
> * nominal_freq and lowest_nonlinear_freq for
> * the @cpudata object.
> @@ -843,7 +843,6 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata)
> u32 boost_ratio, lowest_nonlinear_ratio;
> struct cppc_perf_caps cppc_perf;
>
> -
> ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf);
> if (ret)
> return ret;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-27 14:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-27 13:52 [PATCH] cpufreq: amd-pstate: fix code format problems Perry Yuan
2024-04-27 14:30 ` Mario Limonciello
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.