Re: [PATCH v3 0/2] xfstest btrfs/316: test send / receive

From: Eric Sandeen <sandeen@redhat.com>
To: Jan Schmidt <list.xfs@jan-o-sch.net>
Cc: sbehrens@giantdisaster.de, linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v3 0/2] xfstest btrfs/316: test send / receive
Date: Thu, 08 Aug 2013 12:34:55 -0500	[thread overview]
Message-ID: <5203D6BF.4040201@redhat.com> (raw)
In-Reply-To: <1375949833-1104-1-git-send-email-list.xfs@jan-o-sch.net>

On 8/8/13 3:17 AM, Jan Schmidt wrote:
> These two patches add the announced tests for btrfs send / receive. As
> requested, the fssum tool is now included.
> 
> One drawback is that I'm unable to edit configure.ac or whatever needs
> to be modified in an autotools preferred way. Any hints appreciated,
> preferrably hints containing all the modifications required to introduce
> something like HAVE_SEEK_HOLE.

Other tests in the tree just add:

#ifndef SEEK_DATA
#define SEEK_DATA       3
#define SEEK_HOLE       4
#endif

> I do not want to make modifications to fssum.c here, if that's
> absolutely required (because one /could/ get along using linux/fs.h,
> which is not the way I would like to go), I'd like to have that changed
> in the far-progs repository where fssum.c comes from as well.

Well, unfortunately it breaks the build w/o some change or other,
on older distros:

Building src
    [CC]    fssum
fssum.c: In function 'sum_file_data_permissive':
fssum.c:243: error: 'SEEK_DATA' undeclared (first use in this function)

so this can't be merged as-is.

Adding the 4 lines above to the xfstests copy seems like a pretty obvious fix
to get the tool building and move this along.

Then, to simply skip this test if the kernel we're running on doesn't grok
SEEK_DATA, add:

_require_seek_data_hole

to your new test in patch 2.

Thanks,
-Eric

> --
> v1->v2:
>  - included fssum
>  - test number is now 316 (was 314)
> v2->v3:
>  - added missing -lcrypto to build fssum
>  - removed obsolete change in README now that fssum is included
>  - fixed comment in test/btrfs/316's header (314 -> 316)
> 
> Jan Schmidt (2):
>   xfstests: add fssum tool
>   xfstests btrfs/316: test send / receive
> 
>  .gitignore          |    1 +
>  common/config       |    2 +
>  src/Makefile        |   11 +-
>  src/fssum.c         |  819 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/btrfs/316     |  113 +++++++
>  tests/btrfs/316.out |    4 +
>  tests/btrfs/group   |    1 +
>  7 files changed, 950 insertions(+), 1 deletions(-)
>  create mode 100644 src/fssum.c
>  create mode 100755 tests/btrfs/316
>  create mode 100644 tests/btrfs/316.out
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs