* [PATCH] mime,mime-xdg: Conflict with allarch
@ 2020-02-25 5:44 Khem Raj
2020-02-25 10:21 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2020-02-25 5:44 UTC (permalink / raw
To: openembedded-core
mime and mime-xdb classes add dependencies ( both runtime and buildtime
) on target packages, therefore recipes using allarch should not inherit
mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches
[YOCTO #13805]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Andreas Müller <schnitzeltony@gmail.com>
---
meta/classes/mime-xdg.bbclass | 5 +++++
meta/classes/mime.bbclass | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/meta/classes/mime-xdg.bbclass b/meta/classes/mime-xdg.bbclass
index 63169e990d..c175291814 100644
--- a/meta/classes/mime-xdg.bbclass
+++ b/meta/classes/mime-xdg.bbclass
@@ -14,6 +14,11 @@ DESKTOPDIR = "${datadir}/applications"
# skipped for MIME_XDG_PACKAGES not empty
MIME_XDG_PACKAGES ?= ""
+python __anonymous() {
+ if bb.data.inherits_class('allarch', d):
+ bb.fatal("allarch and mime-xdg can not be inherited together")
+}
+
mime_xdg_postinst() {
if [ "x$D" != "x" ]; then
$INTERCEPT_DIR/postinst_intercept update_desktop_database ${PKG} \
diff --git a/meta/classes/mime.bbclass b/meta/classes/mime.bbclass
index c9072adf3b..f4ccac7bd4 100644
--- a/meta/classes/mime.bbclass
+++ b/meta/classes/mime.bbclass
@@ -6,6 +6,11 @@ DEPENDS += "${@bb.utils.contains('BPN', 'shared-mime-info', '', 'shared-mime-inf
PACKAGE_WRITE_DEPS += "shared-mime-info-native"
MIMEDIR = "${datadir}/mime"
+python __anonymous() {
+ if bb.data.inherits_class('allarch', d):
+ bb.fatal("allarch and mime can not be inherited together")
+}
+
mime_postinst() {
if [ "x$D" != "x" ]; then
$INTERCEPT_DIR/postinst_intercept update_mime_database ${PKG} \
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mime,mime-xdg: Conflict with allarch
2020-02-25 5:44 [PATCH] mime,mime-xdg: Conflict with allarch Khem Raj
@ 2020-02-25 10:21 ` Richard Purdie
2020-02-25 12:24 ` Andreas Müller
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2020-02-25 10:21 UTC (permalink / raw
To: Khem Raj, openembedded-core
On Mon, 2020-02-24 at 21:44 -0800, Khem Raj wrote:
> mime and mime-xdb classes add dependencies ( both runtime and
> buildtime
> ) on target packages, therefore recipes using allarch should not
> inherit
> mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches
>
> [YOCTO #13805]
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Andreas Müller <schnitzeltony@gmail.com>
> ---
> meta/classes/mime-xdg.bbclass | 5 +++++
> meta/classes/mime.bbclass | 5 +++++
> 2 files changed, 10 insertions(+)
Is this the right way to fix this? mime info probably is arch
independent, so should we be whitelisting some of the dependencies?
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mime,mime-xdg: Conflict with allarch
2020-02-25 10:21 ` Richard Purdie
@ 2020-02-25 12:24 ` Andreas Müller
2020-02-25 14:07 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Müller @ 2020-02-25 12:24 UTC (permalink / raw
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
On Tue, Feb 25, 2020 at 11:21 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Mon, 2020-02-24 at 21:44 -0800, Khem Raj wrote:
> > mime and mime-xdb classes add dependencies ( both runtime and
> > buildtime
> > ) on target packages, therefore recipes using allarch should not
> > inherit
> > mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches
> >
> > [YOCTO #13805]
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > Cc: Andreas Müller <schnitzeltony@gmail.com>
> > ---
> > meta/classes/mime-xdg.bbclass | 5 +++++
> > meta/classes/mime.bbclass | 5 +++++
> > 2 files changed, 10 insertions(+)
>
> Is this the right way to fix this? mime info probably is arch
> independent, so should we be whitelisting some of the dependencies?
>
> Cheers,
>
> Richard
>
Khem and I had a short discussion about this [1]. His first approach
was to remove DEPENDS. As far as I remember the deps were added to
avoid QA warning.
Honestly I never understood why these are spawned. If there is a fix /
workaround this could be reduced to rdeps which an be handled for
allarch.
[1] https://github.com/YoeDistro/openembedded-core/commit/5605a9cf78c3731e2cc055cd4f8cc88a0b3d7e26
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mime,mime-xdg: Conflict with allarch
2020-02-25 12:24 ` Andreas Müller
@ 2020-02-25 14:07 ` Richard Purdie
2020-02-25 15:11 ` Andreas Müller
2020-02-25 16:33 ` Khem Raj
0 siblings, 2 replies; 6+ messages in thread
From: Richard Purdie @ 2020-02-25 14:07 UTC (permalink / raw
To: Andreas Müller; +Cc: Patches and discussions about the oe-core layer
On Tue, 2020-02-25 at 13:24 +0100, Andreas Müller wrote:
> On Tue, Feb 25, 2020 at 11:21 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Mon, 2020-02-24 at 21:44 -0800, Khem Raj wrote:
> > > mime and mime-xdb classes add dependencies ( both runtime and
> > > buildtime
> > > ) on target packages, therefore recipes using allarch should not
> > > inherit
> > > mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches
> > >
> > > [YOCTO #13805]
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > Cc: Andreas Müller <schnitzeltony@gmail.com>
> > > ---
> > > meta/classes/mime-xdg.bbclass | 5 +++++
> > > meta/classes/mime.bbclass | 5 +++++
> > > 2 files changed, 10 insertions(+)
> >
> > Is this the right way to fix this? mime info probably is arch
> > independent, so should we be whitelisting some of the dependencies?
> >
> > Cheers,
> >
> > Richard
> >
> Khem and I had a short discussion about this [1]. His first approach
> was to remove DEPENDS. As far as I remember the deps were added to
> avoid QA warning.
>
> Honestly I never understood why these are spawned. If there is a fix /
> workaround this could be reduced to rdeps which an be handled for
> allarch.
>
> [1] https://github.com/YoeDistro/openembedded-core/commit/5605a9cf78c3731e2cc055cd4f8cc88a0b3d7e26
I'd guess something like:
SIGGEN_EXCLUDERECIPES_ABISAFE += "\
shared-mime-info \
desktop-file-utils \
"
in layer.conf might be the correct fix. The other approach is just a
workaround.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mime,mime-xdg: Conflict with allarch
2020-02-25 14:07 ` Richard Purdie
@ 2020-02-25 15:11 ` Andreas Müller
2020-02-25 16:33 ` Khem Raj
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Müller @ 2020-02-25 15:11 UTC (permalink / raw
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
On Tue, Feb 25, 2020 at 3:07 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Tue, 2020-02-25 at 13:24 +0100, Andreas Müller wrote:
> > On Tue, Feb 25, 2020 at 11:21 AM Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > > On Mon, 2020-02-24 at 21:44 -0800, Khem Raj wrote:
> > > > mime and mime-xdb classes add dependencies ( both runtime and
> > > > buildtime
> > > > ) on target packages, therefore recipes using allarch should not
> > > > inherit
> > > > mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches
> > > >
> > > > [YOCTO #13805]
> > > >
> > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > Cc: Andreas Müller <schnitzeltony@gmail.com>
> > > > ---
> > > > meta/classes/mime-xdg.bbclass | 5 +++++
> > > > meta/classes/mime.bbclass | 5 +++++
> > > > 2 files changed, 10 insertions(+)
> > >
> > > Is this the right way to fix this? mime info probably is arch
> > > independent, so should we be whitelisting some of the dependencies?
> > >
> > > Cheers,
> > >
> > > Richard
> > >
> > Khem and I had a short discussion about this [1]. His first approach
> > was to remove DEPENDS. As far as I remember the deps were added to
> > avoid QA warning.
> >
> > Honestly I never understood why these are spawned. If there is a fix /
> > workaround this could be reduced to rdeps which an be handled for
> > allarch.
> >
> > [1] https://github.com/YoeDistro/openembedded-core/commit/5605a9cf78c3731e2cc055cd4f8cc88a0b3d7e26
>
> I'd guess something like:
>
> SIGGEN_EXCLUDERECIPES_ABISAFE += "\
> shared-mime-info \
> desktop-file-utils \
> "
>
> in layer.conf might be the correct fix. The other approach is just a
> workaround.
That would fix rdeps allarch -> cross only - right?. How to get rid of
the deps warning? @Khem: Do you have some logs showing what warning it
was exactly?
Andreas
>
> Cheers,
>
> Richard
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mime,mime-xdg: Conflict with allarch
2020-02-25 14:07 ` Richard Purdie
2020-02-25 15:11 ` Andreas Müller
@ 2020-02-25 16:33 ` Khem Raj
1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2020-02-25 16:33 UTC (permalink / raw
To: Richard Purdie, Andreas Müller
Cc: Patches and discussions about the oe-core layer
On 2/25/20 6:07 AM, Richard Purdie wrote:
> On Tue, 2020-02-25 at 13:24 +0100, Andreas Müller wrote:
>> On Tue, Feb 25, 2020 at 11:21 AM Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>>> On Mon, 2020-02-24 at 21:44 -0800, Khem Raj wrote:
>>>> mime and mime-xdb classes add dependencies ( both runtime and
>>>> buildtime
>>>> ) on target packages, therefore recipes using allarch should not
>>>> inherit
>>>> mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches
>>>>
>>>> [YOCTO #13805]
>>>>
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> Cc: Andreas Müller <schnitzeltony@gmail.com>
>>>> ---
>>>> meta/classes/mime-xdg.bbclass | 5 +++++
>>>> meta/classes/mime.bbclass | 5 +++++
>>>> 2 files changed, 10 insertions(+)
>>>
>>> Is this the right way to fix this? mime info probably is arch
>>> independent, so should we be whitelisting some of the dependencies?
>>>
>>> Cheers,
>>>
>>> Richard
>>>
>> Khem and I had a short discussion about this [1]. His first approach
>> was to remove DEPENDS. As far as I remember the deps were added to
>> avoid QA warning.
>>
>> Honestly I never understood why these are spawned. If there is a fix /
>> workaround this could be reduced to rdeps which an be handled for
>> allarch.
>>
>> [1] https://github.com/YoeDistro/openembedded-core/commit/5605a9cf78c3731e2cc055cd4f8cc88a0b3d7e26
>
> I'd guess something like:
>
> SIGGEN_EXCLUDERECIPES_ABISAFE += "\
> shared-mime-info \
> desktop-file-utils \
> "
>
> in layer.conf might be the correct fix. The other approach is just a
> workaround.
yeah, I am testing something like this.
>
> Cheers,
>
> Richard
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-25 16:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-25 5:44 [PATCH] mime,mime-xdg: Conflict with allarch Khem Raj
2020-02-25 10:21 ` Richard Purdie
2020-02-25 12:24 ` Andreas Müller
2020-02-25 14:07 ` Richard Purdie
2020-02-25 15:11 ` Andreas Müller
2020-02-25 16:33 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.