* [PATCHv3]Checks for Null value in function *get_skub
@ 2014-06-16 15:08 ` Nicholas Krause
0 siblings, 0 replies; 9+ messages in thread
From: Nicholas Krause @ 2014-06-16 15:08 UTC (permalink / raw
To: swise; +Cc: roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index f9477e2..2d56983 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -340,15 +340,13 @@ static int status2errno(int status)
*/
static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
{
if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
skb_trim(skb, 0);
skb_get(skb);
skb_reset_transport_header(skb);
} else {
+ if (skb)
+ kfree (skb);
skb = alloc_skb(len, gfp);
}
t4_set_arp_err_handler(skb, NULL, NULL);
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCHv3]Checks for Null value in function *get_skub
@ 2014-06-16 15:08 ` Nicholas Krause
0 siblings, 0 replies; 9+ messages in thread
From: Nicholas Krause @ 2014-06-16 15:08 UTC (permalink / raw
To: swise-ut6Up61K2wZBDgjK7y7TUQ
Cc: roland-DgEjT+Ai2ygdnm+yROfE0A, sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index f9477e2..2d56983 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -340,15 +340,13 @@ static int status2errno(int status)
*/
static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
{
if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
skb_trim(skb, 0);
skb_get(skb);
skb_reset_transport_header(skb);
} else {
+ if (skb)
+ kfree (skb);
skb = alloc_skb(len, gfp);
}
t4_set_arp_err_handler(skb, NULL, NULL);
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCHv3]Checks for Null value in function *get_skub
@ 2014-06-16 15:10 ` Nick Krause
0 siblings, 0 replies; 9+ messages in thread
From: Nick Krause @ 2014-06-16 15:10 UTC (permalink / raw
To: swise; +Cc: roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel
The bug is open here https://bugzilla.kernel.org/show_bug.cgi?id=44631.
I would recommend closing it now as I seem to have fixed it.
Cheers Nick
On Mon, Jun 16, 2014 at 11:08 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index f9477e2..2d56983 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -340,15 +340,13 @@ static int status2errno(int status)
> */
> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
> {
> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
> skb_trim(skb, 0);
> skb_get(skb);
> skb_reset_transport_header(skb);
> } else {
> + if (skb)
> + kfree (skb);
> skb = alloc_skb(len, gfp);
> }
> t4_set_arp_err_handler(skb, NULL, NULL);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv3]Checks for Null value in function *get_skub
@ 2014-06-16 15:10 ` Nick Krause
0 siblings, 0 replies; 9+ messages in thread
From: Nick Krause @ 2014-06-16 15:10 UTC (permalink / raw
To: swise-ut6Up61K2wZBDgjK7y7TUQ
Cc: roland-DgEjT+Ai2ygdnm+yROfE0A, sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
The bug is open here https://bugzilla.kernel.org/show_bug.cgi?id=44631.
I would recommend closing it now as I seem to have fixed it.
Cheers Nick
On Mon, Jun 16, 2014 at 11:08 AM, Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Signed-off-by: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index f9477e2..2d56983 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -340,15 +340,13 @@ static int status2errno(int status)
> */
> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
> {
> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
> skb_trim(skb, 0);
> skb_get(skb);
> skb_reset_transport_header(skb);
> } else {
> + if (skb)
> + kfree (skb);
> skb = alloc_skb(len, gfp);
> }
> t4_set_arp_err_handler(skb, NULL, NULL);
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv3]Checks for Null value in function *get_skub
2014-06-16 15:08 ` Nicholas Krause
(?)
(?)
@ 2014-06-16 15:12 ` Levente Kurusa
2014-06-16 15:14 ` Nick Krause
-1 siblings, 1 reply; 9+ messages in thread
From: Levente Kurusa @ 2014-06-16 15:12 UTC (permalink / raw
To: Nicholas Krause, swise
Cc: roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel
On 06/16/2014 05:08 PM, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index f9477e2..2d56983 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -340,15 +340,13 @@ static int status2errno(int status)
> */
> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
> {
> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
> skb_trim(skb, 0);
> skb_get(skb);
> skb_reset_transport_header(skb);
> } else {
> + if (skb)
> + kfree (skb);
> skb = alloc_skb(len, gfp);
> }
> t4_set_arp_err_handler(skb, NULL, NULL);
>
Isn't kfree(NULL) legal?
(i.e. the if statement is useless)
Thanks,
Levente Kurusa
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv3]Checks for Null value in function *get_skub
@ 2014-06-16 15:14 ` Nick Krause
0 siblings, 0 replies; 9+ messages in thread
From: Nick Krause @ 2014-06-16 15:14 UTC (permalink / raw
To: Levente Kurusa
Cc: swise, roland, sean.hefty, hal.rosenstock, linux-rdma,
linux-kernel
>From what I know yes so I would close the bug at the the link in
my previous email and just void my patch.
Cheers Nick
On Mon, Jun 16, 2014 at 11:12 AM, Levente Kurusa <levex@linux.com> wrote:
> On 06/16/2014 05:08 PM, Nicholas Krause wrote:
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>> drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/cxgb4/cm.c
>> b/drivers/infiniband/hw/cxgb4/cm.c
>> index f9477e2..2d56983 100644
>> --- a/drivers/infiniband/hw/cxgb4/cm.c
>> +++ b/drivers/infiniband/hw/cxgb4/cm.c
>> @@ -340,15 +340,13 @@ static int status2errno(int status)
>> */
>> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
>> {
>> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
>> skb_trim(skb, 0);
>> skb_get(skb);
>> skb_reset_transport_header(skb);
>> } else {
>> + if (skb)
>> + kfree (skb);
>> skb = alloc_skb(len, gfp);
>> }
>> t4_set_arp_err_handler(skb, NULL, NULL);
>>
>
> Isn't kfree(NULL) legal?
>
> (i.e. the if statement is useless)
>
> Thanks,
> Levente Kurusa
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv3]Checks for Null value in function *get_skub
@ 2014-06-16 15:14 ` Nick Krause
0 siblings, 0 replies; 9+ messages in thread
From: Nick Krause @ 2014-06-16 15:14 UTC (permalink / raw
To: Levente Kurusa
Cc: swise-ut6Up61K2wZBDgjK7y7TUQ, roland-DgEjT+Ai2ygdnm+yROfE0A,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
>From what I know yes so I would close the bug at the the link in
my previous email and just void my patch.
Cheers Nick
On Mon, Jun 16, 2014 at 11:12 AM, Levente Kurusa <levex-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> wrote:
> On 06/16/2014 05:08 PM, Nicholas Krause wrote:
>>
>> Signed-off-by: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>> drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/cxgb4/cm.c
>> b/drivers/infiniband/hw/cxgb4/cm.c
>> index f9477e2..2d56983 100644
>> --- a/drivers/infiniband/hw/cxgb4/cm.c
>> +++ b/drivers/infiniband/hw/cxgb4/cm.c
>> @@ -340,15 +340,13 @@ static int status2errno(int status)
>> */
>> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
>> {
>> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
>> skb_trim(skb, 0);
>> skb_get(skb);
>> skb_reset_transport_header(skb);
>> } else {
>> + if (skb)
>> + kfree (skb);
>> skb = alloc_skb(len, gfp);
>> }
>> t4_set_arp_err_handler(skb, NULL, NULL);
>>
>
> Isn't kfree(NULL) legal?
>
> (i.e. the if statement is useless)
>
> Thanks,
> Levente Kurusa
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv3]Checks for Null value in function *get_skub
@ 2014-06-16 15:18 ` Steve Wise
0 siblings, 0 replies; 9+ messages in thread
From: Steve Wise @ 2014-06-16 15:18 UTC (permalink / raw
To: Nick Krause, Levente Kurusa
Cc: swise, roland, sean.hefty, hal.rosenstock, linux-rdma,
linux-kernel
On 6/16/2014 10:14 AM, Nick Krause wrote:
> >From what I know yes so I would close the bug at the the link in
> my previous email and just void my patch.
> Cheers Nick
We shouldn't be kfree-ing an skb anyway. Should use kfree_skb().
There is still a leak if skb is non-null and the skb is non linear or
cloned.
> On Mon, Jun 16, 2014 at 11:12 AM, Levente Kurusa <levex@linux.com> wrote:
>> On 06/16/2014 05:08 PM, Nicholas Krause wrote:
>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>> ---
>>> drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
>>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/infiniband/hw/cxgb4/cm.c
>>> b/drivers/infiniband/hw/cxgb4/cm.c
>>> index f9477e2..2d56983 100644
>>> --- a/drivers/infiniband/hw/cxgb4/cm.c
>>> +++ b/drivers/infiniband/hw/cxgb4/cm.c
>>> @@ -340,15 +340,13 @@ static int status2errno(int status)
>>> */
>>> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
>>> {
>>> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
>>> skb_trim(skb, 0);
>>> skb_get(skb);
>>> skb_reset_transport_header(skb);
>>> } else {
>>> + if (skb)
>>> + kfree (skb);
>>> skb = alloc_skb(len, gfp);
>>> }
>>> t4_set_arp_err_handler(skb, NULL, NULL);
>>>
>> Isn't kfree(NULL) legal?
>>
>> (i.e. the if statement is useless)
>>
>> Thanks,
>> Levente Kurusa
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv3]Checks for Null value in function *get_skub
@ 2014-06-16 15:18 ` Steve Wise
0 siblings, 0 replies; 9+ messages in thread
From: Steve Wise @ 2014-06-16 15:18 UTC (permalink / raw
To: Nick Krause, Levente Kurusa
Cc: swise-ut6Up61K2wZBDgjK7y7TUQ, roland-DgEjT+Ai2ygdnm+yROfE0A,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 6/16/2014 10:14 AM, Nick Krause wrote:
> >From what I know yes so I would close the bug at the the link in
> my previous email and just void my patch.
> Cheers Nick
We shouldn't be kfree-ing an skb anyway. Should use kfree_skb().
There is still a leak if skb is non-null and the skb is non linear or
cloned.
> On Mon, Jun 16, 2014 at 11:12 AM, Levente Kurusa <levex-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> wrote:
>> On 06/16/2014 05:08 PM, Nicholas Krause wrote:
>>> Signed-off-by: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> ---
>>> drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
>>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/infiniband/hw/cxgb4/cm.c
>>> b/drivers/infiniband/hw/cxgb4/cm.c
>>> index f9477e2..2d56983 100644
>>> --- a/drivers/infiniband/hw/cxgb4/cm.c
>>> +++ b/drivers/infiniband/hw/cxgb4/cm.c
>>> @@ -340,15 +340,13 @@ static int status2errno(int status)
>>> */
>>> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
>>> {
>>> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
>>> skb_trim(skb, 0);
>>> skb_get(skb);
>>> skb_reset_transport_header(skb);
>>> } else {
>>> + if (skb)
>>> + kfree (skb);
>>> skb = alloc_skb(len, gfp);
>>> }
>>> t4_set_arp_err_handler(skb, NULL, NULL);
>>>
>> Isn't kfree(NULL) legal?
>>
>> (i.e. the if statement is useless)
>>
>> Thanks,
>> Levente Kurusa
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-06-16 15:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 15:08 [PATCHv3]Checks for Null value in function *get_skub Nicholas Krause
2014-06-16 15:08 ` Nicholas Krause
2014-06-16 15:10 ` Nick Krause
2014-06-16 15:10 ` Nick Krause
2014-06-16 15:12 ` Levente Kurusa
2014-06-16 15:14 ` Nick Krause
2014-06-16 15:14 ` Nick Krause
2014-06-16 15:18 ` Steve Wise
2014-06-16 15:18 ` Steve Wise
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.