From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D5AC433B4 for ; Tue, 11 May 2021 10:18:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BED9610C9 for ; Tue, 11 May 2021 10:18:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BED9610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgPTa-0005bp-9g for qemu-devel@archiver.kernel.org; Tue, 11 May 2021 06:18:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgPRP-0003hK-3V for qemu-devel@nongnu.org; Tue, 11 May 2021 06:16:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgPRN-0004X9-Hp for qemu-devel@nongnu.org; Tue, 11 May 2021 06:16:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620728196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=411Hei8yCW/9L68yDGYV+/52o2WqZoCu/aKGWTjUm/4=; b=E8YF+yjFx4NeMLCMoMr/16p8gcuzah05cbJIBECOVt7MRzgFZgoUtNea4W+kyrK1dYv0Vi hSIjJM81RN5FjFnW2E7RISUmQH38p9vDAPkwhba00zlFiHkgTb6V9H2WTVUisRocupqwaI inJwPxffk0b8vwMrFe1k+IGGYLK/erk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-6_k2wTDqMc2jW_3RkKYUQQ-1; Tue, 11 May 2021 06:16:35 -0400 X-MC-Unique: 6_k2wTDqMc2jW_3RkKYUQQ-1 Received: by mail-wm1-f72.google.com with SMTP id 7-20020a05600c2307b02901432673350dso549521wmo.9 for ; Tue, 11 May 2021 03:16:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=411Hei8yCW/9L68yDGYV+/52o2WqZoCu/aKGWTjUm/4=; b=mAYzNiDnM6qCmc5Wt+K57iqZD5mA2EEusjcO++IIE/MRWBOX6dQOkjqnQMWybwzy0x sl8oJJfhyCE2dkhTnEKYNJnKar6/Wrii3yDGQHjAD2h9PSbY86mH9G89RDq/ZJnO/JDY c0cz+WxWJkfKlHzlHjaDlOclb7ZSQqKhwuFmCjN3I8NW/0jcBEq/HBCFKplphwTDetGF g9uVeJNsGnHAQ6DrhWgzHmdISQ3m+Bx7j8gEkbWFT9QbjkQoZQ7x2GphiujZOtmm7FYX P+CFXLAU4dast8ayE6quSgvgrVhdklRrW86wdapowEqJ6l63WK7qw6toDiRTqZbcFzUB lIqg== X-Gm-Message-State: AOAM532ZU6aOE6XaEYv1blHwKdXCrchtPhDzoaMLanBGkjyNqYw3/Ito UtDDQUW1hGg3HPLnpcb6D+du472TMjTmfI3QDqLfjhlwRtZvhFc8EblOt40LWTZU1EwVFL2zpbD LksjNCklaylww2zw= X-Received: by 2002:a1c:c5:: with SMTP id 188mr32488952wma.5.1620728193926; Tue, 11 May 2021 03:16:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvt/P7WIoTej/9+AHJRKuzWuEEtX0JnEcLCaU3kzlUvS8I0wtCX6Lwr90F9D6X8tdOD/O1Rg== X-Received: by 2002:a1c:c5:: with SMTP id 188mr32488920wma.5.1620728193504; Tue, 11 May 2021 03:16:33 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6329.dip0.t-ipconnect.de. [91.12.99.41]) by smtp.gmail.com with ESMTPSA id j13sm27140384wrw.93.2021.05.11.03.16.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 03:16:33 -0700 (PDT) Subject: Re: [PATCH 14/72] softfloat: Do not produce a default_nan from parts_silence_nan To: Richard Henderson , qemu-devel@nongnu.org References: <20210508014802.892561-1-richard.henderson@linaro.org> <20210508014802.892561-15-richard.henderson@linaro.org> From: David Hildenbrand Organization: Red Hat Message-ID: <54481b9a-7080-a071-cf43-5d132637c930@redhat.com> Date: Tue, 11 May 2021 12:16:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210508014802.892561-15-richard.henderson@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 08.05.21 03:47, Richard Henderson wrote: > Require default_nan_mode to be set instead. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat-specialize.c.inc | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/fpu/softfloat-specialize.c.inc b/fpu/softfloat-specialize.c.inc > index 487b29155c..5988830c16 100644 > --- a/fpu/softfloat-specialize.c.inc > +++ b/fpu/softfloat-specialize.c.inc > @@ -180,16 +180,15 @@ static FloatParts parts_default_nan(float_status *status) > static FloatParts parts_silence_nan(FloatParts a, float_status *status) > { > g_assert(!no_signaling_nans(status)); > -#if defined(TARGET_HPPA) > - a.frac &= ~(1ULL << (DECOMPOSED_BINARY_POINT - 1)); > - a.frac |= 1ULL << (DECOMPOSED_BINARY_POINT - 2); > -#else > + g_assert(!status->default_nan_mode); > + > + /* The only snan_bit_is_one target without default_nan_mode is HPPA. */ > if (snan_bit_is_one(status)) { > - return parts_default_nan(status); > + a.frac &= ~(1ULL << (DECOMPOSED_BINARY_POINT - 1)); > + a.frac |= 1ULL << (DECOMPOSED_BINARY_POINT - 2); > } else { > a.frac |= 1ULL << (DECOMPOSED_BINARY_POINT - 1); > } > -#endif > a.cls = float_class_qnan; > return a; > } > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb