All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: android: ion: fix typos in comments
@ 2014-10-31  6:43 Tristan Lelong
  2014-10-31 17:28 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Tristan Lelong @ 2014-10-31  6:43 UTC (permalink / raw
  To: gregkh, john.stultz, rebecca, ccross, mitchelh, benjamin.gaignard,
	romlem, daeseok.youn
  Cc: devel, linux-kernel, Tristan Lelong

Fix some coding style warnings detected by checkpatch.pl in ion.

Signed-off-by: Tristan Lelong <tristan@lelong.xyz>
---
 drivers/staging/android/ion/ion.c      | 2 +-
 drivers/staging/android/ion/ion.h      | 2 +-
 drivers/staging/android/ion/ion_priv.h | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 290d4d2..8724ef8 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -250,7 +250,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
 	   our systems the only dma_address space is physical addresses.
 	   Additionally, we can't afford the overhead of invalidating every
 	   allocation via dma_map_sg. The implicit contract here is that
-	   memory comming from the heaps is ready for dma, ie if it has a
+	   memory coming from the heaps is ready for dma, ie if it has a
 	   cached mapping that mapping has been invalidated */
 	for_each_sg(buffer->sg_table->sgl, sg, buffer->sg_table->nents, i)
 		sg_dma_address(sg) = sg_phys(sg);
diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
index d305bb7..443db84 100644
--- a/drivers/staging/android/ion/ion.h
+++ b/drivers/staging/android/ion/ion.h
@@ -76,7 +76,7 @@ struct ion_platform_data {
  *		size
  *
  * Calls memblock reserve to set aside memory for heaps that are
- * located at specific memory addresses or of specfic sizes not
+ * located at specific memory addresses or of specific sizes not
  * managed by the kernel
  */
 void ion_reserve(struct ion_platform_data *data);
diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h
index c8f0175..18a5f93 100644
--- a/drivers/staging/android/ion/ion_priv.h
+++ b/drivers/staging/android/ion/ion_priv.h
@@ -345,7 +345,7 @@ void ion_carveout_free(struct ion_heap *heap, ion_phys_addr_t addr,
  * functions for creating and destroying a heap pool -- allows you
  * to keep a pool of pre allocated memory to use from your heap.  Keeping
  * a pool of memory that is ready for dma, ie any cached mapping have been
- * invalidated from the cache, provides a significant peformance benefit on
+ * invalidated from the cache, provides a significant performance benefit on
  * many systems */
 
 /**
@@ -362,7 +362,7 @@ void ion_carveout_free(struct ion_heap *heap, ion_phys_addr_t addr,
  *
  * Allows you to keep a pool of pre allocated pages to use from your heap.
  * Keeping a pool of pages that is ready for dma, ie any cached mapping have
- * been invalidated from the cache, provides a significant peformance benefit
+ * been invalidated from the cache, provides a significant performance benefit
  * on many systems
  */
 struct ion_page_pool {
-- 
2.1.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: android: ion: fix typos in comments
  2014-10-31  6:43 [PATCH] Staging: android: ion: fix typos in comments Tristan Lelong
@ 2014-10-31 17:28 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2014-10-31 17:28 UTC (permalink / raw
  To: Tristan Lelong, gregkh, john.stultz, rebecca, ccross, mitchelh,
	benjamin.gaignard, romlem, daeseok.youn
  Cc: devel, linux-kernel

On 10/30/14 23:43, Tristan Lelong wrote:
> Fix some coding style warnings detected by checkpatch.pl in ion.

$Subject is correct but the changelog above is not -- needs to be changed.


> 
> Signed-off-by: Tristan Lelong <tristan@lelong.xyz>
> ---
>  drivers/staging/android/ion/ion.c      | 2 +-
>  drivers/staging/android/ion/ion.h      | 2 +-
>  drivers/staging/android/ion/ion_priv.h | 4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 290d4d2..8724ef8 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -250,7 +250,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
>  	   our systems the only dma_address space is physical addresses.
>  	   Additionally, we can't afford the overhead of invalidating every
>  	   allocation via dma_map_sg. The implicit contract here is that
> -	   memory comming from the heaps is ready for dma, ie if it has a
> +	   memory coming from the heaps is ready for dma, ie if it has a
>  	   cached mapping that mapping has been invalidated */
>  	for_each_sg(buffer->sg_table->sgl, sg, buffer->sg_table->nents, i)
>  		sg_dma_address(sg) = sg_phys(sg);
> diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
> index d305bb7..443db84 100644
> --- a/drivers/staging/android/ion/ion.h
> +++ b/drivers/staging/android/ion/ion.h
> @@ -76,7 +76,7 @@ struct ion_platform_data {
>   *		size
>   *
>   * Calls memblock reserve to set aside memory for heaps that are
> - * located at specific memory addresses or of specfic sizes not
> + * located at specific memory addresses or of specific sizes not
>   * managed by the kernel
>   */
>  void ion_reserve(struct ion_platform_data *data);
> diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h
> index c8f0175..18a5f93 100644
> --- a/drivers/staging/android/ion/ion_priv.h
> +++ b/drivers/staging/android/ion/ion_priv.h
> @@ -345,7 +345,7 @@ void ion_carveout_free(struct ion_heap *heap, ion_phys_addr_t addr,
>   * functions for creating and destroying a heap pool -- allows you
>   * to keep a pool of pre allocated memory to use from your heap.  Keeping
>   * a pool of memory that is ready for dma, ie any cached mapping have been
> - * invalidated from the cache, provides a significant peformance benefit on
> + * invalidated from the cache, provides a significant performance benefit on
>   * many systems */
>  
>  /**
> @@ -362,7 +362,7 @@ void ion_carveout_free(struct ion_heap *heap, ion_phys_addr_t addr,
>   *
>   * Allows you to keep a pool of pre allocated pages to use from your heap.
>   * Keeping a pool of pages that is ready for dma, ie any cached mapping have
> - * been invalidated from the cache, provides a significant peformance benefit
> + * been invalidated from the cache, provides a significant performance benefit
>   * on many systems
>   */
>  struct ion_page_pool {
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-31 17:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-31  6:43 [PATCH] Staging: android: ion: fix typos in comments Tristan Lelong
2014-10-31 17:28 ` Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.