* vxlan: error handling and error messages during vxlan_init
@ 2014-10-31 18:11 Marcelo Ricardo Leitner
0 siblings, 0 replies; only message in thread
From: Marcelo Ricardo Leitner @ 2014-10-31 18:11 UTC (permalink / raw
To: stephen, pshelar; +Cc: netdev
Hi Stephen, Pravin,
Before Stephen's commit 1c51a9159ddefa5119724a4c7da3fd3ef44b68d5 (vxlan: fix
race caused by dropping rtnl_unlock), if we failed to create the UDP socket
for any reason, for example, the user would be informed right away. After that
commit, the only option is to delete the vxlan and create it again, right?
Because by simply calling ip link set vxlanX up is not enough:
/* Setup stats when device is created */
static int vxlan_init(struct net_device *dev)
{
struct vxlan_dev *vxlan = netdev_priv(dev);
struct vxlan_net *vn = net_generic(vxlan->net, vxlan_net_id);
struct vxlan_sock *vs;
dev->tstats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats);
if (!dev->tstats)
return -ENOMEM;
spin_lock(&vn->sock_lock);
vs = vxlan_find_sock(vxlan->net, (vxlan->flags & VXLAN_F_IPV6) ? AF_INET6
: AF_INET, vxlan->dst_port);
if (vs) {
/* If we have a socket with same port already, reuse it */
atomic_inc(&vs->refcnt);
vxlan_vs_add_dev(vs, vxlan);
} else {
/* otherwise make new socket outside of RTNL */
dev_hold(dev);
queue_work(vxlan_wq, &vxlan->sock_work); <--
}
spin_unlock(&vn->sock_lock);
return 0;
}
Error is just ignored:
/* Scheduled at device creation to bind to a socket */
static void vxlan_sock_work(struct work_struct *work)
{
struct vxlan_dev *vxlan = container_of(work, struct vxlan_dev, sock_work);
struct net *net = vxlan->net;
struct vxlan_net *vn = net_generic(net, vxlan_net_id);
__be16 port = vxlan->dst_port;
struct vxlan_sock *nvs;
nvs = vxlan_sock_add(net, port, vxlan_rcv, NULL, false, vxlan->flags);
spin_lock(&vn->sock_lock);
if (!IS_ERR(nvs))
vxlan_vs_add_dev(nvs, vxlan);
spin_unlock(&vn->sock_lock);
dev_put(vxlan->dev);
}
And we can't bring it up:
/* Start ageing timer and join group when device is brought up */
static int vxlan_open(struct net_device *dev)
{
struct vxlan_dev *vxlan = netdev_priv(dev);
struct vxlan_sock *vs = vxlan->vn_sock;
/* socket hasn't been created */
if (!vs)
return -ENOTCONN; <---
And making this to retry the initialization doesn't seem a good idea.
Can we improve that error handling, somehow? As far as I could track, VXLAN is
the only one that currently defers some initialization code during ndo_init.
Together with that, that initial commit did put some good error messages on
this part of the code, like:
+ nvs = vxlan_socket_create(net, port);
+ if (IS_ERR(nvs)) {
+ netdev_err(vxlan->dev, "Can not create UDP socket, %ld\n",
+ PTR_ERR(nvs));
+ goto out;
+ }
But Pravin's 9c2e24e16fbccf6cc1102442acc4a629f79615a7 commit removed them all.
The only error message that is currently available is:
[root@localhost ~]# ip link set vxlan7 up
RTNETLINK answers: Transport endpoint is not connected
Nothing else is logged, dmesg or anywhere. (The actual error on this case was
that it failed to create the UDP socket because the port was already in use..)
May we put them back? :) doesn't seem it would hurt OVS..
Thanks,
Marcelo
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-10-31 18:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-31 18:11 vxlan: error handling and error messages during vxlan_init Marcelo Ricardo Leitner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.