From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C10D7C4320E for ; Fri, 30 Jul 2021 09:42:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB65661050 for ; Fri, 30 Jul 2021 09:42:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238320AbhG3Jmj convert rfc822-to-8bit (ORCPT ); Fri, 30 Jul 2021 05:42:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238312AbhG3Jmg (ORCPT ); Fri, 30 Jul 2021 05:42:36 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7732EC061765 for ; Fri, 30 Jul 2021 02:42:31 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9P26-0006mS-Mk; Fri, 30 Jul 2021 11:42:22 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1m9P23-0008QP-PV; Fri, 30 Jul 2021 11:42:19 +0200 Message-ID: <54a74efe287e3bb673c958652946e38dfa8f3fea.camel@pengutronix.de> Subject: Re: [PATCHv1 1/3] arm64: dts: amlogic: add missing ethernet reset ID From: Philipp Zabel To: Anand Moon , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, devicetree@vger.kernel.org Cc: Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Rob Herring , Kevin Hilman , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Maxime Coquelin , Emiliano Ingrassia Date: Fri, 30 Jul 2021 11:42:19 +0200 In-Reply-To: <20210729201100.3994-2-linux.amoon@gmail.com> References: <20210729201100.3994-1-linux.amoon@gmail.com> <20210729201100.3994-2-linux.amoon@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anand, On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote: > Add reset external reset of the ethernet mac controller, > used new reset id for reset controller as it conflict > with the core reset id. > > Fixes: f3362f0c1817 ("arm64: dts: amlogic: add missing ethernet reset ID") > > Cc: Jerome Brunet > Cc: Neil Armstrong > Cc: Martin Blumenstingl > Signed-off-by: Anand Moon > --- > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++ > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++ > 3 files changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index 3f5254eeb47b..da3bf9f7c1c6 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -280,6 +280,8 @@ ethmac: ethernet@ff3f0000 { > "timing-adjustment"; > rx-fifo-depth = <4096>; > tx-fifo-depth = <2048>; > + resets = <&reset RESET_ETHERNET>; > + reset-names = "ethreset"; This is missing binding documentation. Also, is this reset name taken from the documentation? Otherwise, it would probably be better to call it "phy" for a PHY reset. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D4E4C4338F for ; Fri, 30 Jul 2021 09:42:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9EEA60F00 for ; Fri, 30 Jul 2021 09:42:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E9EEA60F00 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ATYSDHeypwEaWb5ivvdFtZWFCQsturzqUDo8SkaAuk=; b=UxB+OR5cJAtwOj vS1AZb9JNTNXpgZUYKAKXWmkW/X34F66PNDypJYJiSHsdXBmAYF1bsRL2NNY5viqgOTY3up5LAARI i4NJkZ+n5jkfiEkepvqo9Ttaq5tL766Ll+wjH1QAbSYP6HT+hSAzZ3Y+YhWM9toEB+Vkxm3gctNkR nrK5LvZXmNTd7d5a5fnGbf/1iKHbNxnmwnS2mrgThD4EKbgqRn5ejvQP6YSipu5EmrSl3jsw4m51+ EsizalptV5HLXzl4zUi+VJ9JqJby3NAE53Dj2Zuo1ZiIA/MgD+vaVPdJ/Iih42x7Ghgj0PLR8Pq8v hbS6s/hgoolAKT2D9LVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9P2Y-007xnR-E1; Fri, 30 Jul 2021 09:42:50 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9P2A-007xes-ES for linux-amlogic@lists.infradead.org; Fri, 30 Jul 2021 09:42:29 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9P26-0006mS-Mk; Fri, 30 Jul 2021 11:42:22 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1m9P23-0008QP-PV; Fri, 30 Jul 2021 11:42:19 +0200 Message-ID: <54a74efe287e3bb673c958652946e38dfa8f3fea.camel@pengutronix.de> Subject: Re: [PATCHv1 1/3] arm64: dts: amlogic: add missing ethernet reset ID From: Philipp Zabel To: Anand Moon , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, devicetree@vger.kernel.org Cc: Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Rob Herring , Kevin Hilman , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Maxime Coquelin , Emiliano Ingrassia Date: Fri, 30 Jul 2021 11:42:19 +0200 In-Reply-To: <20210729201100.3994-2-linux.amoon@gmail.com> References: <20210729201100.3994-1-linux.amoon@gmail.com> <20210729201100.3994-2-linux.amoon@gmail.com> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-amlogic@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_024226_528885_91840664 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Anand, On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote: > Add reset external reset of the ethernet mac controller, > used new reset id for reset controller as it conflict > with the core reset id. > > Fixes: f3362f0c1817 ("arm64: dts: amlogic: add missing ethernet reset ID") > > Cc: Jerome Brunet > Cc: Neil Armstrong > Cc: Martin Blumenstingl > Signed-off-by: Anand Moon > --- > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++ > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++ > 3 files changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index 3f5254eeb47b..da3bf9f7c1c6 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -280,6 +280,8 @@ ethmac: ethernet@ff3f0000 { > "timing-adjustment"; > rx-fifo-depth = <4096>; > tx-fifo-depth = <2048>; > + resets = <&reset RESET_ETHERNET>; > + reset-names = "ethreset"; This is missing binding documentation. Also, is this reset name taken from the documentation? Otherwise, it would probably be better to call it "phy" for a PHY reset. regards Philipp _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5817C4338F for ; Fri, 30 Jul 2021 09:44:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE11B60F00 for ; Fri, 30 Jul 2021 09:44:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AE11B60F00 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U9xGd494A6LXib25dDpKOp8dOYiQeFvX9HsyfKovYvk=; b=3MN9PscORHJup4 fU47saDze67zMXP/97zDd2p5IrXJfF/fp2sHRbZDndbRPsWda77P06SN1eGPRZakHH23c/TdBjrK+ KW91C6uit/tGwRm8ZCO1Uj0kMeQ0G++upv+tg2obAoy8EdMiluWastYYg0gtV+CUn7uSV026/7Eop qfBNxSazJZTZ5nhukVmFFVgZICU1AToMGDyvK8O/mQCqzUjCcFaROOEb4eOfYJXUPOs8SIiVRRXY3 zBnKkq+IIbwpgvNi71B9ZoPfBF0jHQGds+qveWBBqjsrew2L+C4pMbaqa5224URuhSbTWVZsKBWNb TVIAJZ0pUBktHlLA4aVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9P2G-007xhq-V9; Fri, 30 Jul 2021 09:42:33 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9P2A-007xer-DM for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 09:42:28 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9P26-0006mS-Mk; Fri, 30 Jul 2021 11:42:22 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1m9P23-0008QP-PV; Fri, 30 Jul 2021 11:42:19 +0200 Message-ID: <54a74efe287e3bb673c958652946e38dfa8f3fea.camel@pengutronix.de> Subject: Re: [PATCHv1 1/3] arm64: dts: amlogic: add missing ethernet reset ID From: Philipp Zabel To: Anand Moon , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, devicetree@vger.kernel.org Cc: Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Rob Herring , Kevin Hilman , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Maxime Coquelin , Emiliano Ingrassia Date: Fri, 30 Jul 2021 11:42:19 +0200 In-Reply-To: <20210729201100.3994-2-linux.amoon@gmail.com> References: <20210729201100.3994-1-linux.amoon@gmail.com> <20210729201100.3994-2-linux.amoon@gmail.com> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_024226_507247_356EE150 X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anand, On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote: > Add reset external reset of the ethernet mac controller, > used new reset id for reset controller as it conflict > with the core reset id. > > Fixes: f3362f0c1817 ("arm64: dts: amlogic: add missing ethernet reset ID") > > Cc: Jerome Brunet > Cc: Neil Armstrong > Cc: Martin Blumenstingl > Signed-off-by: Anand Moon > --- > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++ > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++ > 3 files changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index 3f5254eeb47b..da3bf9f7c1c6 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -280,6 +280,8 @@ ethmac: ethernet@ff3f0000 { > "timing-adjustment"; > rx-fifo-depth = <4096>; > tx-fifo-depth = <2048>; > + resets = <&reset RESET_ETHERNET>; > + reset-names = "ethreset"; This is missing binding documentation. Also, is this reset name taken from the documentation? Otherwise, it would probably be better to call it "phy" for a PHY reset. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel