From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243AbbCSPd2 (ORCPT ); Thu, 19 Mar 2015 11:33:28 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:34762 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbbCSPdV (ORCPT ); Thu, 19 Mar 2015 11:33:21 -0400 Message-ID: <550AEC3C.5090200@linaro.org> Date: Thu, 19 Mar 2015 16:33:16 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Lina Iyer CC: rjw@rjwysocki.net, lorenzo.pieralisi@arm.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin.Marinas@arm.com, robherring2@gmail.com, arnd@arndb.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device References: <1426704372-20406-1-git-send-email-daniel.lezcano@linaro.org> <1426704372-20406-8-git-send-email-daniel.lezcano@linaro.org> <20150319153112.GA589@linaro.org> In-Reply-To: <20150319153112.GA589@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/19/2015 04:31 PM, Lina Iyer wrote: > On Wed, Mar 18 2015 at 12:46 -0600, Daniel Lezcano wrote: >> Some architectures have some cpus which does not support idle states. >> >> Let the underlying low level code to return -ENOSYS when it is not >> possible to set an idle state. >> >> Signed-off-by: Daniel Lezcano >> --- >> drivers/cpuidle/cpuidle-arm.c | 45 >> +++++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 43 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/cpuidle/cpuidle-arm.c >> b/drivers/cpuidle/cpuidle-arm.c >> index 1c94b88..0682ed0 100644 >> --- a/drivers/cpuidle/cpuidle-arm.c >> +++ b/drivers/cpuidle/cpuidle-arm.c >> @@ -17,11 +17,14 @@ >> #include >> #include >> #include >> +#include >> >> #include >> >> #include "dt_idle_states.h" >> >> +static DEFINE_PER_CPU(struct cpuidle_device, *cpuidle_arm_dev); > > Is a per-cpu variable needed? There seems to be no per-cpu access, other > than at init. :) Actually it is the cpuidle framework which is using the per cpu variable. >> + >> /* >> * arm_enter_idle_state - Programs CPU to enter the specified state >> * >> @@ -94,6 +97,7 @@ static int __init arm_idle_init(void) >> { >> int cpu, ret; >> struct cpuidle_driver *drv = &arm_idle_driver; >> + struct cpuidle_device *dev; >> >> /* >> * Initialize idle states data, starting at index 1. >> @@ -105,18 +109,55 @@ static int __init arm_idle_init(void) >> if (ret <= 0) >> return ret ? : -ENODEV; >> >> + ret = cpuidle_register_driver(drv); >> + if (ret) { >> + pr_err("Failed to register cpuidle driver\n"); >> + return ret; >> + } >> + >> /* >> * Call arch CPU operations in order to initialize >> * idle states suspend back-end specific data >> */ >> for_each_possible_cpu(cpu) { >> ret = arm_cpuidle_init(cpu); >> + >> + /* This cpu does not support any idle states */ >> + if (ret == -ENOSYS) >> + continue; >> + >> if (ret) { >> pr_err("CPU %d failed to init idle CPU ops\n", cpu); >> - return ret; >> + goto out_fail; >> + } >> + >> + dev = kzalloc(sizeof(*dev), GFP_KERNEL); >> + if (!dev) { >> + pr_err("Failed to allocate cpuidle device\n"); >> + goto out_fail; >> + } >> + >> + dev->cpu = cpu; >> + per_cpu(cpuidle_arm_dev, cpu) = dev; >> + >> + ret = cpuidle_register_device(dev); >> + if (ret) { >> + pr_err("Failed to register cpuidle device for CPU %d\n", >> + cpu); >> + kfree(dev); >> + goto out_fail; >> } >> } >> +out: >> + return ret; >> >> - return cpuidle_register(drv, NULL); >> +out_fail: >> + for (cpu--; cpu <= 0; cpu--) { >> + dev = per_cpu(cpuidle_arm_dev, cpu); >> + cpuidle_unregister_device(dev); >> + kfree(dev); >> + } >> + cpuidle_unregister_driver(drv); >> + goto out; >> } >> device_initcall(arm_idle_init); >> -- >> 1.9.1 >> -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device Date: Thu, 19 Mar 2015 16:33:16 +0100 Message-ID: <550AEC3C.5090200@linaro.org> References: <1426704372-20406-1-git-send-email-daniel.lezcano@linaro.org> <1426704372-20406-8-git-send-email-daniel.lezcano@linaro.org> <20150319153112.GA589@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150319153112.GA589-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lina Iyer Cc: rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org, lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Catalin.Marinas-5wv7dgnIgG8@public.gmane.org, robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 03/19/2015 04:31 PM, Lina Iyer wrote: > On Wed, Mar 18 2015 at 12:46 -0600, Daniel Lezcano wrote: >> Some architectures have some cpus which does not support idle states= =2E >> >> Let the underlying low level code to return -ENOSYS when it is not >> possible to set an idle state. >> >> Signed-off-by: Daniel Lezcano >> --- >> drivers/cpuidle/cpuidle-arm.c | 45 >> +++++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 43 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/cpuidle/cpuidle-arm.c >> b/drivers/cpuidle/cpuidle-arm.c >> index 1c94b88..0682ed0 100644 >> --- a/drivers/cpuidle/cpuidle-arm.c >> +++ b/drivers/cpuidle/cpuidle-arm.c >> @@ -17,11 +17,14 @@ >> #include >> #include >> #include >> +#include >> >> #include >> >> #include "dt_idle_states.h" >> >> +static DEFINE_PER_CPU(struct cpuidle_device, *cpuidle_arm_dev); > > Is a per-cpu variable needed? There seems to be no per-cpu access, ot= her > than at init. :) Actually it is the cpuidle framework which is using the per cpu variabl= e. >> + >> /* >> * arm_enter_idle_state - Programs CPU to enter the specified state >> * >> @@ -94,6 +97,7 @@ static int __init arm_idle_init(void) >> { >> int cpu, ret; >> struct cpuidle_driver *drv =3D &arm_idle_driver; >> + struct cpuidle_device *dev; >> >> /* >> * Initialize idle states data, starting at index 1. >> @@ -105,18 +109,55 @@ static int __init arm_idle_init(void) >> if (ret <=3D 0) >> return ret ? : -ENODEV; >> >> + ret =3D cpuidle_register_driver(drv); >> + if (ret) { >> + pr_err("Failed to register cpuidle driver\n"); >> + return ret; >> + } >> + >> /* >> * Call arch CPU operations in order to initialize >> * idle states suspend back-end specific data >> */ >> for_each_possible_cpu(cpu) { >> ret =3D arm_cpuidle_init(cpu); >> + >> + /* This cpu does not support any idle states */ >> + if (ret =3D=3D -ENOSYS) >> + continue; >> + >> if (ret) { >> pr_err("CPU %d failed to init idle CPU ops\n", cpu); >> - return ret; >> + goto out_fail; >> + } >> + >> + dev =3D kzalloc(sizeof(*dev), GFP_KERNEL); >> + if (!dev) { >> + pr_err("Failed to allocate cpuidle device\n"); >> + goto out_fail; >> + } >> + >> + dev->cpu =3D cpu; >> + per_cpu(cpuidle_arm_dev, cpu) =3D dev; >> + >> + ret =3D cpuidle_register_device(dev); >> + if (ret) { >> + pr_err("Failed to register cpuidle device for CPU %d\n"= , >> + cpu); >> + kfree(dev); >> + goto out_fail; >> } >> } >> +out: >> + return ret; >> >> - return cpuidle_register(drv, NULL); >> +out_fail: >> + for (cpu--; cpu <=3D 0; cpu--) { >> + dev =3D per_cpu(cpuidle_arm_dev, cpu); >> + cpuidle_unregister_device(dev); >> + kfree(dev); >> + } >> + cpuidle_unregister_driver(drv); >> + goto out; >> } >> device_initcall(arm_idle_init); >> -- >> 1.9.1 >> --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Thu, 19 Mar 2015 16:33:16 +0100 Subject: [PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device In-Reply-To: <20150319153112.GA589@linaro.org> References: <1426704372-20406-1-git-send-email-daniel.lezcano@linaro.org> <1426704372-20406-8-git-send-email-daniel.lezcano@linaro.org> <20150319153112.GA589@linaro.org> Message-ID: <550AEC3C.5090200@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/19/2015 04:31 PM, Lina Iyer wrote: > On Wed, Mar 18 2015 at 12:46 -0600, Daniel Lezcano wrote: >> Some architectures have some cpus which does not support idle states. >> >> Let the underlying low level code to return -ENOSYS when it is not >> possible to set an idle state. >> >> Signed-off-by: Daniel Lezcano >> --- >> drivers/cpuidle/cpuidle-arm.c | 45 >> +++++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 43 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/cpuidle/cpuidle-arm.c >> b/drivers/cpuidle/cpuidle-arm.c >> index 1c94b88..0682ed0 100644 >> --- a/drivers/cpuidle/cpuidle-arm.c >> +++ b/drivers/cpuidle/cpuidle-arm.c >> @@ -17,11 +17,14 @@ >> #include >> #include >> #include >> +#include >> >> #include >> >> #include "dt_idle_states.h" >> >> +static DEFINE_PER_CPU(struct cpuidle_device, *cpuidle_arm_dev); > > Is a per-cpu variable needed? There seems to be no per-cpu access, other > than at init. :) Actually it is the cpuidle framework which is using the per cpu variable. >> + >> /* >> * arm_enter_idle_state - Programs CPU to enter the specified state >> * >> @@ -94,6 +97,7 @@ static int __init arm_idle_init(void) >> { >> int cpu, ret; >> struct cpuidle_driver *drv = &arm_idle_driver; >> + struct cpuidle_device *dev; >> >> /* >> * Initialize idle states data, starting at index 1. >> @@ -105,18 +109,55 @@ static int __init arm_idle_init(void) >> if (ret <= 0) >> return ret ? : -ENODEV; >> >> + ret = cpuidle_register_driver(drv); >> + if (ret) { >> + pr_err("Failed to register cpuidle driver\n"); >> + return ret; >> + } >> + >> /* >> * Call arch CPU operations in order to initialize >> * idle states suspend back-end specific data >> */ >> for_each_possible_cpu(cpu) { >> ret = arm_cpuidle_init(cpu); >> + >> + /* This cpu does not support any idle states */ >> + if (ret == -ENOSYS) >> + continue; >> + >> if (ret) { >> pr_err("CPU %d failed to init idle CPU ops\n", cpu); >> - return ret; >> + goto out_fail; >> + } >> + >> + dev = kzalloc(sizeof(*dev), GFP_KERNEL); >> + if (!dev) { >> + pr_err("Failed to allocate cpuidle device\n"); >> + goto out_fail; >> + } >> + >> + dev->cpu = cpu; >> + per_cpu(cpuidle_arm_dev, cpu) = dev; >> + >> + ret = cpuidle_register_device(dev); >> + if (ret) { >> + pr_err("Failed to register cpuidle device for CPU %d\n", >> + cpu); >> + kfree(dev); >> + goto out_fail; >> } >> } >> +out: >> + return ret; >> >> - return cpuidle_register(drv, NULL); >> +out_fail: >> + for (cpu--; cpu <= 0; cpu--) { >> + dev = per_cpu(cpuidle_arm_dev, cpu); >> + cpuidle_unregister_device(dev); >> + kfree(dev); >> + } >> + cpuidle_unregister_driver(drv); >> + goto out; >> } >> device_initcall(arm_idle_init); >> -- >> 1.9.1 >> -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog