From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbbCYHEF (ORCPT ); Wed, 25 Mar 2015 03:04:05 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:34069 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbbCYHEB (ORCPT ); Wed, 25 Mar 2015 03:04:01 -0400 Message-ID: <55125DDC.9000901@linaro.org> Date: Wed, 25 Mar 2015 08:03:56 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Lorenzo Pieralisi CC: "rjw@rjwysocki.net" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Catalin Marinas , "robherring2@gmail.com" , "arnd@arndb.de" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "lina.iyer@linaro.org" , "sboyd@codeaurora.org" Subject: Re: [PATCH 2/2] ARM: cpuidle: Document the code References: <20150323225828.GC15435@e102568-lin.cambridge.arm.com> <1427190842-30675-1-git-send-email-daniel.lezcano@linaro.org> <1427190842-30675-2-git-send-email-daniel.lezcano@linaro.org> <20150324185144.GB27311@red-moon> In-Reply-To: <20150324185144.GB27311@red-moon> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/24/2015 07:51 PM, Lorenzo Pieralisi wrote: > On Tue, Mar 24, 2015 at 09:54:02AM +0000, Daniel Lezcano wrote: >> Add kernel-doc format documentation in the code. >> >> Signed-off-by: Daniel Lezcano >> --- [ ... ] >> + * Returns: >> + * 0 on success, >> + * -ENODEV if it fails to find the cpu node in the device tree, >> + * -EOPNOTSUPP if it does not find a registered cpuidle_ops for this cpu, >> + * -ENOENT if it fails to find a enabled-method property, > > Ultra-nit: "an enabled-method" > >> + * -ENXIO if the HW reports a failure or a misconfiguration > > -ENOMEM is missing. > > Apart from these ultraminor changes (and thanks for putting it > together): > > Acked-by: Lorenzo Pieralisi > Thanks for review Lorenzo. I fixed the comment and pushed in my tree for 4.1. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Wed, 25 Mar 2015 08:03:56 +0100 Subject: [PATCH 2/2] ARM: cpuidle: Document the code In-Reply-To: <20150324185144.GB27311@red-moon> References: <20150323225828.GC15435@e102568-lin.cambridge.arm.com> <1427190842-30675-1-git-send-email-daniel.lezcano@linaro.org> <1427190842-30675-2-git-send-email-daniel.lezcano@linaro.org> <20150324185144.GB27311@red-moon> Message-ID: <55125DDC.9000901@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/24/2015 07:51 PM, Lorenzo Pieralisi wrote: > On Tue, Mar 24, 2015 at 09:54:02AM +0000, Daniel Lezcano wrote: >> Add kernel-doc format documentation in the code. >> >> Signed-off-by: Daniel Lezcano >> --- [ ... ] >> + * Returns: >> + * 0 on success, >> + * -ENODEV if it fails to find the cpu node in the device tree, >> + * -EOPNOTSUPP if it does not find a registered cpuidle_ops for this cpu, >> + * -ENOENT if it fails to find a enabled-method property, > > Ultra-nit: "an enabled-method" > >> + * -ENXIO if the HW reports a failure or a misconfiguration > > -ENOMEM is missing. > > Apart from these ultraminor changes (and thanks for putting it > together): > > Acked-by: Lorenzo Pieralisi > Thanks for review Lorenzo. I fixed the comment and pushed in my tree for 4.1. -- Daniel -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog