From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Jyri Sarha <jsarha@ti.com>,
dri-devel@lists.freedesktop.org, airlied@linux.ie,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
bcousson@baylibre.com, tony@atomide.com
Cc: rmk+kernel@arm.linux.org.uk, robdclark@gmail.com, moinejf@free.fr
Subject: Re: [PATCH v5 0/6] Use DRM component API in tilcdc to connect to tda998x
Date: Wed, 27 May 2015 11:37:03 +0300 [thread overview]
Message-ID: <5565822F.3090201@ti.com> (raw)
In-Reply-To: <cover.1431083641.git.jsarha@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2823 bytes --]
On 08/05/15 14:27, Jyri Sarha wrote:
> For all that I know this should be good for taking.
>
> Changes since v4
> * Rebased on top linux-4.1-rc2
> * Drop "drm/tilcdc: Decrement refcount of ep-node from of_graph_get_next_..."
> * Make connector_funcs const in struct tilcdc_drm_private because
> struct drm_connector's helper_private has been qualified as const in
> linux-4.1
> * Check if a subcomponent has already triggered the unloading.
> - Fixes an oops if the external encoder is unloaded first and tilcdc after
> * Add comment to explain hijacking of external drm connectors helper hijacking
>
> Changes since v3 version of the patch-set:
> * drm/tilcdc: Add support for external tda998x encoder
> - Hijack external connectors helper functions
> - Remove select of nonexistent DRM_TILCDC_INIT in tilcdc Kconfig
> - Correct author mail address to tilcdc_exteral.h
> * drm/tilcdc: Add DRM_TILCDC_SLAVE_COMPAT for ti,tilcdc,slave binding
> - Add a header file for tilcdc_slave_compat.dtb symbol declarations
>
> Changes since v2 version of the patch-set:
> - use obj-y in Makefle for tilcdc subdir in:
> "drm/tilcdc: Force building of DRM_TILCDC_SLAVE_COMPAT"
> - move to last:
> "drm/tilcdc: Decrement refcount of ep-node from of_graph_get_next_endpoint"
>
> Changes since first version of the patch-set:
> - Rename DRM_TILCDC_INIT to DRM_TILCDC_SLAVE_COMPAT and make it visible
> - Add separate:
> drm/tilcdc: Decrement refcount of ep-node from of_graph_get_next_endpoint
> - Reduce info-level spam
> - Use component_master_add_with_match()
> - Be more explicit about tda998x being the only supported external encoder
>
> Remove tilcdc slave support and connect to tda998x trough its
> component DRM API. For dtb backward compatibility the code creates at
> boot time a DT overlay based on the earlier binding. The overlay
> conforms to the new graph based binding.
>
> The "drm/tilcdc: Decrement refcount of ep-node from
> of_graph_get_next_endpoint" should probably not be merged. The "of:
> Decrement refcount of previous endpoint in of_graph_get_next_endpoint"
> is eventually going to be merged and before that leaking of two
> of-node refcount increments each time the module is loaded is not that
> serious. The of-nodes live forever anyway.
>
> The merge of the dts patch can be delayed until the next merger
> window, when the other patches are already in. The
> DRM_TILCDC_SLAVE_COMPAT should keep the bbb HDMI operational until
> then.
>
> The first patch is just a bugfix and can be applied or dropped
> independently.
This works fine for me, and looks ok. There is a minor problem in the
Kconfig, where you define DRM_TILCDC_SLAVE_COMPAT before DRM_TILCDC.
That causes menuconfig to show the items wrongly.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-05-27 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 11:27 [PATCH v5 0/6] Use DRM component API in tilcdc to connect to tda998x Jyri Sarha
2015-05-08 11:27 ` [PATCH v5 1/6] drm/tilcdc: Fix module unloading Jyri Sarha
[not found] ` <cover.1431083641.git.jsarha-l0cyMroinI0@public.gmane.org>
2015-05-08 11:27 ` [PATCH v5 2/6] drm/tilcdc: Remove tilcdc slave support for tda998x driver Jyri Sarha
2015-05-08 11:27 ` [PATCH v5 3/6] drm/tilcdc: Add support for external tda998x encoder Jyri Sarha
2015-05-08 11:27 ` [PATCH v5 4/6] drm/tilcdc: Add DRM_TILCDC_SLAVE_COMPAT for ti,tilcdc,slave binding support Jyri Sarha
2015-05-08 11:27 ` [PATCH v5 5/6] drm/tilcdc: Force building of DRM_TILCDC_SLAVE_COMPAT Jyri Sarha
2015-05-08 11:27 ` [PATCH v5 6/6] ARM: dts: am335x-boneblack: Use new binding for HDMI Jyri Sarha
[not found] ` <43a51f35d24ab668c7015f054bc8f227373e24b6.1431083641.git.jsarha-l0cyMroinI0@public.gmane.org>
2015-07-14 10:31 ` Tony Lindgren
2015-05-27 8:37 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5565822F.3090201@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=airlied@linux.ie \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robdclark@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.