From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161051AbbE2S1s (ORCPT ); Fri, 29 May 2015 14:27:48 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48668 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756793AbbE2S1j (ORCPT ); Fri, 29 May 2015 14:27:39 -0400 Message-ID: <5568AF96.1000201@codeaurora.org> Date: Fri, 29 May 2015 13:27:34 -0500 From: Timur Tabi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Fu Wei CC: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Ashwin Chaugule , Arnd Bergmann , Guenter Roeck , vgandhi@codeaurora.org, wim@iguana.be, Jon Masters , Leo Duran , Jon Corbet , Mark Rutland , Catalin Marinas , Will Deacon Subject: Re: [PATCH v3 5/6] Watchdog: introduce ARM SBSA watchdog driver References: <=fu.wei@linaro.org> <1432548193-19569-1-git-send-email-fu.wei@linaro.org> <1432548193-19569-6-git-send-email-fu.wei@linaro.org> <5564A44A.5000606@codeaurora.org> <55686960.5010503@codeaurora.org> <556889D9.5070707@codeaurora.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/29/2015 12:53 PM, Fu Wei wrote: > If this interrupter is triggered, that means system has goes wrong, > who knows what is wrong , > I have to make sure that system get into that routine ,because of the > WS0, if not I won't do panic. But the interrupt handler is not registered as shared, which means that it cannot be generated by another device. > And in a interrupter routine , checking the Interrupter status > register is right way to do. If you get an interrupt, but WS0 is not set, then you should return IRQ_NONE instead of IRQ_HANDLED. Also, I don't think IRQF_TIMER is correct. It's not a timer interrupt. Watchdogs are *not* timers. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v3 5/6] Watchdog: introduce ARM SBSA watchdog driver Date: Fri, 29 May 2015 13:27:34 -0500 Message-ID: <5568AF96.1000201@codeaurora.org> References: <=fu.wei@linaro.org> <1432548193-19569-1-git-send-email-fu.wei@linaro.org> <1432548193-19569-6-git-send-email-fu.wei@linaro.org> <5564A44A.5000606@codeaurora.org> <55686960.5010503@codeaurora.org> <556889D9.5070707@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fu Wei Cc: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Ashwin Chaugule , Arnd Bergmann , Guenter Roeck , vgandhi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, Jon Masters , Leo Duran , Jon Corbet , Mark Rutland , Catalin Marinas , Will Deacon List-Id: devicetree@vger.kernel.org On 05/29/2015 12:53 PM, Fu Wei wrote: > If this interrupter is triggered, that means system has goes wrong, > who knows what is wrong , > I have to make sure that system get into that routine ,because of the > WS0, if not I won't do panic. But the interrupt handler is not registered as shared, which means that it cannot be generated by another device. > And in a interrupter routine , checking the Interrupter status > register is right way to do. If you get an interrupt, but WS0 is not set, then you should return IRQ_NONE instead of IRQ_HANDLED. Also, I don't think IRQF_TIMER is correct. It's not a timer interrupt. Watchdogs are *not* timers. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html