From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758385AbbEaPxh (ORCPT ); Sun, 31 May 2015 11:53:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52578 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754494AbbEaPx2 (ORCPT ); Sun, 31 May 2015 11:53:28 -0400 Message-ID: <556B2E72.5020508@redhat.com> Date: Sun, 31 May 2015 17:53:22 +0200 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Roman Volkov , Dmitry Torokhov CC: Mark Rutland , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "grant.likely@linaro.org" , Jiri Kosina , Wolfram Sang , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Tony Prisk Subject: Re: References: <20150531183740.17593bd3@v1ron-s7> In-Reply-To: <20150531183740.17593bd3@v1ron-s7> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roman, On 31-05-15 17:37, Roman Volkov wrote: > В Sat, 14 Mar 2015 20:20:38 -0700 > Dmitry Torokhov wrote: > >> >> Hi Roman, >> >> On Mon, Feb 16, 2015 at 12:11:43AM +0300, Roman Volkov wrote: >>> Documentation for 'intel,8042' DT compatible node. >>> >>> Signed-off-by: Tony Prisk >>> Signed-off-by: Roman Volkov >>> --- >>> .../devicetree/bindings/input/intel-8042.txt | 26 >>> ++++++++++++++++++++++ 1 file changed, 26 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/input/intel-8042.txt >>> >>> diff --git a/Documentation/devicetree/bindings/input/intel-8042.txt >>> b/Documentation/devicetree/bindings/input/intel-8042.txt new file >>> mode 100644 index 0000000..ab8a3e0 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/input/intel-8042.txt >>> @@ -0,0 +1,26 @@ >>> +Intel 8042 Keyboard Controller >>> + >>> +Required properties: >>> +- compatible: should be "intel,8042" >>> +- regs: memory for keyboard controller >>> +- interrupts: usually, two interrupts should be specified >>> (keyboard and aux). >>> + However, only one interrupt is also allowed in case of >>> absence of the >>> + physical port in the controller. The i8042 driver must be >>> loaded with >>> + nokbd/noaux option in this case. >>> +- interrupt-names: interrupt names corresponding to numbers in the >>> list. >>> + "kbd" is the keyboard interrupt and "aux" is the auxiliary >>> (mouse) >>> + interrupt. >>> +- command-reg: offset in memory for command register >>> +- status-reg: offset in memory for status register >>> +- data-reg: offset in memory for data register >>> + >>> +Example: >>> + i8042@d8008800 { >>> + compatible = "intel,8042"; >>> + regs = <0xd8008800 0x100>; >>> + interrupts = <23>, <4>; >>> + interrupt-names = "kbd", "aux"; >>> + command-reg = <0x04>; >>> + status-reg = <0x04>; >>> + data-reg = <0x00>; >>> + }; >> >> No, we already have existing OF bindings for i8042 on sparc and >> powerpc, I do not think we need to invent a brand new one. >> >> Thanks. >> > > Hi Dmitry, > > I see some OF code in i8042-sparcio.h file. There are node definitions > like "kb_ps2", "keyboard", "kdmouse", "mouse". Are these documented > somewhere? > > Great if vt8500 is not unique with OF bindings for i8042. The code from > sparc even looks compatible, only register offsets are hardcoded for > specific machine. Is it possible to read offsets from Device Tree using > these existing bindings without dealing with the kernel configuration? Have you looked at the existing bindings for ps/2 controllers under Documentation/devicetree/bindings/serio ? Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: Date: Sun, 31 May 2015 17:53:22 +0200 Message-ID: <556B2E72.5020508@redhat.com> References: <20150531183740.17593bd3@v1ron-s7> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150531183740.17593bd3@v1ron-s7> Sender: linux-input-owner@vger.kernel.org To: Roman Volkov , Dmitry Torokhov Cc: Mark Rutland , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "grant.likely@linaro.org" , Jiri Kosina , Wolfram Sang , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Tony Prisk List-Id: devicetree@vger.kernel.org Hi Roman, On 31-05-15 17:37, Roman Volkov wrote: > =D0=92 Sat, 14 Mar 2015 20:20:38 -0700 > Dmitry Torokhov wrote: > >> >> Hi Roman, >> >> On Mon, Feb 16, 2015 at 12:11:43AM +0300, Roman Volkov wrote: >>> Documentation for 'intel,8042' DT compatible node. >>> >>> Signed-off-by: Tony Prisk >>> Signed-off-by: Roman Volkov >>> --- >>> .../devicetree/bindings/input/intel-8042.txt | 26 >>> ++++++++++++++++++++++ 1 file changed, 26 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/input/intel-8042.txt >>> >>> diff --git a/Documentation/devicetree/bindings/input/intel-8042.txt >>> b/Documentation/devicetree/bindings/input/intel-8042.txt new file >>> mode 100644 index 0000000..ab8a3e0 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/input/intel-8042.txt >>> @@ -0,0 +1,26 @@ >>> +Intel 8042 Keyboard Controller >>> + >>> +Required properties: >>> +- compatible: should be "intel,8042" >>> +- regs: memory for keyboard controller >>> +- interrupts: usually, two interrupts should be specified >>> (keyboard and aux). >>> + However, only one interrupt is also allowed in case of >>> absence of the >>> + physical port in the controller. The i8042 driver must be >>> loaded with >>> + nokbd/noaux option in this case. >>> +- interrupt-names: interrupt names corresponding to numbers in the >>> list. >>> + "kbd" is the keyboard interrupt and "aux" is the auxiliary >>> (mouse) >>> + interrupt. >>> +- command-reg: offset in memory for command register >>> +- status-reg: offset in memory for status register >>> +- data-reg: offset in memory for data register >>> + >>> +Example: >>> + i8042@d8008800 { >>> + compatible =3D "intel,8042"; >>> + regs =3D <0xd8008800 0x100>; >>> + interrupts =3D <23>, <4>; >>> + interrupt-names =3D "kbd", "aux"; >>> + command-reg =3D <0x04>; >>> + status-reg =3D <0x04>; >>> + data-reg =3D <0x00>; >>> + }; >> >> No, we already have existing OF bindings for i8042 on sparc and >> powerpc, I do not think we need to invent a brand new one. >> >> Thanks. >> > > Hi Dmitry, > > I see some OF code in i8042-sparcio.h file. There are node definition= s > like "kb_ps2", "keyboard", "kdmouse", "mouse". Are these documented > somewhere? > > Great if vt8500 is not unique with OF bindings for i8042. The code fr= om > sparc even looks compatible, only register offsets are hardcoded for > specific machine. Is it possible to read offsets from Device Tree usi= ng > these existing bindings without dealing with the kernel configuration= ? Have you looked at the existing bindings for ps/2 controllers under Documentation/devicetree/bindings/serio ? Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html