All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Li Wang <liwang@ubuntukylin.com>
To: Sage Weil <sweil@redhat.com>
Cc: Samuel Just <sjust@redhat.com>, Josh Durgin <jdurgin@redhat.com>,
	ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: [RFC] Implement a new journal mode
Date: Tue, 02 Jun 2015 17:28:46 +0800	[thread overview]
Message-ID: <556D774E.4050702@ubuntukylin.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1505290840180.6462@cobra.newdream.net>

I think for scrub, we have a relatively easy way to solve it,
add a field to object metadata with the value being either UNSTABLE
or STABLE, the algorithm is as below,
1 Mark the object be UNSTABLE
2 Perform object data write
3 Perform metadata write and MARK the object STABLE
The order of the three steps are enforced, and the step 1 and 3 are
written into journal, while step 2 is performed directly on the object.
For scrub, it could now distinguish this situation, and one feasible
policy could be to find the copy with the latest metadata, and
synchronize the data of that copy to others.

For this metadata-only journal mode, I think it does not contradict
with new store, since they address different scenarios. Metadata-only
journal mode mainly focuses on the scenarios that data consistency
does not need be ensured by RADOS itself. And it is especially appealing
for the scenarios with many random small OVERWRITES, for example, RBD
in cloud environment. While new store is great for CREATE and APPEND,
for many random small OVERWRITES, new store is not
very easy to optimize. It seems the only way is to introduce small size
of fragments and turn those OVERWRITES into APPEND. However, in that
case, many small OVERWRITES could cause many small files on the local
file system, it will slow down the subsequent read/write performance of
the object, so it seems not worthy. Of course, a small-file-merge
process could be introduced, but that complicates the design.

So basically, I think new store is great for some of the scenarios,
while metadata-only is desirable for some others, they do not
contradict with each other, what do you think?

Cheers,
Li Wang



On 2015/6/1 8:39, Sage Weil wrote:
> On Fri, 29 May 2015, Li Wang wrote:
>> An important usage of Ceph is to integrate with cloud computing platform
>> to provide the storage for VM images and instances. In such scenario,
>> qemu maps RBD as virtual block devices, i.e., disks to a VM, and
>> the guest operating system will format the disks and create file
>> systems on them. In this case, RBD mostly resembles a 'dumb' disk.  In
>> other words, it is enough for RBD to implement exactly the semantics of
>> a disk controller driver. Typically, the disk controller itself does
>> not provide a transactional mechanism to ensure a write operation done
>> atomically. Instead, it is up to the file system, who manages the disk,
>> to adopt some techniques such as journaling to prevent inconsistency,
>> if necessary. Consequently, RBD does not need to provide the
>> atomic mechanism to ensure a data write operation done atomically,
>> since the guest file system will guarantee that its write operations to
>> RBD will remain consistent by using journaling if needed. Another
>> scenario is for the cache tiering, while cache pool has already
>> provided the durability, when dirty objects are written back, they
>> theoretically need not go through the journaling process of base pool,
>> since the flusher could replay the write operation. These motivate us
>> to implement a new journal mode, metadata-only journal mode, which
>> resembles the data=ordered journal mode in ext4. With such journal mode
>> is on, object data are written directly to their ultimate location,
>> when data written finished, metadata are written into the journal, then
>> the write returns to caller. This will avoid the double-write penalty
>> of object data due to the WRITE-AHEAD-LOGGING, potentially greatly
>> improve the RBD and cache tiering performance.
>>
>> The algorithm is straightforward, as before, the master send
>> transaction to slave, then they extract the object data write
>> operations and apply them to objects directly, next they write the
>> remaining part of the transaction into journal, then slave ack master,
>> master ack client. For some special operations such as 'clone', they
>> can be processed as before by throwing the entire transaction into
>> journal, which makes this approach an absolutely-better optimization
>> in terms of performance.
>>
>> In terms of consistency, metadata consistency is ensured, and
>> the data consistency of CREATE and APPEND are also ensured, just for
>> OVERWRITE, it relies on the caller, i.e., guest file system for RBD,
>> cache flusher for cache tiering to ensure the consistency. In addition,
>> there remains a problem to be discussed that how to interact with the
>> scrub process while the object data consistency may not ensured now.
>
> Right.  This is appealing from a performance perspective, but I'm worried
> it will throw out too many other assumptions in RADOS that will cause
> pain.  The big one is that RADOS will no longer know if the version on the
> object metadata matches the data.  This will be most noticeable from
> scrub, which will have no idea whether the inconsistency is from a partial
> write or from a disk error.  And when that happens, it would have to guess
> which object is the right one--a guess that can easily be wrong if there
> is rebalancing or recovery that may replicate the partially updated
> object.
>
> Maybe we can journal metadata before applying the write to indicate the
> object is 'unstable' (undergoing an overwrite) to help out?
>
> I'm not sure.  Honestly, I would be more interested in investing our time
> in making the new OSD backends handle overwrite more efficiently, by
> avoiding write-ahead in the easy cases (append, create) as newstore
> does, and/or by doing some sort of COW when we do overwrite, or some other
> magic that does an atomic swap-data-into-position (e.g., by abusing the
> xfs defrag ioctl).
>
> What do you think?
> sage
>
>
>   >
>> We are actively working on it and have done part of the implementation,
>> want to hear the feedback of the community, and we may submit it as a
>> blueprint to under discussion in coming CDS.
>>
>> Cheers,
>> Li Wang
>>
>>
>

  reply	other threads:[~2015-06-02  9:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29  9:23 [RFC] Implement a new journal mode Li Wang
2015-05-29 15:46 ` Sage Weil
2015-06-02  9:28   ` Li Wang [this message]
2015-06-02 10:55     ` Haomai Wang
2015-06-03  3:42       ` Li Wang
2015-06-02 15:17     ` Sage Weil
2015-06-18 13:34       ` Li Wang
2015-06-18 14:14         ` Sage Weil
2015-06-19  3:45           ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556D774E.4050702@ubuntukylin.com \
    --to=liwang@ubuntukylin.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=jdurgin@redhat.com \
    --cc=sjust@redhat.com \
    --cc=sweil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.