From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 0/6] Misc cleanups for libxl Date: Wed, 3 Jun 2015 11:51:26 +0100 Message-ID: <556EDC2E.2040306@citrix.com> References: <1433318493-24561-1-git-send-email-yanghy@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1433318493-24561-1-git-send-email-yanghy@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang , xen-devel@lists.xen.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, wency@cn.fujitsu.com, guijianfeng@cn.fujitsu.com, yunhong.jiang@intel.com, eddie.dong@intel.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 03/06/15 09:01, Yang Hongyang wrote: > This patchset mainly focus on libxl save, most of the patches are > simply move codes out of libxl_dom.c, except a refactor patch. > > Please see individual patch for detail. > > Can get the whole patchset from: > https://github.com/macrosheep/xen/tree/misc-libxl-v2 Overall, these look like good changes, although I have not reviewed them in detail. ~Andrew > > v1->v2: > - use dsps for suspend_state and dss for save_state. > - move resume code to libxl_dom_suspend.c > - move toolstatck save/restore code to libxl_dom_save.c > - move refactor pacth to the end so that rebase of the patchset easier. > > Yang Hongyang (6): > tools/libxl: rename libxl__domain_suspend to libxl__domain_save > tools/libxl: move domain suspend code into libxl_dom_suspend.c > tools/libxl: move domain resume code into libxl_dom_suspend.c > tools/libxl: move remus code into libxl_remus.c > tools/libxl: move save/restore code into libxl_dom_save.c > libxl/save: Refactor libxl__domain_suspend_state > > tools/libxl/Makefile | 5 +- > tools/libxl/libxl.c | 126 +--- > tools/libxl/libxl_dom.c | 1202 -------------------------------------- > tools/libxl/libxl_dom_save.c | 672 +++++++++++++++++++++ > tools/libxl/libxl_dom_suspend.c | 465 +++++++++++++++ > tools/libxl/libxl_internal.h | 65 ++- > tools/libxl/libxl_netbuffer.c | 2 +- > tools/libxl/libxl_remus.c | 307 ++++++++++ > tools/libxl/libxl_save_callout.c | 2 +- > 9 files changed, 1503 insertions(+), 1343 deletions(-) > create mode 100644 tools/libxl/libxl_dom_save.c > create mode 100644 tools/libxl/libxl_dom_suspend.c > create mode 100644 tools/libxl/libxl_remus.c >