From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463AbbFIQqU (ORCPT ); Tue, 9 Jun 2015 12:46:20 -0400 Received: from [208.91.199.152] ([208.91.199.152]:43783 "EHLO bh-25.webhostbox.net" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S933288AbbFIQqH (ORCPT ); Tue, 9 Jun 2015 12:46:07 -0400 Message-ID: <5577180E.4070804@roeck-us.net> Date: Tue, 09 Jun 2015 09:45:02 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Timur Tabi , Fu Wei CC: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Ashwin Chaugule , Arnd Bergmann , vgandhi@codeaurora.org, wim@iguana.be, Jon Masters , Leo Duran , Jon Corbet , Mark Rutland , Catalin Marinas , Will Deacon , rjw@rjwysocki.net Subject: Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver References: <=fu.wei@linaro.org> <1433217907-928-1-git-send-email-fu.wei@linaro.org> <1433217907-928-6-git-send-email-fu.wei@linaro.org> <556DCC95.806@codeaurora.org> <556DE2D5.3090906@roeck-us.net> <5575DE48.8010308@roeck-us.net> <55766D74.2060401@roeck-us.net> <55769E0E.8060801@roeck-us.net> <557712CF.8010802@roeck-us.net> <5577147B.2030900@codeaurora.org> In-Reply-To: <5577147B.2030900@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=0.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/2015 09:29 AM, Timur Tabi wrote: > On 06/09/2015 11:22 AM, Guenter Roeck wrote: >> >> >> but I see your point. Essentially, the specification is broken >> for all practical purposes, since, as you point out, enabling >> the watchdog overwrites and explicitly sets WCV. Effectively >> this means that just using WCV to program the timeout period >> is not really possible. >> >> I am not really sure how to address this. We can either only use WOR, >> and forget about pretimeout, or we can enforce a minimum pretimeout. >> In the latter case, we'll have to write WCV after writing WOR. > > In talking with our hardware engineers, using WCV to program the timeout period is not a valid operation. This is why I keep arguing against the pre-timeout feature, and I don't agree that servers should always use pre-timeout. > Not sure if "not valid" is correct - after all, it is mentioned in the specification. However, it is at the very least fragile. I tend to agree that we should just forget about pretimeout and use your original approach, where the timeout value is used to program WOR. Everything else is really just asking for trouble. Guenter