From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753062AbbFLF5F (ORCPT ); Fri, 12 Jun 2015 01:57:05 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:52793 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806AbbFLF5B (ORCPT ); Fri, 12 Jun 2015 01:57:01 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-45-557a74aa53ee Message-id: <557A74AD.6040305@samsung.com> Date: Fri, 12 Jun 2015 14:57:01 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Javier Martinez Canillas , Thomas Gleixner Cc: Jason Cooper , Kukjin Kim , Tomasz Figa , Doug Anderson , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Peter Chubb , Shuah Khan , Chanho Park Subject: Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend References: <1434087795-13990-1-git-send-email-javier.martinez@collabora.co.uk> In-reply-to: <1434087795-13990-1-git-send-email-javier.martinez@collabora.co.uk> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42I5/e/4Zd1VJVWhBus3KFicXXaQzaJxyWUW i6O/CyxevzC06H/8mtli0+NrrBaXd81hs5hxfh+Txfv3C9ksvnX1sFp8/elgsXnTVGaLVbv+ MDrwesxuuMji8ff5dRaPnbPusntsWtXJ5tFw4DyLx7tz59g9Ni+p9zj4bierR9+WVYwenzfJ BXBFcdmkpOZklqUW6dslcGXc73vKWnCBu2Lno3OsDYwLOLsYOTkkBEwkbl99zAphi0lcuLee rYuRi0NIYCmjxNqNO1khnKeMEm/n7GAGqeIV0JL4MXMSO4jNIqAqMXXVckYQm03AWGLz8iVs ILaoQITE28snmSDqBSV+TL7HAmKLCKRJ/D3XDraBWeAtk0TPtotgg4QFwiSOvN4I1iwk4C/x p20vWDOnQIDE6SmXgJo5gBr0JO5f1AIJMwvIS2xe85Z5AqPALCQrZiFUzUJStYCReRWjaGpp ckFxUnquoV5xYm5xaV66XnJ+7iZGSCx92cG4+JjVIUYBDkYlHl4ujapQIdbEsuLK3EOMEhzM SiK8tblAId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rxzd70PERJITyxJzU5NLUgtgskycXBKNTDa awRyL/v/LvvsxooN/HIiAivWJtf9F96xY+3PWb9nmv+a2u6smX1q8ff0eVKTppy+udjiVpeu XRZr7YWWhOD7bIZfmtn9dun/F4xPclR0nPG37dTG8/Xap7b9k1QOX1yzz+RRWZ9ECcdTE15u Y6kbHV6M85gneqZyS3t865qeVqeVqcIyJU+JpTgj0VCLuag4EQD6CbI6oQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.06.2015 14:43, Javier Martinez Canillas wrote: > The Exynos interrupt combiner IP loses its state when the SoC enters > into a low power state during a Suspend-to-RAM. This means that if a > IRQ is used as a source, the interrupts for the devices are disabled > when the system is resumed from a sleep state so are not triggered. > > Save the interrupt enable set register for each combiner group and > restore it after resume to make sure that the interrupts are enabled. > > Signed-off-by: Javier Martinez Canillas > --- > > Hello, > > I noticed this issue because after a S2R, IRQs for some devices didn't > trigger anymore but others continued working and all of them had lines > from a GPIO chip as their interrupt source. > > The only difference was that the GPIO pins that were not working after > a resume, were the ones that had the interrupt combiner as interrupt > parent. > > With this patch now all perhiperals are working correctly after a resume. > Tested on an Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800 Peach Pi > Chromebooks. > > Best regards, > Javier > > Changes since v1: > - Clear masking bits before of the COMBINER_ENABLE_CLEAR register before > restore IRQ enable set the Suggested by Chanho Park. > - Fixes a typo in the commit message. Suggested by Peter Chubb. Looks okay, Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 12 Jun 2015 14:57:01 +0900 Subject: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend In-Reply-To: <1434087795-13990-1-git-send-email-javier.martinez@collabora.co.uk> References: <1434087795-13990-1-git-send-email-javier.martinez@collabora.co.uk> Message-ID: <557A74AD.6040305@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12.06.2015 14:43, Javier Martinez Canillas wrote: > The Exynos interrupt combiner IP loses its state when the SoC enters > into a low power state during a Suspend-to-RAM. This means that if a > IRQ is used as a source, the interrupts for the devices are disabled > when the system is resumed from a sleep state so are not triggered. > > Save the interrupt enable set register for each combiner group and > restore it after resume to make sure that the interrupts are enabled. > > Signed-off-by: Javier Martinez Canillas > --- > > Hello, > > I noticed this issue because after a S2R, IRQs for some devices didn't > trigger anymore but others continued working and all of them had lines > from a GPIO chip as their interrupt source. > > The only difference was that the GPIO pins that were not working after > a resume, were the ones that had the interrupt combiner as interrupt > parent. > > With this patch now all perhiperals are working correctly after a resume. > Tested on an Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800 Peach Pi > Chromebooks. > > Best regards, > Javier > > Changes since v1: > - Clear masking bits before of the COMBINER_ENABLE_CLEAR register before > restore IRQ enable set the Suggested by Chanho Park. > - Fixes a typo in the commit message. Suggested by Peter Chubb. Looks okay, Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof