From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V4 5/7] xl: add pvusb commands
Date: Fri, 12 Jun 2015 10:22:24 +0200
Message-ID: <557A96C0.1060503@suse.com>
References: <1433906441-3280-1-git-send-email-cyliu@suse.com>	<1433906441-3280-6-git-send-email-cyliu@suse.com>	<557A8C57.1040108@suse.com>
	<557B02CB02000066000D4CB2@relay2.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <557B02CB02000066000D4CB2@relay2.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Chun Yan Liu <cyliu@suse.com>, xen-devel@lists.xen.org
Cc: george.dunlap@eu.citrix.com, wei.liu2@citrix.com, Simon Cao <caobosimon@gmail.com>, Ian.Jackson@eu.citrix.com, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 06/12/2015 10:03 AM, Chun Yan Liu wrote:
>
>
>>>> On 6/12/2015 at 03:37 PM, in message <557A8C57.1040108@suse.com>, Juergen Gross
> <jgross@suse.com> wrote:
>> On 06/10/2015 05:20 AM, Chunyan Liu wrote:

...

>>> +        } else if (MATCH_OPTION("ports", argv[optind], oparg)) {
>>> +            usbctrl.ports = atoi(oparg);
>>
>> Same here for number of ports. Otherwise you could blow up xenstore by
>> e.g. specifying 2 billion ports here.
>
> Will add check. What's the supported max ports?

31. I'm about to send a patch updating the pvusb interface description
which will then contain a define for that (USBIF_MAX_PORTNR).


Juergen