From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755103AbbFLKK1 (ORCPT ); Fri, 12 Jun 2015 06:10:27 -0400 Received: from foss.arm.com ([217.140.101.70]:58282 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754834AbbFLKKY (ORCPT ); Fri, 12 Jun 2015 06:10:24 -0400 Message-ID: <557AB00C.5040606@arm.com> Date: Fri, 12 Jun 2015 11:10:20 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Javier Martinez Canillas CC: Thomas Gleixner , Sudeep Holla , Krzysztof Kozlowski , "linux-samsung-soc@vger.kernel.org" , Jason Cooper , Chanho Park , Doug Anderson , "linux-kernel@vger.kernel.org" , Kukjin Kim , Peter Chubb , Shuah Khan , Tomasz Figa , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend References: <1434087795-13990-1-git-send-email-javier.martinez@collabora.co.uk> In-Reply-To: <1434087795-13990-1-git-send-email-javier.martinez@collabora.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/15 06:43, Javier Martinez Canillas wrote: > The Exynos interrupt combiner IP loses its state when the SoC enters > into a low power state during a Suspend-to-RAM. This means that if a > IRQ is used as a source, the interrupts for the devices are disabled > when the system is resumed from a sleep state so are not triggered. > > Save the interrupt enable set register for each combiner group and > restore it after resume to make sure that the interrupts are enabled. > Not sure if you need this. IMO it's not clean and redundant though I admit many drivers do exactly same thing. I am trying to remove or point out those redundant code as irqchip core has options/flags to do what you need. I assume there are no wakeup sources connected to this combiner. Setting irqchip flags should solve this problem. A simple patch below should do the job ? -->8 diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c index 5945223b73fa..c0bcec59f829 100644 --- a/drivers/irqchip/exynos-combiner.c +++ b/drivers/irqchip/exynos-combiner.c @@ -111,6 +111,7 @@ static struct irq_chip combiner_chip = { #ifdef CONFIG_SMP .irq_set_affinity = combiner_set_affinity, #endif + .flags = IRQCHIP_MASK_ON_SUSPEND, }; From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudeep.holla@arm.com (Sudeep Holla) Date: Fri, 12 Jun 2015 11:10:20 +0100 Subject: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend In-Reply-To: <1434087795-13990-1-git-send-email-javier.martinez@collabora.co.uk> References: <1434087795-13990-1-git-send-email-javier.martinez@collabora.co.uk> Message-ID: <557AB00C.5040606@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/06/15 06:43, Javier Martinez Canillas wrote: > The Exynos interrupt combiner IP loses its state when the SoC enters > into a low power state during a Suspend-to-RAM. This means that if a > IRQ is used as a source, the interrupts for the devices are disabled > when the system is resumed from a sleep state so are not triggered. > > Save the interrupt enable set register for each combiner group and > restore it after resume to make sure that the interrupts are enabled. > Not sure if you need this. IMO it's not clean and redundant though I admit many drivers do exactly same thing. I am trying to remove or point out those redundant code as irqchip core has options/flags to do what you need. I assume there are no wakeup sources connected to this combiner. Setting irqchip flags should solve this problem. A simple patch below should do the job ? -->8 diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c index 5945223b73fa..c0bcec59f829 100644 --- a/drivers/irqchip/exynos-combiner.c +++ b/drivers/irqchip/exynos-combiner.c @@ -111,6 +111,7 @@ static struct irq_chip combiner_chip = { #ifdef CONFIG_SMP .irq_set_affinity = combiner_set_affinity, #endif + .flags = IRQCHIP_MASK_ON_SUSPEND, };