From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3XaS-0003Wy-Cq for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:38:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3XaP-0000Wo-7t for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:38:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3XaP-0000Wk-26 for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:38:05 -0400 Message-ID: <557B5F49.5050109@redhat.com> Date: Fri, 12 Jun 2015 16:38:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434117956-4929-1-git-send-email-dslutz@verizon.com> <1434117956-4929-2-git-send-email-dslutz@verizon.com> In-Reply-To: <1434117956-4929-2-git-send-email-dslutz@verizon.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qpJN4ttDW5NFkb52BabksJ6rCveW0k5Qh" Subject: Re: [Qemu-devel] [BUGFIX][PATCH v7 1/9] vmport: The io memory region needs to be at least a size of 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Don Slutz , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Markus Armbruster , Luiz Capitulino , Don Slutz , Anthony Liguori , Paolo Bonzini , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qpJN4ttDW5NFkb52BabksJ6rCveW0k5Qh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/12/2015 08:05 AM, Don Slutz wrote: > Before: >=20 > commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 > Author: Peter Crosthwaite > Date: Mon Mar 16 22:35:54 2015 -0700 >=20 > exec: Respect as_tranlsate_internal length clamp >=20 > it did not matter. Only accept I/O that starts on 1st > port. >=20 > Signed-off-by: Don Slutz > CC: Don Slutz > --- > hw/misc/vmport.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c > index 7fcc00d..51b64bc 100644 > --- a/hw/misc/vmport.c > +++ b/hw/misc/vmport.c > @@ -69,6 +69,10 @@ static uint64_t vmport_ioport_read(void *opaque, hwa= ddr addr, > unsigned char command; > uint32_t eax; > =20 > + /* Only support 1 address */ > + if (addr) { > + return ~0U; > + } Different answer on 32-bit platforms (there, ~0U is 0xffffffff, which then 0-extends to uint64_t rather than your desired result of 0xffffffffffffffffULL). Why can't you just 'return -1;'? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qpJN4ttDW5NFkb52BabksJ6rCveW0k5Qh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVe19JAAoJEKeha0olJ0Nq53QH/inWgvML7qP5pcCmYxzj0vHa KFBAGxeIObT1rubstY5WT8F7568tjPfmysZTM2wQFr4bpPFR6yB73VU91iMzRk94 z/UrkC7SjOr3gahqmR394xexAOPPzv8YrvcY5WkPVSKKZVJVu6LL3DGLPngZYx1m SXq7C7h4OdXxSkWLnzADTqE5SRW+NrNej/C4Hhe/DhGIKFo71hOWvSodOlOTK+Rg qhwhldOXsMd+Id2Qkbi2+W4ZQhMAWFckltZd++hNcKTrM0WV2qGtSzu6XiJp5I9l Q+2snfd5xrHpfmhXZgcVXHderYjKz20tSldZPmSyn/UQJNuQ5OcZrNmbuCosvE4= =6zCB -----END PGP SIGNATURE----- --qpJN4ttDW5NFkb52BabksJ6rCveW0k5Qh--