From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [RFC] drm/i915: prevent out of range pt in the PDE macros (take 2) Date: Mon, 15 Jun 2015 11:31:59 +0100 Message-ID: <557EA99F.2080500@intel.com> References: <1434144656-1557-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 975F96E481 for ; Mon, 15 Jun 2015 03:32:01 -0700 (PDT) In-Reply-To: <1434144656-1557-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gMTIvMDYvMTUgMjI6MzAsIFBhdWxvIFphbm9uaSB3cm90ZToKPiBGcm9tOiBQYXVsbyBaYW5v bmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KPiAKPiBXZSB0cmllZCB0byBmaXggdGhpcyBp biB0aGUgZm9sbG93aW5nIGNvbW1pdDoKPiAKPiBjb21taXQgZmRjNDU0YzE0ODRhMjBlMTM0NWNm NGU0ZDdhOWZlYWVlODE0MTQ3Zgo+IEF1dGhvcjogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGll cnJ5QGludGVsLmNvbT4KPiBEYXRlOiAgIFR1ZSBNYXIgMjQgMTU6NDY6MTkgMjAxNSArMDAwMAo+ ICAgICBkcm0vaTkxNTogUHJldmVudCBvdXQgb2YgcmFuZ2UgcHQgaW4gZ2VuNl9mb3JfZWFjaF9w ZGUKPiAKPiBidXQgdGhlIHN0YXRpYyBhbmFseXplciBzdGlsbCBjb21wbGFpbnMgdGhhdCwganVz dCBiZWZvcmUgd2UgYnJlYWsgZHVlCj4gdG8gIml0ZXIgPCBJOTE1X1BERVMiLCB3ZSBkbyAicHQg PSAocGQpLT5wYWdlX3RhYmxlW2l0ZXJdIiB3aXRoIGFuCj4gaXRlciB2YWx1ZSB0aGF0IGlzIGJp Z2dlciB0aGFuIEk5MTVfUERFUy4gT2YgY291cnNlLCB0aGlzIGlzbid0IHJlYWxseQo+IGEgcHJv YmxlbSBzaW5jZSBubyBvbmUgdXNlcyBwdCBvdXRzaWRlIHRoZSBtYWNyby4gU3RpbGwsIGV2ZXJ5 IHNpbmdsZQo+IG5ldyB1c2FnZSBvZiB0aGUgbWFjcm8gd2lsbCBjcmVhdGUgYSBuZXcgaXNzdWUg Zm9yIHVzIHRvIG1hcmsgYXMgYQo+IGZhbHNlIHBvc3NpdGl2ZS4KPiAKPiBBZnRlciB0aGUgY29t bWl0IG1lbnRpb25lZCBhYm92ZSB3ZSBhbHNvIGNyZWF0ZWQgc29tZSBuZXcgdmVyc2lvbnMgb2YK PiB0aGUgbWFjcm9zLCBzbyB0aGV5IGNhcnJ5IHRoZSBzYW1lICJwcm9ibGVtIi4KPiAKPiBJbiBv cmRlciB0byAic29sdmUiIHRoaXMgInByb2JsZW0iLCBsZXQncyBsZWF2ZSB0aGUgbWFjcm8gd2l0 aCBhIE5VTEwKPiB2YWx1ZSBmb3IgcHQuIFNvIGlmIHNvbWVib2R5IHVzZXMgaXQsIHdlJ3JlIG1v cmUgbGlrZWx5IHRvIGdldCBhIGJpZwo+IGVycm9yIG1lc3NhZ2UgaW5zdGVhZCBvZiBzb21lIHNp bGVudCBmYWlsdXJlLiBJIGhvcGUgdGhlIHN0YXRpYwo+IGFuYWx5emVyIHdvbid0IGNvbXBsYWlu IGFib3V0IHRoZSBuZXcgc29sdXRpb24gKEkgZG9uJ3QgaGF2ZSBhIHdheSB0bwo+IGNoZWNrIHRo aXMhKS4KPiAKPiBJIGtub3csIHRoZSBzb2x1dGlvbiBsb29rcyByZWFsbHkgdWdseS4gSSBhbSBo b3BpbmcgdGhlIHJldmlld2VycyB3aWxsCj4gaGVscCB1cyBkZWNpZGUgaWYgd2UgcHJlZmVyIHRo aXMgcGF0Y2ggb3IgaWYgd2UgcHJlZmVyIHRvIGtlZXAgbWFya2luZwo+IHRoaW5ncyBhcyBmYWxz ZSBwb3NpdGl2ZXMuCj4gCj4gQ2M6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRl bC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRl bC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oIHwgMTMg KysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCA0IGRlbGV0 aW9ucygtKQo+IAo+IEkgc2VudCB0aGlzIGFzIGFuIFJGQyBiZWNhdXNlIEkgcmVhbGx5IGRvbid0 IGtub3cgaWYgY29tcGxpY2F0aW5nIHRoZQo+IG1hY3JvIGV2ZW4gbW9yZSB3aWxsIGhlbHAgdXMg aW4gYW55IHdheS4gSSB3b24ndCByZWFsbHkgYmUgc3VycHJpc2VkCj4gaWYgSSBzZWUgTkFDS3Mg b24gdGhpcyBwYXRjaCwgc28gZG9uJ3QgaGVzaXRhdGUgaWYgeW91IHdhbnQgdG8uCj4gCj4gQWxz bywgYWxsIEkgZGlkIHdhcyBib290IGEgS2VybmVsIHdpdGggdGhpcyBwYXRjaCBhbmQgbWFrZSBz dXJlIGl0Cj4gc2hvd3MgdGhlIGRlc2t0b3AuIFNvIGNvbnNpZGVyIHRoaXMgYXMgdW50ZXN0ZWQs IHBvc3NpYmx5IGJyb2tlbi4KPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fZ3R0LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuaAo+IGlu ZGV4IDBkNDZkZDIuLmIyMDJjYTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fZ3R0LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQu aAo+IEBAIC0zNTIsNyArMzUyLDggQEAgc3RydWN0IGk5MTVfaHdfcHBndHQgewo+ICAgKi8KPiAg I2RlZmluZSBnZW42X2Zvcl9lYWNoX3BkZShwdCwgcGQsIHN0YXJ0LCBsZW5ndGgsIHRlbXAsIGl0 ZXIpIFwKPiAgCWZvciAoaXRlciA9IGdlbjZfcGRlX2luZGV4KHN0YXJ0KTsgXAo+IC0JICAgICBw dCA9IChwZCktPnBhZ2VfdGFibGVbaXRlcl0sIGxlbmd0aCA+IDAgJiYgaXRlciA8IEk5MTVfUERF UzsgXAo+ICsJICAgICBwdCA9IGl0ZXIgPCBJOTE1X1BERVMgPyAocGQpLT5wYWdlX3RhYmxlW2l0 ZXJdIDogTlVMTCwgXAo+ICsJICAgICBsZW5ndGggPiAwICYmIGl0ZXIgPCBJOTE1X1BERVM7IFwK CllvdSBkb24ndCBuZWVkIHRoZSByZXBlYXRlZCB0ZXN0IG9uICdpdGVyJzsgeW91IGNhbiB3cml0 ZSB0aGUgdGVzdApjbGF1c2Ugb2YgdGhlIGxvb3AgYXM6CgoJKHB0ID0gaXRlciA8IEk5MTVfUERF UyA/IChwZCktPnBhZ2VfdGFibGVbaXRlcl0gOiBOVUxMKSAmJgoJbGVuZ3RoID4gMDsKCnVzaW5n IHRoZSBmYWN0IHRoYXQgcHQgd2lsbCBiZSBOVUxMIHdoZW4gaXRlciA+PSBJOTE1X1BERVMgdG8g YnJlYWsgZnJvbQp0aGUgbG9vcCA6KQoKVGhpcyB2ZXJzaW9uIHdpbGwgbGVhdmUgJ3B0JyBOVUxM IGFmdGVyIHRoZSBsb29wIGlmIHRoZSBicmVhayB3YXMgZHVlIHRvCnRoZSB0ZXN0IG9uICdpdGVy JywgYnV0IG5vbi1OVUxMIGlmIHRoZSB0ZXN0IG9uICdsZW5ndGgnIHRyaWdnZXJlZCB0aGUKYnJl YWsgLS0gaXMgdGhpcyBhIHVzZWZ1bCBmZWF0dXJlPwoKLkRhdmUuCgo+ICAJICAgICB0ZW1wID0g QUxJR04oc3RhcnQrMSwgMSA8PCBHRU42X1BERV9TSElGVCkgLSBzdGFydCwgXAo+ICAJICAgICB0 ZW1wID0gbWluX3QodW5zaWduZWQsIHRlbXAsIGxlbmd0aCksIFwKPiBAQCAtMzYwLDcgKzM2MSw4 IEBAIHN0cnVjdCBpOTE1X2h3X3BwZ3R0IHsKPiAgCj4gICNkZWZpbmUgZ2VuNl9mb3JfYWxsX3Bk ZXMocHQsIHBwZ3R0LCBpdGVyKSAgXAo+ICAJZm9yIChpdGVyID0gMDsJCVwKPiAtCSAgICAgcHQg PSBwcGd0dC0+cGQucGFnZV90YWJsZVtpdGVyXSwgaXRlciA8IEk5MTVfUERFUzsJXAo+ICsJICAg ICBwdCA9IGl0ZXIgPCBJOTE1X1BERVMgPyBwcGd0dC0+cGQucGFnZV90YWJsZVtpdGVyXSA6IE5V TEwsIFwKPiArCSAgICAgaXRlciA8IEk5MTVfUERFUzsJXAo+ICAJICAgICBpdGVyKyspCj4gIAo+ ICBzdGF0aWMgaW5saW5lIHVpbnQzMl90IGk5MTVfcHRlX2luZGV4KHVpbnQ2NF90IGFkZHJlc3Ms IHVpbnQzMl90IHBkZV9zaGlmdCkKPiBAQCAtNDE3LDcgKzQxOSw4IEBAIHN0YXRpYyBpbmxpbmUg dWludDMyX3QgZ2VuNl9wZGVfaW5kZXgodWludDMyX3QgYWRkcikKPiAgICovCj4gICNkZWZpbmUg Z2VuOF9mb3JfZWFjaF9wZGUocHQsIHBkLCBzdGFydCwgbGVuZ3RoLCB0ZW1wLCBpdGVyKQkJXAo+ ICAJZm9yIChpdGVyID0gZ2VuOF9wZGVfaW5kZXgoc3RhcnQpOyBcCj4gLQkgICAgIHB0ID0gKHBk KS0+cGFnZV90YWJsZVtpdGVyXSwgbGVuZ3RoID4gMCAmJiBpdGVyIDwgSTkxNV9QREVTOwlcCj4g KwkgICAgIHB0ID0gaXRlciA8IEk5MTVfUERFUyA/IChwZCktPnBhZ2VfdGFibGVbaXRlcl0gOiBO VUxMLAlcCj4gKwkgICAgIGxlbmd0aCA+IDAgJiYgaXRlciA8IEk5MTVfUERFUzsJXAo+ICAJICAg ICBpdGVyKyssCQkJCVwKPiAgCSAgICAgdGVtcCA9IEFMSUdOKHN0YXJ0KzEsIDEgPDwgR0VOOF9Q REVfU0hJRlQpIC0gc3RhcnQsCVwKPiAgCSAgICAgdGVtcCA9IG1pbih0ZW1wLCBsZW5ndGgpLAkJ CQkJXAo+IEBAIC00MjUsNyArNDI4LDkgQEAgc3RhdGljIGlubGluZSB1aW50MzJfdCBnZW42X3Bk ZV9pbmRleCh1aW50MzJfdCBhZGRyKQo+ICAKPiAgI2RlZmluZSBnZW44X2Zvcl9lYWNoX3BkcGUo cGQsIHBkcCwgc3RhcnQsIGxlbmd0aCwgdGVtcCwgaXRlcikJCVwKPiAgCWZvciAoaXRlciA9IGdl bjhfcGRwZV9pbmRleChzdGFydCk7CVwKPiAtCSAgICAgcGQgPSAocGRwKS0+cGFnZV9kaXJlY3Rv cnlbaXRlcl0sIGxlbmd0aCA+IDAgJiYgaXRlciA8IEdFTjhfTEVHQUNZX1BEUEVTOwlcCj4gKwkg ICAgIHBkID0gaXRlciA8IEdFTjhfTEVHQUNZX1BEUEVTID8JCQkJXAo+ICsJCSAgKHBkcCktPnBh Z2VfZGlyZWN0b3J5W2l0ZXJdIDogTlVMTCwJCQlcCj4gKwkgICAgIGxlbmd0aCA+IDAgJiYgaXRl ciA8IEdFTjhfTEVHQUNZX1BEUEVTOwkJCVwKPiAgCSAgICAgaXRlcisrLAkJCQlcCj4gIAkgICAg IHRlbXAgPSBBTElHTihzdGFydCsxLCAxIDw8IEdFTjhfUERQRV9TSElGVCkgLSBzdGFydCwJXAo+ ICAJICAgICB0ZW1wID0gbWluKHRlbXAsIGxlbmd0aCksCQkJCQlcCj4gCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=