From mboxrd@z Thu Jan 1 00:00:00 1970 From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath) Date: Tue, 16 Jun 2015 13:11:36 +0530 Subject: [PATCH-V2 03/12] i2c: pxa: Return I2C_RETRY when timeout in pio mode In-Reply-To: References: <1434383399-2370-1-git-send-email-vaibhav.hiremath@linaro.org> <1434383399-2370-4-git-send-email-vaibhav.hiremath@linaro.org> Message-ID: <557FD330.7070707@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 16 June 2015 11:01 AM, Shubhrajyoti Datta wrote: > On Mon, Jun 15, 2015 at 9:19 PM, Vaibhav Hiremath > wrote: >> From: Shouming Wang >> >> In case of timeout in pio mode of operation return I2C_RETRY. >> This behavior will be same as interrupt mode of operation. >> >> Signed-off-by: Shouming Wang >> [vaibhav.hiremath at linaro.org: Updated changelog] >> Signed-off-by: Vaibhav Hiremath >> --- >> drivers/i2c/busses/i2c-pxa.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c >> index 023e59f..632008f 100644 >> --- a/drivers/i2c/busses/i2c-pxa.c >> +++ b/drivers/i2c/busses/i2c-pxa.c >> @@ -745,8 +745,10 @@ static int i2c_pxa_do_pio_xfer(struct pxa_i2c *i2c, >> ret = i2c->msg_idx; >> >> out: >> - if (timeout == 0) >> + if (timeout == 0) { >> i2c_pxa_scream_blue_murder(i2c, "timeout"); >> + ret = I2C_RETRY; > > Can we use standard return types. > Unfortunately NO. I2C_RETRY is used in many places, internal to the i2c-pcxa driver. This return value is internal only and used internally to the driver. Thanks, Vaibhav From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vaibhav Hiremath Subject: Re: [PATCH-V2 03/12] i2c: pxa: Return I2C_RETRY when timeout in pio mode Date: Tue, 16 Jun 2015 13:11:36 +0530 Message-ID: <557FD330.7070707@linaro.org> References: <1434383399-2370-1-git-send-email-vaibhav.hiremath@linaro.org> <1434383399-2370-4-git-send-email-vaibhav.hiremath@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shubhrajyoti Datta Cc: Linux-I2C , Shouming Wang , robert.jarzmik-GANU6spQydw@public.gmane.org, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Wolfram Sang List-Id: linux-i2c@vger.kernel.org On Tuesday 16 June 2015 11:01 AM, Shubhrajyoti Datta wrote: > On Mon, Jun 15, 2015 at 9:19 PM, Vaibhav Hiremath > wrote: >> From: Shouming Wang >> >> In case of timeout in pio mode of operation return I2C_RETRY. >> This behavior will be same as interrupt mode of operation. >> >> Signed-off-by: Shouming Wang >> [vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org: Updated changelog] >> Signed-off-by: Vaibhav Hiremath >> --- >> drivers/i2c/busses/i2c-pxa.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c >> index 023e59f..632008f 100644 >> --- a/drivers/i2c/busses/i2c-pxa.c >> +++ b/drivers/i2c/busses/i2c-pxa.c >> @@ -745,8 +745,10 @@ static int i2c_pxa_do_pio_xfer(struct pxa_i2c *i2c, >> ret = i2c->msg_idx; >> >> out: >> - if (timeout == 0) >> + if (timeout == 0) { >> i2c_pxa_scream_blue_murder(i2c, "timeout"); >> + ret = I2C_RETRY; > > Can we use standard return types. > Unfortunately NO. I2C_RETRY is used in many places, internal to the i2c-pcxa driver. This return value is internal only and used internally to the driver. Thanks, Vaibhav