From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754528AbbFPMNk (ORCPT ); Tue, 16 Jun 2015 08:13:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40891 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644AbbFPMNc (ORCPT ); Tue, 16 Jun 2015 08:13:32 -0400 Message-ID: <558012E8.8090605@suse.cz> Date: Tue, 16 Jun 2015 14:13:28 +0200 From: Vlastimil Babka User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Joonsoo Kim CC: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Mel Gorman , Michal Nazarewicz , Naoya Horiguchi , Christoph Lameter , Rik van Riel , David Rientjes Subject: Re: [PATCH 3/6] mm, compaction: encapsulate resetting cached scanner positions References: <1433928754-966-1-git-send-email-vbabka@suse.cz> <1433928754-966-4-git-send-email-vbabka@suse.cz> <20150616054115.GC12641@js1304-P5Q-DELUXE> In-Reply-To: <20150616054115.GC12641@js1304-P5Q-DELUXE> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2015 07:41 AM, Joonsoo Kim wrote: > On Wed, Jun 10, 2015 at 11:32:31AM +0200, Vlastimil Babka wrote: >> Resetting the cached compaction scanner positions is now done implicitly in >> __reset_isolation_suitable() and compact_finished(). Encapsulate the >> functionality in a new function reset_cached_positions() and call it explicitly >> where needed. >> >> Signed-off-by: Vlastimil Babka >> Cc: Minchan Kim >> Cc: Mel Gorman >> Cc: Joonsoo Kim >> Cc: Michal Nazarewicz >> Cc: Naoya Horiguchi >> Cc: Christoph Lameter >> Cc: Rik van Riel >> Cc: David Rientjes >> --- >> mm/compaction.c | 22 ++++++++++++++-------- >> 1 file changed, 14 insertions(+), 8 deletions(-) >> >> diff --git a/mm/compaction.c b/mm/compaction.c >> index 7e0a814..d334bb3 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -207,6 +207,13 @@ static inline bool isolation_suitable(struct compact_control *cc, >> return !get_pageblock_skip(page); >> } >> >> +static void reset_cached_positions(struct zone *zone) >> +{ >> + zone->compact_cached_migrate_pfn[0] = zone->zone_start_pfn; >> + zone->compact_cached_migrate_pfn[1] = zone->zone_start_pfn; >> + zone->compact_cached_free_pfn = zone_end_pfn(zone); >> +} >> + >> /* >> * This function is called to clear all cached information on pageblocks that >> * should be skipped for page isolation when the migrate and free page scanner >> @@ -218,9 +225,6 @@ static void __reset_isolation_suitable(struct zone *zone) >> unsigned long end_pfn = zone_end_pfn(zone); >> unsigned long pfn; >> >> - zone->compact_cached_migrate_pfn[0] = start_pfn; >> - zone->compact_cached_migrate_pfn[1] = start_pfn; >> - zone->compact_cached_free_pfn = end_pfn; >> zone->compact_blockskip_flush = false; > > Is there a valid reason not to call reset_cached_positions() in > __reset_isolation_suitable? Hm maybe not, except being somewhat implicit again. It might had a stronger reason in the previous patchset. > You missed one callsite in > __compact_pgdat(). > > if (cc->order == -1) > __reset_isolation_suitable(zone); > > This also needs reset_cached_positions(). Ah, good catch. Thanks. > > Thanks. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com [209.85.217.172]) by kanga.kvack.org (Postfix) with ESMTP id 7F6306B0038 for ; Tue, 16 Jun 2015 08:13:34 -0400 (EDT) Received: by lbbti3 with SMTP id ti3so9481698lbb.1 for ; Tue, 16 Jun 2015 05:13:33 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id kw8si1428164wjb.181.2015.06.16.05.13.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 16 Jun 2015 05:13:32 -0700 (PDT) Message-ID: <558012E8.8090605@suse.cz> Date: Tue, 16 Jun 2015 14:13:28 +0200 From: Vlastimil Babka MIME-Version: 1.0 Subject: Re: [PATCH 3/6] mm, compaction: encapsulate resetting cached scanner positions References: <1433928754-966-1-git-send-email-vbabka@suse.cz> <1433928754-966-4-git-send-email-vbabka@suse.cz> <20150616054115.GC12641@js1304-P5Q-DELUXE> In-Reply-To: <20150616054115.GC12641@js1304-P5Q-DELUXE> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Mel Gorman , Michal Nazarewicz , Naoya Horiguchi , Christoph Lameter , Rik van Riel , David Rientjes On 06/16/2015 07:41 AM, Joonsoo Kim wrote: > On Wed, Jun 10, 2015 at 11:32:31AM +0200, Vlastimil Babka wrote: >> Resetting the cached compaction scanner positions is now done implicitly in >> __reset_isolation_suitable() and compact_finished(). Encapsulate the >> functionality in a new function reset_cached_positions() and call it explicitly >> where needed. >> >> Signed-off-by: Vlastimil Babka >> Cc: Minchan Kim >> Cc: Mel Gorman >> Cc: Joonsoo Kim >> Cc: Michal Nazarewicz >> Cc: Naoya Horiguchi >> Cc: Christoph Lameter >> Cc: Rik van Riel >> Cc: David Rientjes >> --- >> mm/compaction.c | 22 ++++++++++++++-------- >> 1 file changed, 14 insertions(+), 8 deletions(-) >> >> diff --git a/mm/compaction.c b/mm/compaction.c >> index 7e0a814..d334bb3 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -207,6 +207,13 @@ static inline bool isolation_suitable(struct compact_control *cc, >> return !get_pageblock_skip(page); >> } >> >> +static void reset_cached_positions(struct zone *zone) >> +{ >> + zone->compact_cached_migrate_pfn[0] = zone->zone_start_pfn; >> + zone->compact_cached_migrate_pfn[1] = zone->zone_start_pfn; >> + zone->compact_cached_free_pfn = zone_end_pfn(zone); >> +} >> + >> /* >> * This function is called to clear all cached information on pageblocks that >> * should be skipped for page isolation when the migrate and free page scanner >> @@ -218,9 +225,6 @@ static void __reset_isolation_suitable(struct zone *zone) >> unsigned long end_pfn = zone_end_pfn(zone); >> unsigned long pfn; >> >> - zone->compact_cached_migrate_pfn[0] = start_pfn; >> - zone->compact_cached_migrate_pfn[1] = start_pfn; >> - zone->compact_cached_free_pfn = end_pfn; >> zone->compact_blockskip_flush = false; > > Is there a valid reason not to call reset_cached_positions() in > __reset_isolation_suitable? Hm maybe not, except being somewhat implicit again. It might had a stronger reason in the previous patchset. > You missed one callsite in > __compact_pgdat(). > > if (cc->order == -1) > __reset_isolation_suitable(zone); > > This also needs reset_cached_positions(). Ah, good catch. Thanks. > > Thanks. > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org