From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756589AbbFPNML (ORCPT ); Tue, 16 Jun 2015 09:12:11 -0400 Received: from smtp89.iad3a.emailsrvr.com ([173.203.187.89]:47307 "EHLO smtp89.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755788AbbFPNL6 (ORCPT ); Tue, 16 Jun 2015 09:11:58 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <5580209A.1050205@mev.co.uk> Date: Tue, 16 Jun 2015 14:11:54 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: "Abdul, Hussain (H.)" , "gregkh@linuxfoundation.org" CC: "hsweeten@visionengravers.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Ravindran, Madhusudhanan (M.)" , "Dighe, Niranjan (N.)" Subject: Re: [PATCH] Staging: comedi: Simplify a trivial if-return sequence References: <1434441401-13894-1-git-send-email-habdul@visteon.com> In-Reply-To: <1434441401-13894-1-git-send-email-habdul@visteon.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/15 08:58, Abdul, Hussain (H.) wrote: > From: Abdul Hussain > > This patch simplify a trivial if-return sequence. Possibly combine with > a preceding function call. > > Signed-off-by: Abdul Hussain > --- > drivers/staging/comedi/drivers/dac02.c | 6 +----- > drivers/staging/comedi/drivers/daqboard2000.c | 6 +----- > drivers/staging/comedi/drivers/dmm32at.c | 6 +----- > drivers/staging/comedi/drivers/fl512.c | 6 +----- > drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +----- > drivers/staging/comedi/drivers/s626.c | 6 +----- > 6 files changed, 6 insertions(+), 30 deletions(-) > Ideally, this should be split into separate patches. [snip] > diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c > index 611b0a3..0fe40c2 100644 > --- a/drivers/staging/comedi/drivers/daqboard2000.c > +++ b/drivers/staging/comedi/drivers/daqboard2000.c > @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev, > return result; > > s = &dev->subdevices[2]; > - result = subdev_8255_init(dev, s, daqboard2000_8255_cb, > + return subdev_8255_init(dev, s, daqboard2000_8255_cb, > dioP2ExpansionIO8Bit); That 'dioP2ExpansionIO8Bit' line could do with being un-indented by a couple of spaces so it still lines up with the 'dev' on the preceding line. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-