From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH V4 3/7] libxl: add pvusb API Date: Tue, 16 Jun 2015 15:32:58 +0200 Message-ID: <5580258A.8020401@suse.com> References: <1433906441-3280-1-git-send-email-cyliu@suse.com> <1433906441-3280-4-git-send-email-cyliu@suse.com> <21887.64856.265751.921367@mariner.uk.xensource.com> <558000E5.9000803@suse.com> <21888.1058.681450.470806@mariner.uk.xensource.com> <5580079D.6070007@suse.com> <21888.4161.841504.686364@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap , Ian Jackson Cc: Wei Liu , Ian Campbell , Chunyan Liu , "xen-devel@lists.xen.org" , Jim Fehlig , Simon Cao List-Id: xen-devel@lists.xenproject.org On 06/16/2015 03:19 PM, George Dunlap wrote: > On Tue, Jun 16, 2015 at 1:02 PM, Ian Jackson wrote: >> George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): >>> So it sounds like we're converging on "Allow multiple ways to specify >>> the interface", with at least the following fields: >>> - bus (int - 1,2,3, &c) >>> - port (string - 2.1.3, &c) >>> - address/devnum (int) >>> - vendorid (uint16_t) >>> - deviceid (uint16_t) >> >> You're missing the full device path from that list. Typically that >> will include at least one pci bus address. > > I'm not sure what constitutes a "full device path". Is that defined somewhere? > > Remember that the path you gave in your previous e-mail isn't the path > for the *usb device*, it's the path for the *block device*. It > contains a PCI address, but it looks like it also contains part of the > USB topology. Are you sure that's actually a stable interface, or > does it just happen that on your hardware the discovery always happens > in the same order? > > On my system /sys/bus/usb/devices/2-3.3 is a link to > /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-3/2-3.3/. This contains > the pci bus address, but it also contains the bus number, which we've > just said may be unstable across reboots. > > I suppose it might be possible to specify -- the pci > address of the root bus, and the topology from there. In theory I > guess that should be stable? Hmm, perhaps. On my system I've got: /sys/devices/pci0000:00/0000:00:14.0/usb3/ /sys/devices/pci0000:00/0000:00:14.0/usb4/ So two busses on one pci bus address. Are usb3 and usb4 always in this order or are they sometimes just numbered the other way round? Juergen