From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Hongyang Subject: Re: [PATCH v2 3/6] tools/libxl: move domain resume code into libxl_dom_suspend.c Date: Tue, 16 Jun 2015 21:50:25 +0800 Message-ID: <558029A1.1060505@cn.fujitsu.com> References: <1433318493-24561-1-git-send-email-yanghy@cn.fujitsu.com> <1433318493-24561-4-git-send-email-yanghy@cn.fujitsu.com> <1434459878.13744.139.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1434459878.13744.139.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, eddie.dong@intel.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca List-Id: xen-devel@lists.xenproject.org On 06/16/2015 09:04 PM, Ian Campbell wrote: > On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote: >> move domain resume code into libxl_dom_suspend.c. > > Even though it has "resume" in the name, I'm not sure that > libxl__domain_s3_resume is a good candidate for moving to the suspend > code, it's called only from libxl_send_trigger and IIRC we don't really > implement s3, just a fake version where the domain is paused/unpaused > (rather the destroyed and resumed, say. > > Having moved libxl__domain_resume and libxl__domain_resume_device_model > into the same file I think the latter could become static. (If you do > that in this patch please say something along the lines of "pure code > motion except for making libxl__domain_resume_device_model static" in > the commit message) ok, will fix this in the next version, thank you for the review! > > > . > -- Thanks, Yang.